Don't use a scrollview to display package changelogs
ClosedPublic

Authored by ngraham on Nov 17 2017, 3:07 PM.

Details

Summary

BUG: 387036

Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).

Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.

Test Plan

Tested in KDE Neon. Package changelogs are now fully visible without being in a tiny scrollview:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 17 2017, 3:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 17 2017, 3:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham edited the summary of this revision. (Show Details)Nov 17 2017, 3:09 PM
ngraham edited the test plan for this revision. (Show Details)

Can't the changelog become utterly long? Perhaps a popup/overlay sheet thing would be more appropriate

apol added a comment.Nov 17 2017, 3:18 PM

Won't this introduce other usability issues? :/

WRT the patch, it's fine, just remove the RowLayout and put its properties into the label

If the changelog is like a thousand lines long, you can always just close it again. And I think it would actually be easier to read as one huge box than a tiny scrollview that only shows like 5 lines at a time.

Another option would be that clicking on a package takes you to another view or overlay (like Kai suggested), but that would be more involved and you would lose the ability to quickly see the changelogs for multiple packages.

abetts added a subscriber: abetts.Nov 17 2017, 3:24 PM

What's the point of having the "open" button if this scrollview is accepted? After all, you won't see much more if you click open and an install button and a package description.

ngraham added a comment.EditedNov 17 2017, 3:29 PM

IMHO the open button is superfluous for package updates anyway. It takes you to a view that doesn't even show you the changelogs.

Perhaps what we should do is the following:

  • Get rid of the Open button
  • Make clicking on the package take you to the view that the Open button shows
  • Centralize all information on that page, including the package changelogs

That's a more involved change than I'm going to be able to make right now though. But I think it would be a nice improvement.

ngraham updated this revision to Diff 22528.Nov 17 2017, 3:30 PM

Updating diff

ngraham updated this revision to Diff 22532.Nov 17 2017, 4:00 PM

Add a frame around the text if the box is extended

ngraham edited the test plan for this revision. (Show Details)Nov 17 2017, 4:00 PM
apol accepted this revision.Nov 17 2017, 4:06 PM

Okay, let's give it a try and see where this takes us.

This revision is now accepted and ready to land.Nov 17 2017, 4:06 PM
ngraham updated this revision to Diff 22533.Nov 17 2017, 4:10 PM

Also change "Open" button to say "More Information..." (it's not clear what you were opening before)

ngraham edited the summary of this revision. (Show Details)Nov 17 2017, 4:11 PM
ngraham edited the test plan for this revision. (Show Details)

@apol Thanks! I made one more change (the text of the "Info") button; does your approval still hold?

apol accepted this revision.Nov 17 2017, 4:18 PM

Go for it, master branch.

This revision was automatically updated to reflect the committed changes.