| davidedmundson |
| Plasma |
We were reporting that the margins were changing whenever anything changed
in a FrameSvg, this patch makes sure we are only reporting the changes
when it actually changes.
This also fixes a binding loop in Desktop.qml from plasma-desktop.
BUG: 382233
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Good idea with the RAII class.
If we're doing some caching in there now anyway, can we perhaps add individual signals for the margins or is it not worth it?
If we're doing some caching in there now anyway, can we perhaps add individual signals for the margins or is it not worth it?
No, we don't have any caching. Also they never seem to change, on my system it goes from 0 (default) to 6 for all of them (whatever is in my theme I guess) and it stays like that. I wouldn't worry about separate signals.
| src/declarativeimports/core/framesvgitem.cpp | ||
|---|---|---|
| 295 | If we always have 4 and can initialised them to 0 qreal[4] with a c style array would be better. | |
| src/declarativeimports/core/framesvgitem.cpp | ||
|---|---|---|
| 295 | Would it? it's harder to compare then as you can't do a simple != | |