Add edit button to desktop theme
ClosedPublic

Authored by davidedmundson on Sep 27 2017, 11:26 AM.

Details

Summary

This option is only visible in plasmathemeexplorer is installed. This
makes it easy to edit themes, without cluttering the UI of normal users.

Edit button is made similar to the action buttons in the wallpaper
delegate. (though this is copying an existing bug of of using
plasmacomponents where they shouldn't be)

MouseArea got collapsed into the parent Item in the delegate as it makes
for more readable implicit z-ordering to have the button on top.

Test Plan

Clicked on one, explorer for that theme appeared.
Faked not having theme explorer by temporarily putting a typo in the service name. No buttons showed

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2017, 11:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham added a subscriber: ngraham.Nov 2 2017, 1:14 PM
abetts added a subscriber: abetts.Nov 2 2017, 1:30 PM

Well, looks like there are no objections... hehe

apol added a subscriber: apol.Nov 2 2017, 2:23 PM
apol added inline comments.
kcms/desktoptheme/kcm.cpp
68

Wouldn't it be better to just do QStandardPaths::findExecutable("plasmathemeexplorer")? This way we don't need a new dependency

256

QProcess?

davidedmundson marked 2 inline comments as done.Nov 16 2017, 4:08 PM
apol accepted this revision.Nov 16 2017, 10:35 PM
This revision is now accepted and ready to land.Nov 16 2017, 10:35 PM

Sry for not pinging back earlier but this sounds awesome.

This revision was automatically updated to reflect the committed changes.