Add end-of-file newlines

Address feedback

Okay. But then the difference between a sheet and a dialog is inherently nebulous: a short sheet is like a dialog; a tall dialog is like a sheet. In my mind it makes sense to use one thing for both and tweak the presentation accordingly. Clearly lots of people are using OverlaySheet as a dialog.

In D28664#646279, @ngraham wrote:

Well, one of the ideas of Kirigami is to not spawn new windows when not needed.

Well, one of the ideas of Kirigami is to not spawn new windows when not needed. Maybe the basic QQC2 popup (which does open centered) needs to gain the same visual style as an OverlaySheet. Or maybe OverlaySheet should be able to be used as a centered pop-up thingy.

In D28664#646254, @ngraham wrote:

I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be improved:

Don't you think that might look better vertically centered?

I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be improved:

Add whitespace

Use heuristics instead of exposing new API

Add tests

Add currentRoutes function

Address feedback

Add bringToView and isCurrent

Fix bad image text

Improve documentation

Address feedback (both human and compiler), improve examples, port to QQmlParserStatus

Fix Doxygen errors

Fix Doxygen issues

@include not resolving, will fix

Those @includes aren't resolving properly, will fix

I think having the overlaysheet glued to the bottom is fine for a very tall sheet that's scrollable or almost scrollable. But when it's not very tall, having it vertically centered makes more sense IMO. A short sheet glued to the bottom looks very weird to me. Rather than exposing yet another setting here, I think automatically choosing an alignment based on height would make more sense.

In D28664#643921, @ngraham wrote:

Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before?

Generally +1 on better docs

+1
documentation improvements are always very welcome

Nice!

Add search

Adjust images to fit above a baseline

Fix opacity issues

In D28666#644079, @ngraham wrote:

I'm not a Javascript expert, but the old/current versions seem much more readable to me. Is there a performance advantage to your proposed new versions?

Address feedback

In D28134#643899, @kossebau wrote:

Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console

Breaks compilation with Qt 5.13 too.

+1 for the .some() use
-1 on the convoluted Array.prototype things, especially when chained.

I'm not a Javascript expert, but the old/current versions seem much more readable to me. Is there a performance advantage to your proposed new versions?

Use Array.prototype.*.call() instead of Array.from to reduce copying

Use Array.from

Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before?

Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console

thanks, almost ready to go :)

​

Dang this looks so good. +1 for the visuals at least.

Better documentation comment

This fixes https://bugs.kde.org/show_bug.cgi?id=415526

Looks like a nice visual improvement.

thanks for it :)
tough yeah, it'll have to wait for now

rebased on master

Rewrite PendingValue to use QFuture

Address issues

Add documentation

Can I get any more feedback on this? what do I have to do to get it merged?

I am going to commit some unit tests for this so I don't miss something else :)

Address feedback

Address more feedback