src/icon.h
37	Maybe instead of internet something like "a remote url" since it may be from the local network as well
69	Maybe mention that it's read-only. Do we have some standard way of doing that?

src/icon.h
69	It's mentioned by Doxygen

Generally +1 on better docs

src/icon.h
53	Mention `Default is "unknown"`
58	is not found, or is it "failed to load"?
71–75	Urgh, I wonder why this property got shadowed and why it is `CONSTANT` :0
81	"Typically used when an element is hovered"?
85	Huh?
99	`Selected`
113	This sounds to me as if you end up with a colored square. :)

Those @includes aren't resolving properly, will fix

Fix Doxygen issues

Address feedback

This revision is now accepted and ready to land.Apr 20 2020, 3:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			Mainpage.dox (4 lines)
A	M	(bin)	docs/pics/icon/active.png
A	M	(bin)	docs/pics/icon/selected.png
A	M		examples/icon/CustomSource.qml (3 lines)
A	M		examples/icon/Fallback.qml (4 lines)
A	M		examples/icon/FilesystemSource.qml (3 lines)
A	M		examples/icon/IconThemeSource.qml (3 lines)
A	M		examples/icon/InternetSource.qml (3 lines)
A	M		examples/icon/ResourceSource.qml (3 lines)
M			src/icon.h (94 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79669	3263c5a		Apr 8 2020, 9:19 PM	★	★
Diff 2	79744	3263c5a	Fix Doxygen issues	Apr 10 2020, 1:20 AM	★	★
Diff 3	79787	3263c5a	Address feedback	Apr 10 2020, 7:04 PM	★	★
Diff 4	80709	0d5d94e	R169:9dba4c8b1583cf14024fb947e3f4feb0f65d3369	Apr 20 2020, 9:38 PM	★	★