Differential D28730

Couple of 'trivial' fixes for broken code
ClosedPublic
Actions

Authored by ouwerkerk on Apr 10 2020, 8:04 PM.

Details

Reviewers
cblack
Group Reviewers
Kirigami
Commits
R169:57c63e7ceeb9: Couple of 'trivial' fixes for broken code
Summary

Issues were found by running code with QT_QUICK_CONTROLS_MOBILE=1

  • Units does not exist in SwipeListItem due to how Kirigami is imported
  • ActionButton (private) is trying to call hasOwnProperty() on null

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ouwerkerk created this revision.Apr 10 2020, 8:04 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 10 2020, 8:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ouwerkerk requested review of this revision.Apr 10 2020, 8:04 PM
cblack accepted this revision.Apr 17 2020, 5:15 PM
cblack added a subscriber: cblack.

LGTM.

This revision is now accepted and ready to land.Apr 17 2020, 5:15 PM
Closed by commit R169:57c63e7ceeb9: Couple of 'trivial' fixes for broken code (authored by ouwerkerk). · Explain WhyApr 17 2020, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80413

View Options

src/controls/private/ActionButton.qml

Loading...
View Options

src/controls/templates/SwipeListItem.qml

Loading...