Feed Advanced Search

Advanced Search
Use Results
Hide Query

Apr 12 2020

astippich updated the summary of D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 12 2020, 8:17 AM · Baloo, Frameworks
bruns accepted D28682: rename and export newBatchTime signal in filecontentindexer.

thx

Apr 12 2020, 8:16 AM · Baloo, Frameworks
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
  • implement feedback
Apr 12 2020, 8:14 AM · Baloo, Frameworks

Apr 11 2020

dfaure accepted D28738: Use KFileItem::recursiveSize to Display recursize size as total size.
Apr 11 2020, 9:10 AM · Baloo
meven updated the test plan for D28738: Use KFileItem::recursiveSize to Display recursize size as total size.
Apr 11 2020, 6:33 AM · Baloo
meven updated the diff for D28738: Use KFileItem::recursiveSize to Display recursize size as total size.

When KIO::UDSEntry::UDS_RECURSIVE_SIZE is provided consider the size known

Apr 11 2020, 6:31 AM · Baloo
meven updated the summary of D28738: Use KFileItem::recursiveSize to Display recursize size as total size.
Apr 11 2020, 6:28 AM · Baloo
meven added a dependency for D28738: Use KFileItem::recursiveSize to Display recursize size as total size: D24773: kio_trash: Add size, modification, access and create date for trash:/.
Apr 11 2020, 6:28 AM · Baloo
meven updated the test plan for D28738: Use KFileItem::recursiveSize to Display recursize size as total size.
Apr 11 2020, 6:27 AM · Baloo
meven requested review of D28738: Use KFileItem::recursiveSize to Display recursize size as total size.
Apr 11 2020, 6:25 AM · Baloo

Apr 10 2020

bruns requested changes to D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 10 2020, 9:19 AM · Baloo, Frameworks
astippich retitled D28682: rename and export newBatchTime signal in filecontentindexer from export done signal in filecontentindexer to rename and export done signal in filecontentindexer.
Apr 10 2020, 8:00 AM · Baloo, Frameworks
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
  • rename signal
Apr 10 2020, 7:59 AM · Baloo, Frameworks

Apr 9 2020

astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

How about committedBatch so that it's clear that they have been committed to the database?

Apr 9 2020, 7:31 PM · Baloo, Frameworks
bruns added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

Regarding API, done is a little bit vague.

Apr 9 2020, 4:29 PM · Baloo, Frameworks
bruns added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
In D28682#644914, @astippich wrote:

Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call.

Apr 9 2020, 4:27 PM · Baloo, Frameworks
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call.

Apr 9 2020, 4:15 PM · Baloo, Frameworks

Apr 8 2020

bruns added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
In D28682#644430, @astippich wrote:
In D28682#644414, @bruns wrote:

In general fine for me.

How will Elisa deal with the indexer maybe crashing inbetween? Do we also need a signal for a batch start?

From my (limited) understanding, the finishedIndexingFile will no be emitted when an indexers crashes, does it? Then I think it is fine without an additional signal as long as the done() signal is still emitted as it is possible to reset the applications' internal list. Or will it retry some files of the current batch?

Apr 8 2020, 7:05 PM · Baloo, Frameworks
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
In D28682#644412, @mgallien wrote:

This is the reason why it is so slow in Elisa?

Apr 8 2020, 6:09 PM · Baloo, Frameworks
bruns added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

In general fine for me.

Apr 8 2020, 5:42 PM · Baloo, Frameworks
mgallien added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

This is the reason why it is so slow in Elisa?

Apr 8 2020, 5:33 PM · Baloo, Frameworks
astippich requested review of D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 8 2020, 4:58 PM · Baloo, Frameworks

Apr 7 2020

bruns added a comment to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
In D28400#643965, @bcooksley wrote:

Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS.

Apr 7 2020, 8:00 PM · Baloo, Frameworks
vkrause added inline comments to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Apr 7 2020, 8:00 PM · Baloo, Frameworks
bcooksley added a comment to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.

Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS.

Apr 7 2020, 7:20 PM · Baloo, Frameworks
bruns added inline comments to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Apr 7 2020, 7:10 PM · Baloo, Frameworks
bruns added a comment to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
In D28400#643934, @bcooksley wrote:

The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD:

Apr 7 2020, 7:05 PM · Baloo, Frameworks
bcooksley added a comment to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.

The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD:

Apr 7 2020, 6:42 PM · Baloo, Frameworks
kossebau added inline comments to D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Apr 7 2020, 6:25 PM · Baloo, Frameworks
bruns closed D28500: [PhraseAndIteratorTest] Cleanup, use better variable names.
Apr 7 2020, 3:22 PM · Baloo, Frameworks
bruns closed D28401: [SearchStore] Handle double values in property queries.
Apr 7 2020, 3:19 PM · Baloo, Frameworks
bruns closed D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Apr 7 2020, 3:18 PM · Baloo, Frameworks
bruns closed D28328: [Inotify] Remove not-so-OptimizedByteArray.
Apr 7 2020, 3:16 PM · Baloo, Frameworks
bruns closed D28324: [Inotify] Remove dead/duplicate code.
Apr 7 2020, 3:16 PM · Baloo, Frameworks
ngraham accepted D28500: [PhraseAndIteratorTest] Cleanup, use better variable names.
Apr 7 2020, 3:11 PM · Baloo, Frameworks
ngraham accepted D28401: [SearchStore] Handle double values in property queries.
Apr 7 2020, 3:10 PM · Baloo, Frameworks
ngraham accepted D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Apr 7 2020, 3:08 PM · Baloo, Frameworks
ngraham accepted D28328: [Inotify] Remove not-so-OptimizedByteArray.
Apr 7 2020, 3:07 PM · Baloo, Frameworks
ngraham accepted D28324: [Inotify] Remove dead/duplicate code.

I think this is fine.

Apr 7 2020, 3:05 PM · Baloo, Frameworks

Apr 5 2020

bruns closed D28565: [QueryParser] Replace single-use helper with std::none_of.
Apr 5 2020, 10:52 AM · Baloo, Frameworks
apol accepted D28565: [QueryParser] Replace single-use helper with std::none_of.
Apr 5 2020, 2:24 AM · Baloo, Frameworks

Apr 4 2020

bruns requested review of D28565: [QueryParser] Replace single-use helper with std::none_of.
Apr 4 2020, 3:10 PM · Baloo, Frameworks

Apr 3 2020

bruns closed D28501: [SearchStore] Use categorized logging.
Apr 3 2020, 3:26 AM · Baloo, Frameworks
ngraham accepted D28501: [SearchStore] Use categorized logging.
Apr 3 2020, 12:34 AM · Baloo, Frameworks

Apr 2 2020

bruns updated the diff for D28501: [SearchStore] Use categorized logging.

.

Apr 2 2020, 7:51 PM · Baloo, Frameworks
bruns closed D28506: [QueryParser] Fix broken detection of end quote.
Apr 2 2020, 7:47 PM · Baloo, Frameworks
bruns closed D28505: [EngineQuery] Provide toString(Term) overload for QTest.
Apr 2 2020, 7:46 PM · Baloo, Frameworks
bruns closed D28504: [EngineQuery] Remove unused position member, extend tests.
Apr 2 2020, 7:46 PM · Baloo, Frameworks
bruns closed D28503: [Term] Make debug output more compact and nicer to read.
Apr 2 2020, 7:45 PM · Baloo, Frameworks
ngraham accepted D28504: [EngineQuery] Remove unused position member, extend tests.
Apr 2 2020, 5:04 PM · Baloo, Frameworks
ngraham accepted D28505: [EngineQuery] Provide toString(Term) overload for QTest.
Apr 2 2020, 4:59 PM · Baloo, Frameworks
ngraham accepted D28506: [QueryParser] Fix broken detection of end quote.

Whoops!

Apr 2 2020, 4:58 PM · Baloo, Frameworks
ngraham accepted D28503: [Term] Make debug output more compact and nicer to read.
Apr 2 2020, 4:55 PM · Baloo, Frameworks
ngraham added inline comments to D28501: [SearchStore] Use categorized logging.
Apr 2 2020, 4:50 PM · Baloo, Frameworks
bruns added inline comments to D28501: [SearchStore] Use categorized logging.
Apr 2 2020, 10:10 AM · Baloo, Frameworks
bruns closed D28502: [baloosearch] Bail out early if specified folder is not valid.
Apr 2 2020, 10:03 AM · Baloo, Frameworks
apol accepted D28502: [baloosearch] Bail out early if specified folder is not valid.
Apr 2 2020, 9:59 AM · Baloo, Frameworks
apol added inline comments to D28501: [SearchStore] Use categorized logging.
Apr 2 2020, 9:57 AM · Baloo, Frameworks
bruns requested review of D28506: [QueryParser] Fix broken detection of end quote.
Apr 2 2020, 9:22 AM · Baloo, Frameworks
bruns requested review of D28505: [EngineQuery] Provide toString(Term) overload for QTest.
Apr 2 2020, 9:04 AM · Baloo, Frameworks
bruns requested review of D28504: [EngineQuery] Remove unused position member, extend tests.
Apr 2 2020, 9:01 AM · Baloo, Frameworks
bruns requested review of D28503: [Term] Make debug output more compact and nicer to read.
Apr 2 2020, 8:57 AM · Baloo, Frameworks
bruns requested review of D28502: [baloosearch] Bail out early if specified folder is not valid.
Apr 2 2020, 8:54 AM · Baloo, Frameworks
bruns requested review of D28501: [SearchStore] Use categorized logging.
Apr 2 2020, 8:53 AM · Baloo, Frameworks
bruns requested review of D28500: [PhraseAndIteratorTest] Cleanup, use better variable names.
Apr 2 2020, 8:52 AM · Baloo, Frameworks

Mar 31 2020

usta closed D28452: Fix baloo compile.

I still need to learn how to use arc land properly

Mar 31 2020, 1:43 AM · Frameworks, Baloo
usta added 1 commit(s) for D28452: Fix baloo compile: R293:ac7f7df21366: Fix compile.
Mar 31 2020, 1:42 AM · Frameworks, Baloo
cblack accepted D28452: Fix baloo compile.
Mar 31 2020, 1:37 AM · Frameworks, Baloo
usta added a reviewer for D28452: Fix baloo compile: ngraham.
Mar 31 2020, 1:31 AM · Frameworks, Baloo
usta updated the summary of D28452: Fix baloo compile.
Mar 31 2020, 1:30 AM · Frameworks, Baloo
usta added a reviewer for D28452: Fix baloo compile: Baloo.
Mar 31 2020, 1:30 AM · Frameworks, Baloo
usta requested review of D28452: Fix baloo compile.
Mar 31 2020, 1:29 AM · Frameworks, Baloo

Mar 30 2020

bruns closed D28396: [MTimeDB] Consolidate time interval handling code.
Mar 30 2020, 9:15 PM · Baloo, Frameworks
bruns closed D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly.
Mar 30 2020, 9:15 PM · Baloo, Frameworks
bruns closed D28393: [Term] Provide toString(Term) overload for QTest.
Mar 30 2020, 9:15 PM · Baloo, Frameworks
bruns closed D28392: [ResultIterator] Remove unneeded SearchStore forward declaration.
Mar 30 2020, 9:08 PM · Baloo, Frameworks
ngraham accepted D28396: [MTimeDB] Consolidate time interval handling code.
Mar 30 2020, 3:14 PM · Baloo, Frameworks
ngraham accepted D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly.
Mar 30 2020, 3:13 PM · Baloo, Frameworks
ngraham accepted D28393: [Term] Provide toString(Term) overload for QTest.
Mar 30 2020, 3:12 PM · Baloo, Frameworks
ngraham accepted D28392: [ResultIterator] Remove unneeded SearchStore forward declaration.
Mar 30 2020, 3:12 PM · Baloo, Frameworks
bruns closed D28387: [QueryTest] Make phrase test case data driven and extend.
Mar 30 2020, 8:52 AM · Baloo, Frameworks
bruns closed D28384: [Extractor] Delay mimetype check, cleanup debug output.
Mar 30 2020, 8:51 AM · Baloo, Frameworks
ngraham accepted D28387: [QueryTest] Make phrase test case data driven and extend.
Mar 30 2020, 12:07 AM · Baloo, Frameworks
ngraham accepted D28384: [Extractor] Delay mimetype check, cleanup debug output.

Good catch!

Mar 30 2020, 12:05 AM · Baloo, Frameworks

Mar 29 2020

bruns added a dependent revision for D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore: D28401: [SearchStore] Handle double values in property queries.
Mar 29 2020, 11:14 AM · Baloo, Frameworks
bruns requested review of D28401: [SearchStore] Handle double values in property queries.
Mar 29 2020, 11:14 AM · Baloo, Frameworks
bruns requested review of D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore.
Mar 29 2020, 11:13 AM · Baloo, Frameworks
bruns updated the diff for D28396: [MTimeDB] Consolidate time interval handling code.

.

Mar 29 2020, 11:12 AM · Baloo, Frameworks
bruns requested review of D28396: [MTimeDB] Consolidate time interval handling code.
Mar 29 2020, 4:18 AM · Baloo, Frameworks
bruns requested review of D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly.
Mar 29 2020, 1:10 AM · Baloo, Frameworks
bruns requested review of D28393: [Term] Provide toString(Term) overload for QTest.
Mar 29 2020, 1:10 AM · Baloo, Frameworks
bruns requested review of D28392: [ResultIterator] Remove unneeded SearchStore forward declaration.
Mar 29 2020, 1:09 AM · Baloo, Frameworks

Mar 28 2020

bruns requested review of D28387: [QueryTest] Make phrase test case data driven and extend.
Mar 28 2020, 8:38 PM · Baloo, Frameworks
bruns requested review of D28384: [Extractor] Delay mimetype check, cleanup debug output.
Mar 28 2020, 5:41 PM · Baloo, Frameworks

Mar 27 2020

bruns added inline comments to D28324: [Inotify] Remove dead/duplicate code.
Mar 27 2020, 6:02 PM · Baloo, Frameworks
pino added inline comments to D28324: [Inotify] Remove dead/duplicate code.
Mar 27 2020, 5:35 PM · Baloo, Frameworks
bruns added inline comments to D28324: [Inotify] Remove dead/duplicate code.
Mar 27 2020, 5:26 PM · Baloo, Frameworks
bruns closed D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch.
Mar 27 2020, 4:55 PM · Baloo, Frameworks
bruns closed D28352: [BasicIndexingJob] Remove unused include.
Mar 27 2020, 4:38 PM · Baloo, Frameworks
bruns closed D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed.
Mar 27 2020, 4:35 PM · Baloo, Frameworks
First
Prev
Next