Differential D28738

Use KFileItem::recursiveSize to Display recursize size as total size
ClosedPublic
Actions

Authored by meven on Apr 11 2020, 6:25 AM.

Details

Reviewers
ngraham
elvisangelaccio
dfaure
Group Reviewers
Dolphin
Commits
R824:50fdd3e154ff: Use KFileItem::recursiveSize to Display recursize size as total size
Summary

This allows to display the trash:/ occupied space

CCBUG: 413091

Test Plan

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Apr 11 2020, 6:25 AM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 11 2020, 6:25 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
meven requested review of this revision.Apr 11 2020, 6:25 AM
meven edited the test plan for this revision. (Show Details)Apr 11 2020, 6:27 AM
meven added a dependency: D24773: kio_trash: Add size, modification, access and create date for trash:/.
meven edited the summary of this revision. (Show Details)
meven updated this revision to Diff 79806.Apr 11 2020, 6:31 AM

When KIO::UDSEntry::UDS_RECURSIVE_SIZE is provided consider the size known

meven edited the test plan for this revision. (Show Details)Apr 11 2020, 6:33 AM
dfaure accepted this revision.Apr 11 2020, 9:10 AM
This revision is now accepted and ready to land.Apr 11 2020, 9:10 AM
elvisangelaccio requested changes to this revision.Apr 12 2020, 10:32 AM
elvisangelaccio added inline comments.
src/filemetadataprovider.cpp
178

Please bump the minimum required KF5 version to whatever is the KIO version where we introduced UDS_RECURSIVE_SIZE.

This revision now requires changes to proceed.Apr 12 2020, 10:32 AM
meven updated this revision to Diff 79923.Apr 12 2020, 12:03 PM

Bump KF5_MIN_VERSION

meven marked an inline comment as done.Apr 12 2020, 12:03 PM
elvisangelaccio accepted this revision.Apr 13 2020, 5:46 PM
This revision is now accepted and ready to land.Apr 13 2020, 5:46 PM
ngraham accepted this revision.Apr 13 2020, 6:39 PM
Closed by commit R824:50fdd3e154ff: Use KFileItem::recursiveSize to Display recursize size as total size (authored by meven). · Explain WhyApr 14 2020, 5:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/filemetadataprovider.cpp (7 lines)

Diff 80062

View Options

CMakeLists.txt

Loading...
View Options

src/filemetadataprovider.cpp

Loading...