Differential D28501

[SearchStore] Use categorized logging
ClosedPublic
Actions

Authored by bruns on Apr 2 2020, 8:53 AM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:6a0be3910727: [SearchStore] Use categorized logging
Test Plan

no functional changes

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 2 2020, 8:53 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 2 2020, 8:53 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 2 2020, 8:53 AM
apol added a subscriber: apol.Apr 2 2020, 9:57 AM
apol added inline comments.
src/lib/searchstore.cpp
233–234

This change is not related to what the commit message describes.

bruns marked an inline comment as done.Apr 2 2020, 10:10 AM
bruns added inline comments.
src/lib/searchstore.cpp
233–234

Its hardly more than reformatting.

bruns marked an inline comment as done.Apr 2 2020, 10:11 AM
ngraham added inline comments.Apr 2 2020, 4:50 PM
src/lib/searchstore.cpp
233–234

But the commit message is about categorized logging, not reformatting. Just do the reformatting in a separate commit, no need for review I'd say

ngraham accepted this revision.Apr 3 2020, 12:34 AM
This revision is now accepted and ready to land.Apr 3 2020, 12:34 AM
Closed by commit R293:6a0be3910727: [SearchStore] Use categorized logging (authored by bruns). · Explain WhyApr 3 2020, 3:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/searchstore.cpp (6 lines)

Diff 79186

View Options

src/lib/searchstore.cpp

Loading...