Differential D28506

[QueryParser] Fix broken detection of end quote
ClosedPublic
Actions

Authored by bruns on Apr 2 2020, 9:22 AM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:6be616f64b13: [QueryParser] Fix broken detection of end quote
Summary

In case the a closing quote was not followed by any term, but only
whitespace, punctuation or other ignored characters (or any mixture
thereof), the quote would not be detected.

Test Plan

ctest -R queryparser

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 2 2020, 9:22 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 2 2020, 9:22 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 2 2020, 9:22 AM
ngraham accepted this revision.Apr 2 2020, 4:58 PM

Whoops!

This revision is now accepted and ready to land.Apr 2 2020, 4:58 PM
Closed by commit R293:6be616f64b13: [QueryParser] Fix broken detection of end quote (authored by bruns). · Explain WhyApr 2 2020, 7:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79171

View Options

autotests/unit/engine/queryparsertest.cpp

Loading...
View Options

src/engine/queryparser.cpp

Loading...