Observed this on the openSUSE OBS as well. Please fix the compilation issue or revert.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Apr 28 2018
Apr 28 2018
lbeltrame added a reverting change for R108:8a2a00a4ca80: Add "SkipSwitcher" to API: R108:5ef119044df1: Revert "Add "SkipSwitcher" to API".
Apr 24 2018
Apr 24 2018
The security review by the SUSE security team of an analogous change in ktexteditor highlighted some problems there. @chinmoyr, you may want to look the review up for reference:
Add TouristAttractionVisit
Apr 21 2018
Apr 21 2018
Apr 20 2018
Apr 20 2018
Apr 19 2018
Apr 19 2018
Apr 14 2018
Apr 14 2018
lbeltrame committed R1003:a790ebb94ca5: Make LodgingBusiness and FoodEstablishment inherit from Organization instead of… (authored by lbeltrame).
Make LodgingBusiness and FoodEstablishment inherit from Organization instead of…
Apr 13 2018
Apr 13 2018
Apr 12 2018
Apr 12 2018
Apr 11 2018
Apr 11 2018
+1, but someone else must approve.
Apr 9 2018
Apr 9 2018
Remove swear words from debug
Apr 6 2018
Apr 6 2018
Add more datatypes
Apr 5 2018
Apr 5 2018
lbeltrame committed R1003:a87c1b1e2537: Wire up Organization in other data types (authored by lbeltrame).
Wire up Organization in other data types
Apr 4 2018
Apr 4 2018
- Reorder includes
- Wire up also BusTrip (with added test)
Add support for Organization
lbeltrame retitled D11910: Add support for Organization from [WIP] Add support for Organization to Add support for Organization.
- Allow Organization to be serialized/deserialized
- Add myself to copyrights
- Test setting and reading Organization properties
- Add Organization header generation
- Very basic autotest
Apr 3 2018
Apr 3 2018
Mar 27 2018
Mar 27 2018
lbeltrame committed R290:f053a4e0ffc3: Use NO_DEFAULT_PATH to ensure the right command is picked up (authored by lbeltrame).
Use NO_DEFAULT_PATH to ensure the right command is picked up
lbeltrame committed R290:facb94b5f63b: Look also for prefixed rcc executables (authored by lbeltrame).
Look also for prefixed rcc executables
Mar 22 2018
Mar 22 2018
Mar 14 2018
Mar 14 2018
lbeltrame committed R264:642fd8a06fca: Remove shebangs from non-executable files (authored by lbeltrame).
Remove shebangs from non-executable files
lbeltrame committed R264:27a1126b1d79: Look first for qhelpgenerator-qt5 for help generation (authored by lbeltrame).
Look first for qhelpgenerator-qt5 for help generation
lbeltrame committed R281:d3c573483257: cmake: don't flag libnm-util as found when ModemManager is found (authored by aleksanderm).
cmake: don't flag libnm-util as found when ModemManager is found
Mar 8 2018
Mar 8 2018
@bcooksley All the deps are available in the distro so yes, it's just a matter of adding them to the image.
Mar 6 2018
Mar 6 2018
Fix build with Qt 5.11
Fix build with Qt 5.11
Fix build with Qt 5.11
Fix build with Qt 5.11
Mar 5 2018
Mar 5 2018
lbeltrame added reviewers for D11061: Migration request from IBusConfig to GSettings : Plasma, hein.
Feb 27 2018
Feb 27 2018
Feb 23 2018
Feb 23 2018
lbeltrame added a comment to D10764: [AppletQuickItem] Preload applet expander only if not already expanded.
+1 from me, fixes the issue I had.
Feb 22 2018
Feb 22 2018
For what it's worth, LGTM .
Looks OK to me with some changes (for readability).
Feb 21 2018
Feb 21 2018
When someone has enough time and will to work on it, which may be from tomorrow to the next 3 years. It can't be quantified at the moment.
Feb 11 2018
Feb 11 2018
lbeltrame committed R119:84399af5f17b: Partially undo 0c4ed31589c809aeb9f74a09fbcae0de886b5566 (authored by lbeltrame).
Partially undo 0c4ed31589c809aeb9f74a09fbcae0de886b5566
lbeltrame added a reverting change for R119:0c4ed31589c8: Use override keyword: R119:84399af5f17b: Partially undo 0c4ed31589c809aeb9f74a09fbcae0de886b5566.
Feb 7 2018
Feb 7 2018
Restricted Application edited projects for D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed, added: Plasma; removed Plasma on Wayland.
Ping? Why this has not been committed even if in "accepted" state?
Feb 5 2018
Feb 5 2018
lbeltrame committed R78:fd32bed7bf76: Merge remote-tracking branch 'origin/Applications/17.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.12'
Jan 31 2018
Jan 31 2018
lbeltrame committed R120:0c6078a7889f: Add ECMMarkAsTest to dataengines/notifications (authored by lbeltrame).
Add ECMMarkAsTest to dataengines/notifications
Jan 27 2018
Jan 27 2018
Jan 23 2018
Jan 23 2018
lbeltrame added a reviewer for D9983: Don't stat(/etc/localtime) between read() and write() copying files: dfaure.
Jan 22 2018
Jan 22 2018
lbeltrame committed R105:ea7f39701c72: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.12'
Jan 21 2018
Jan 21 2018
lbeltrame committed R105:7a1ebd5dc8b2: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.12'
Jan 20 2018
Jan 20 2018
LGTM.
Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone objects, then you can land this.
lbeltrame added a reviewer for D9333: Make sure that old URLs do not appear duplicated in places model: Dolphin.
+1, but someone else must approve.
Jan 19 2018
Jan 19 2018
I reverted this change in master: this doesn't solve all the problems (places aren't keeping edits now) but at least solves the crash, which is far more critical.
lbeltrame committed R318:d55b0875ffac: Revert "Ignore baloo urls created from new KIO model" (authored by lbeltrame).
Revert "Ignore baloo urls created from new KIO model"
Well, I didn't expect that master and Applications had differing behaviors... Anyway, is there a short-term solution short of undoing the merge (which is hard to do)?
Jan 18 2018
Jan 18 2018
In D9958#192860, @michaelh wrote:
+1. @broulik How does it look on your side wrt the QJsonDocument usage?
I'm not too fond of assembling JSON by hand, but I guess it was done to avoid dependencies for a tool that's supposed to be simple. I'll let others weigh in on this.
Did you test this change also with filenames with Unicode characters or non-Latin characters?
Examples of each output would be nice.
lbeltrame committed R318:1a6b3c0a2bab: Merge remote-tracking branch 'origin/Applications/17.12' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Applications/17.12'
Jan 16 2018
Jan 16 2018
Jan 12 2018
Jan 12 2018
Fixup previous commit
lbeltrame committed R241:029da62886e0: Do not cache root password for the whole session (authored by lbeltrame).
Do not cache root password for the whole session
Jan 9 2018
Jan 9 2018
lbeltrame committed R733:6e1efd4d524b: Fixup new style invokeMethod() and fix email sending (authored by lbeltrame).
Fixup new style invokeMethod() and fix email sending
lbeltrame committed R733:3a07df62299a: Revert "Revert "Use new connect api"" (authored by lbeltrame).
Revert "Revert "Use new connect api""
lbeltrame added a reverting change for R733:96e83e94eaa2: Revert "Use new connect api": R733:3a07df62299a: Revert "Revert "Use new connect api"".
Revert "Use new connect api"
lbeltrame added a reverting change for R733:72c073488ec1: Use new connect api: R733:7e6e7e0d6e71: Revert "Use new connect api".
Revert "Use new connect api"
lbeltrame added a reverting change for R733:94b979956b90: Use new connect api: R733:96e83e94eaa2: Revert "Use new connect api".
Dec 24 2017
Dec 24 2017
Restricted Application edited projects for D9495: Properly detect Gallium drivers with newer Mesa, added: KWin; removed Plasma.
I consider detecting for newer driver a feature.
Dec 22 2017
Dec 22 2017
lbeltrame committed R120:5398c98ffd88: Merge remote-tracking branch 'origin/Plasma/5.11' (authored by lbeltrame).
Merge remote-tracking branch 'origin/Plasma/5.11'
Dec 21 2017
Dec 21 2017
For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html.