Differential D9989

baloo-tools: Make all output messages translatable
ClosedPublic
Actions

Authored by michaelh on Jan 20 2018, 10:28 AM.

Details

Reviewers
smithjd
vhanda
lueck
lbeltrame
Group Reviewers
Frameworks
Commits
R293:125029d79153: baloo-tools: Make all output messages translatable

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh requested review of this revision.Jan 20 2018, 10:28 AM
michaelh created this revision.
michaelh added a reviewer: lueck.
michaelh added inline comments.Jan 20 2018, 10:31 AM
src/tools/balooctl/monitorcommand.cpp
66

Context needed?

lueck added inline comments.Jan 20 2018, 11:41 AM
src/tools/balooctl/monitorcommand.cpp
66

yes, please add context about the meaning of %1

michaelh updated this revision to Diff 25687.Jan 20 2018, 2:15 PM

added i18n context

lueck added a comment.Jan 20 2018, 3:15 PM
In D9989#193705, @michaelh wrote:

added i18n context

OK from i18n pov, thanks

michaelh marked 2 inline comments as done.Jan 20 2018, 6:51 PM
michaelh added a comment.Jan 25 2018, 10:25 PM

If no one objects, I'm going to land this on Saturday.

michaelh retitled this revision from tools: Make all output messages translatable to baloo-tools: Make all output messages translatable .Jan 25 2018, 10:38 PM
lbeltrame accepted this revision.Jan 27 2018, 8:12 AM
This revision is now accepted and ready to land.Jan 27 2018, 8:12 AM
Closed by commit R293:125029d79153: baloo-tools: Make all output messages translatable (authored by michaelh). · Explain WhyJan 27 2018, 8:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26027

View Options

src/tools/balooctl/monitorcommand.cpp

Loading...
View Options

src/tools/baloosearch/main.cpp

Loading...
View Options

src/tools/balooshow/main.cpp

Loading...