Make it possible to disable the build of okularkirigami
ClosedPublic
Actions

Authored by apol on Apr 19 2018, 2:38 PM.

Details

Reviewers

Group Reviewers

Okular

Commits

Summary

Some distros seem to have the option.

BUG: 393119

Test Plan

Still builds, can disable build

Repository

R223 Okular

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol requested review of this revision.Apr 19 2018, 2:38 PM

CMakeLists.txt
127–130	Doesn't specify much about what a "convergent" application is (unless it's specified elsewhere). Perhaps "Builds a Kirigami-based, convergent version of Okular"?

Improve description

mobile/app/package/contents/ui/Documents.qml
56–66	This, and all the changes in Document.qml are unrelated.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2018, 8:23 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (5 lines)
M			mobile/app/package/contents/ui/Documents.qml (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32569	77049d3		Apr 19 2018, 2:38 PM	★	★
Diff 2	32616	77049d3	Improve description	Apr 19 2018, 11:00 PM	★	★
Diff 3	32842	33a2eaf	R223:1fb77446a7378368de5288ca9f57627ae2946d84	Apr 22 2018, 8:23 PM	★	★