27c0245b1715044cf4d401f1c9d7e7a915a4f3c5 ("[resources] Nicely quit threads")
has no effect as the threads are not running an event loop.
Instead use the QThread::requestInterruption() mechanism.
BUG: 385533
Details
Details
- Reviewers
ivan anthonyfieroni - Group Reviewers
Plasma - Commits
- R161:ed092b96f7af: Actually quit threads nicely
kactivitymanagerd left a coredump on each logout if kate was opened
before logging out. Now it doesn't do that anymore.
Diff Detail
Diff Detail
- Repository
- R161 KActivity Manager Service
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
That's what a QThread is:
A QThread object manages one thread of control within the program. QThreads begin executing in run(). By default, run() starts the event loop by calling exec() and runs a Qt event loop inside the thread.
| src/service/Resources.cpp | ||
|---|---|---|
| 60 | It's the // initial delay before processing the events plus some time for it to process the last request. I can add a comment if you want to. | |
| src/service/Resources.cpp | ||
|---|---|---|
| 60 | A comment would do (so that it is less "magic"). | |
| src/service/plugins/sqlite/ResourceScoreMaintainer.cpp | ||
|---|---|---|
| 62 | If that is enough, then why not just wait()? | |
| src/service/plugins/sqlite/ResourceScoreMaintainer.cpp | ||
|---|---|---|
| 62 | Simple: wait() waits for an infinite amount of time if run() never returns. If that happens (run() is stuck), we prefer a crash over silently wasting resources. | |