Differential D9985

Fix place item edit after creation
ClosedPublic
Actions

Authored by renatoo on Jan 19 2018, 4:40 PM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Commits
R318:a8a3fa51a064: Fix place item edit after creation
Summary

Make sure that the place can be edited after the creation.

Depends on D9333

BUG: 389147

Test Plan

Create an item in dolphin places panel, make sure that you
can rename it

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
renatoo created this revision.Jan 19 2018, 4:40 PM
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptJan 19 2018, 4:40 PM
renatoo requested review of this revision.Jan 19 2018, 4:40 PM
renatoo updated this revision to Diff 25648.Jan 19 2018, 4:42 PM

Rever unrelated changes

ngraham added inline comments.Jan 19 2018, 5:18 PM
src/panels/places/placesitem.cpp
132

Cahnged -> Changed

137

Cahnged -> Changed

renatoo updated this revision to Diff 25650.Jan 19 2018, 5:21 PM

Fixed typo

lbeltrame added a subscriber: lbeltrame.Jan 20 2018, 8:07 AM

+1, but someone else must approve.

ngraham added a comment.EditedJan 20 2018, 3:28 PM

Works fine on master, thanks. And thanks for the new test, too.

However, this is marked as depending on D9333, which depends on D9332, which is for KIO. We can't land this for Applications/17.12 because of the required KIO change. It would still be great to get something for our users on 17.12.

ngraham accepted this revision as: ngraham.Jan 20 2018, 4:15 PM
This revision is now accepted and ready to land.Jan 20 2018, 4:15 PM
elvisangelaccio added a subscriber: elvisangelaccio.Jan 20 2018, 5:25 PM
elvisangelaccio added inline comments.
src/panels/places/placesitem.cpp
132

Why not bookmark != m_bookmark ?

134

Typo: "must be updated"

elvisangelaccio edited the summary of this revision. (Show Details)Jan 20 2018, 5:40 PM
michaelh added a subscriber: michaelh.Jan 20 2018, 7:04 PM
michaelh added inline comments.
src/tests/placesitemmodeltest.cpp
846

This warning will be more helpful when you make clear who is the emitter.

renatoo updated this revision to Diff 25715.Jan 21 2018, 2:06 PM
renatoo marked 5 inline comments as done.

Fixed typo

Closed by commit R318:a8a3fa51a064: Fix place item edit after creation (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyJan 26 2018, 2:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25990

View Options

src/panels/places/placesitem.cpp

Loading...
View Options

src/panels/places/placesitemmodel.cpp

Loading...
View Options

src/tests/placesitemmodeltest.cpp

Loading...