Wire up Organization in other data types
ClosedPublic
Actions

Authored by lbeltrame on Apr 4 2018, 9:41 PM.

Details

Reviewers

vkrause

Commits

R1003:a87c1b1e2537: Wire up Organization in other data types

Summary

Use the newly-made class as provider in Reservation, Flight,
TrainTrip and BusTrip

Test Plan

Added unit test, passed

Repository

R1003 KItinerary: Travel Reservation handling library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

lbeltrame requested review of this revision.Apr 4 2018, 9:41 PM

vkrause added inline comments.

src/datatypes/flight.h
61	Uh, so schema.org unified "airline" to "provider" here too. The test data I have still uses "airline", so I never noticed... This means we will eventually need to move this in a yet to be created normalization/migration stage in post-processing and we need to inherit Airline from Organization. Anyway, that's way beyond the scope of this patch :)

This revision is now accepted and ready to land.Apr 5 2018, 7:21 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/datatypestest.cpp (13 lines)
M			src/datatypes/bustrip.h (3 lines)
M			src/datatypes/bustrip.cpp (3 lines)
M			src/datatypes/flight.h (3 lines)
M			src/datatypes/flight.cpp (3 lines)
M			src/datatypes/reservation.h (3 lines)
M			src/datatypes/reservation.cpp (3 lines)
M			src/datatypes/traintrip.h (3 lines)
M			src/datatypes/traintrip.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31333	f673706		Apr 4 2018, 9:41 PM	★	★
Diff 2	31334	f673706	- Reorder includes	Apr 4 2018, 9:44 PM	★	★
Diff 3	31362	f673706	R1003:a87c1b1e253725dd809cc7c70fdc1eb57fbef0d5	Apr 5 2018, 7:32 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1e58e9823afb	254042de305e	dec9bca21fca	Luca Beltrame	Wire up also BusTrip (with added test)	Apr 4 2018, 9:44 PM
dec9bca21fca	6f98ca975e9e	efeae024e2c5	Luca Beltrame	Reorder includes	Apr 4 2018, 9:42 PM
efeae024e2c5	c08ef9d61ccc	f67370620d61	Luca Beltrame	Wire up Organization in other data types (Show More…)	Apr 4 2018, 9:40 PM