Feed Advanced Search

Sun, May 5

abika added a comment to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks Nikita! Changes applied and pushed into maste.

Sun, May 5, 7:24 PM · Krusader
Diffusion closed D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
Sun, May 5, 7:23 PM · Krusader
abika updated the diff for D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
  • fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
Sun, May 5, 7:18 PM · Krusader

Sat, Apr 27

nmel accepted D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.

Sat, Apr 27, 3:47 AM · Krusader

Mon, Apr 22

abika added a project to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime): Krusader.
Mon, Apr 22, 3:58 PM · Krusader

Apr 15 2019

nmel added a comment to D20373: Updated minimal Qt version to the earliest supported version (5.9).

Thank you, Yuri and Alex!

Apr 15 2019, 6:51 AM · Krusader
nmel closed D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 15 2019, 6:49 AM · Krusader

Apr 13 2019

abika accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).

After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.

Apr 13 2019, 4:40 PM · Krusader

Apr 10 2019

yurchor accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 10 2019, 7:21 AM · Krusader
nmel added reviewers for D20373: Updated minimal Qt version to the earliest supported version (5.9): mchabrecek, abika, yurchor.
Apr 10 2019, 6:49 AM · Krusader

Apr 8 2019

nmel added a project to D20373: Updated minimal Qt version to the earliest supported version (5.9): Krusader.

QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.

Apr 8 2019, 7:59 AM · Krusader

Mar 8 2019

Diffusion closed D19277: Create new text files with umask applied.
Mar 8 2019, 8:21 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

Thanks! Landed (Hope this revision will close itself).

Mar 8 2019, 7:45 PM · Krusader

Mar 7 2019

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Mar 7 2019, 6:54 AM · Krusader

Mar 4 2019

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mar 4 2019, 7:44 AM · Krusader

Mar 3 2019

abika updated the summary of D19277: Create new text files with umask applied.
Mar 3 2019, 7:16 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

Mar 3 2019, 7:07 PM · Krusader
abika updated the diff for D19277: Create new text files with umask applied.
  • SQUASH_ME Panel: Create new local text files directly with QFile
Mar 3 2019, 7:05 PM · Krusader

Feb 25 2019

nmel added a comment to D19277: Create new text files with umask applied.

Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.

Feb 25 2019, 6:49 AM · Krusader
nmel closed D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Feb 25 2019, 6:32 AM · Krusader

Feb 24 2019

abika added a comment to D19104: Search: Improve right-click context menu.

Thanks for the reviews!

Feb 24 2019, 5:08 PM · Krusader
Diffusion closed D19104: Search: Improve right-click context menu.
Feb 24 2019, 5:07 PM · Krusader
abika accepted D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks. Working fine.

Feb 24 2019, 4:17 PM · Krusader
abika added a project to D19277: Create new text files with umask applied: Krusader.
Feb 24 2019, 4:02 PM · Krusader

Feb 18 2019

nmel added reviewers for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert: abika, asensi, mchabrecek.
Feb 18 2019, 7:53 AM · Krusader
nmel accepted D19104: Search: Improve right-click context menu.

Nice fix and improvement. Thanks!

Feb 18 2019, 7:50 AM · Krusader
nmel updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
  • fixed build and formatting
Feb 18 2019, 7:13 AM · Krusader
nmel commandeered D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Due to no response from Davide, I'm taking over. I also see lots of deprecation warnings and would like to fix it. The most recent revision doesn't compile, however. I have a fix and will update shortly.

Feb 18 2019, 7:11 AM · Krusader

Feb 17 2019

yurchor added a comment to D19104: Search: Improve right-click context menu.

+1
Compiles, installs and works as expected.

Feb 17 2019, 8:31 PM · Krusader
abika added a project to D19104: Search: Improve right-click context menu: Krusader.
Feb 17 2019, 8:03 PM · Krusader

Nov 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Kindly ping.

Nov 9 2018, 9:16 AM · Krusader

Nov 6 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello All,

Nov 6 2018, 8:07 AM · Krusader

Oct 27 2018

nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Kindly ping.

Oct 27 2018, 7:52 AM · Krusader

Oct 26 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello Guys,

Oct 26 2018, 10:00 AM · Krusader

Oct 21 2018

mchabrecek closed D16223: Replaced old connect() with QT5 style. Part 1.
Oct 21 2018, 9:46 PM · Krusader

Oct 20 2018

yurchor added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Oct 20 2018, 7:21 PM · Krusader

Oct 19 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#345641, @nmel wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

Oct 19 2018, 12:37 PM · Krusader
nmel added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Oct 19 2018, 6:30 AM · Krusader

Oct 17 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#344206, @nmel wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

Oct 17 2018, 7:56 AM · Krusader

Oct 16 2018

nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

Oct 16 2018, 3:36 PM · Krusader
mchabrecek updated the diff for D16223: Replaced old connect() with QT5 style. Part 1.
  • Fixed spacing
Oct 16 2018, 10:26 AM · Krusader
shubham added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

You have to make the changes requested by Nikita.

Oct 16 2018, 10:07 AM · Krusader
mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Oct 16 2018, 9:00 AM · Krusader
nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Thanks and welcome aboard Miroslav!

Oct 16 2018, 7:21 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Looks much better, thanks!

Oct 16 2018, 6:27 AM · Krusader

Oct 15 2018

abika added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 15 2018, 7:04 PM · Krusader
abika accepted D16223: Replaced old connect() with QT5 style. Part 1.

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Oct 15 2018, 6:43 PM · Krusader
abika added a project to D16223: Replaced old connect() with QT5 style. Part 1: Krusader.
Oct 15 2018, 6:28 PM · Krusader
mchabrecek added a comment to T2966: Code Cleaning.

I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.

Oct 15 2018, 1:43 PM · Krusader

Oct 11 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

I thought I had already committed that... changed to a more human macro name

Oct 11 2018, 8:20 PM · Krusader

Oct 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Thank you for help,

Oct 9 2018, 9:35 AM · Krusader

Oct 7 2018

asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Maybe a visual hint would be good so that the users know this feature exists.

Oct 7 2018, 5:26 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 5:01 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 7 2018, 4:43 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 4:08 PM · Krusader

Oct 6 2018

abika added a comment to T2966: Code Cleaning.

Hi Miro,

Oct 6 2018, 3:28 PM · Krusader
mchabrecek placed T2966: Code Cleaning up for grabs.

Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.

Oct 6 2018, 8:20 AM · Krusader

Oct 4 2018

abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Oct 4 2018, 7:22 PM · Krusader

Oct 2 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Oct 2 2018, 5:13 PM · Krusader
mchabrecek added a member for Krusader: mchabrecek.
Oct 2 2018, 4:25 PM

Sep 28 2018

asensi closed D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 28 2018, 6:38 AM · Krusader

Sep 23 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Another address was updated

Sep 23 2018, 6:55 AM · Krusader

Sep 22 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

An address was updated

Sep 22 2018, 6:11 PM · Krusader
asensi requested review of D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sep 22 2018, 4:22 PM · Krusader
asensi updated the diff for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks, Nikita, those lines will be added to the commit message:

FIXED: Memory leak in the Locate dialog
Differential Revision: https://phabricator.kde.org/D15678
Sep 22 2018, 3:57 PM · Krusader
asensi added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:57 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:03 AM · Krusader
gengisdave closed D15400: Fix compile warnings on missing override declarations.
Sep 22 2018, 8:54 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! This looks less cluttered.

Sep 22 2018, 5:31 AM · Krusader
nmel accepted D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks Toni!

Sep 22 2018, 5:18 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

every user is a tester too.

More importantly, whenever we make a change after this is merged, we will see the warning and fix the code. We put an effort before v2.7 release to make Krusader warning-free and we should keep it this way. So now the -Wsuggest-override is on the list of warning directives that we track. Thanks Davide (and Toni ;) )!

Sep 22 2018, 5:04 AM · Krusader

Sep 21 2018

asensi updated the test plan for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:35 PM · Krusader
asensi requested review of D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:28 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

The new version works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide! (and Nikita :-) )

Sep 21 2018, 1:17 PM · Krusader

Sep 19 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Changed in favor of a macro solution (as suggested by Nikita).

Sep 19 2018, 2:15 PM · Krusader
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

What do you think about creating a specialized version of UDSEntry, e.g. KrUDSEntry? This way the code:

Sep 19 2018, 12:15 PM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.

Added flag for GCC as default

Sep 19 2018, 11:59 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.

Sep 19 2018, 11:42 AM · Krusader

Sep 15 2018

nmel added a comment to D15400: Fix compile warnings on missing override declarations.

Why not to update the flags for both debug and release (CMAKE_CXX_FLAGS var)? What's your reasoning? Does it hurt the release build?

Sep 15 2018, 5:17 AM · Krusader

Sep 14 2018

gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:

Sep 14 2018, 8:25 AM · Krusader

Sep 13 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! (and Nikita :-) )

Sep 13 2018, 6:14 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

It's nice to hear from you again, Davide!

Sep 13 2018, 4:34 PM · Krusader
nmel accepted D15400: Fix compile warnings on missing override declarations.

Indeed, all warnings of this type are fixed. Thanks Davide!

Sep 13 2018, 6:07 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Where to put the macro? The three files don't have a common header file and I haven't found a suitable .h file; any advice?

Sep 13 2018, 5:48 AM · Krusader

Sep 12 2018

gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

The use of a Macro was my second way to solve this, but I thought it would add more complexity to the code; instead, this patch makes the code unclear to read.

Sep 12 2018, 8:51 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I updated the diff to v2 to fix spaces as requested.

Sep 12 2018, 8:40 AM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.
Sep 12 2018, 8:31 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

and reproducible adding -Wsuggest-override or -Winconsistent-missing-override (not sure, haven't tested with clang) to CMAKE_CXX_FLAGS

Should we add this into cmake config file to ensure that these flags are always on?

Sep 12 2018, 6:29 AM · Krusader
nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

inline

Sep 12 2018, 6:21 AM · Krusader

Sep 10 2018

gengisdave requested review of D15400: Fix compile warnings on missing override declarations.
Sep 10 2018, 10:24 AM · Krusader

Sep 9 2018

gengisdave requested review of D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Sep 9 2018, 2:34 PM · Krusader

Sep 4 2018

lydia added a comment to T9581: Publish Krusader in the Microsoft Store.
In T9581#158530, @abika wrote:

My concern now is this: If you put effort in creating a Windows package for Krusader and there will be bugs (I bet there will), there should be someone working on it. Unfortunately we already don't have enough developer time to solve the >100 open bugs currently open for Krusader. And support for Windows will come on top of that. I would like to avoid a half working Windows version which will never be "stable" and that the effort will be for nothing.

Sep 4 2018, 5:14 PM · Krusader, Windows
kfunk added a comment to T9581: Publish Krusader in the Microsoft Store.

Regarding background: You might want to read the blog posts here: http://kfunk.org/tag/kde-windows/ -- specifically: http://kfunk.org/2016/06/18/kde-on-windows-update/

Sep 4 2018, 8:36 AM · Krusader, Windows

Sep 3 2018

abika added a comment to T9581: Publish Krusader in the Microsoft Store.

Hi Lydia and everyone else,

Sep 3 2018, 7:20 PM · Krusader, Windows
asensi added a comment to T9581: Publish Krusader in the Microsoft Store.

Thank you very much for all, Lydia, although as far as Krusader developers know, there is no Windows version of Krusader (contributions are very welcome :-)).

Sep 3 2018, 4:49 PM · Krusader, Windows

Sep 2 2018

lydia created T9581: Publish Krusader in the Microsoft Store.
Sep 2 2018, 1:50 PM · Krusader, Windows

Aug 23 2018

nmel edited the content of Release Howto.
Aug 23 2018, 5:40 AM · Krusader

Aug 17 2018

gregorp removed a watcher for Krusader: gregorp.
Aug 17 2018, 9:39 AM
gregorp added a watcher for Krusader: gregorp.
Aug 17 2018, 9:39 AM

Aug 16 2018

nmel edited the content of Release Howto.
Aug 16 2018, 7:55 AM · Krusader