Feed Advanced Search

Sat, May 23

gengisdave closed D29430: Execute .desktop file.

Move to : https://invent.kde.org/utilities/krusader/-/merge_requests/6

Sat, May 23, 12:29 PM · Krusader
gengisdave closed D29500: Close viewer tabs with middle click.

Moved to : https://invent.kde.org/utilities/krusader/-/merge_requests/5

Sat, May 23, 12:19 PM · Krusader

Fri, May 15

asensi added a comment to D24987: Add Kompare as compare application with KIO support.

Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.

Fri, May 15, 11:56 PM · Krusader
asensi added a comment to D26280: Move 'connect' call before openUrl.

Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.

Fri, May 15, 11:56 PM · Krusader
asensi closed D24987: Add Kompare as compare application with KIO support.
Fri, May 15, 11:51 PM · Krusader
asensi closed D26280: Move 'connect' call before openUrl.
Fri, May 15, 11:51 PM · Krusader
gengisdave accepted D24987: Add Kompare as compare application with KIO support.

+1

Fri, May 15, 7:38 AM · Krusader
gengisdave added a comment to D26280: Move 'connect' call before openUrl.

+1

Fri, May 15, 7:35 AM · Krusader
asensi added a comment to D24987: Add Kompare as compare application with KIO support.

Dear developers,

Fri, May 15, 6:37 AM · Krusader
asensi added a comment to D26280: Move 'connect' call before openUrl.

Dear developers,

Fri, May 15, 6:35 AM · Krusader
asensi closed T13133: Konfigurator: Improve management of tooltips and “What's This” help as Resolved.
Fri, May 15, 12:02 AM · Krusader

Thu, May 14

asensi closed D29696: Update copyright years.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29611: Add krusader-news mailing list to docs.
Thu, May 14, 11:55 PM · Documentation, Krusader
asensi closed D29609: Several minor changes aimed to make comments and code clearer, following the norms.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Thu, May 14, 11:55 PM · Krusader
asensi closed D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Thu, May 14, 11:55 PM · Krusader
asensi added a comment to D29696: Update copyright years.

Thank you, Davide and Yuri!

Thu, May 14, 11:51 PM · Krusader
asensi updated the diff for D13904: Adapt and improve the debug logging system.

Adapted the proposal to the current code base, with minor improvements.

Thu, May 14, 10:53 PM · Krusader
gengisdave accepted D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`.

Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createURLRequester()

Thu, May 14, 8:43 PM · Krusader
gengisdave accepted D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`.

Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createFontChooser()

Thu, May 14, 8:43 PM · Krusader
gengisdave accepted D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`.

Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createEditBox()

Thu, May 14, 8:43 PM · Krusader
gengisdave accepted D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`.

Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createComboBox()

Thu, May 14, 8:42 PM · Krusader
gengisdave accepted D29696: Update copyright years.

Thanks

Thu, May 14, 8:12 PM · Krusader

Wed, May 13

yurchor accepted D29696: Update copyright years.

Thanks.

Wed, May 13, 6:40 AM · Krusader

Tue, May 12

asensi closed D29433: Add "Copy/move queues" to the list of main advantages of Krusader.
Tue, May 12, 10:24 PM · Krusader
asensi requested review of D29696: Update copyright years.
Tue, May 12, 10:09 PM · Krusader
asensi added a comment to D29433: Add "Copy/move queues" to the list of main advantages of Krusader.

Thank you, Davide!

Tue, May 12, 10:04 PM · Krusader

Mon, May 11

gengisdave accepted D29609: Several minor changes aimed to make comments and code clearer, following the norms.
Mon, May 11, 6:14 AM · Krusader
yurchor accepted D29609: Several minor changes aimed to make comments and code clearer, following the norms.

Thanks.

Mon, May 11, 5:46 AM · Krusader
gengisdave accepted D29611: Add krusader-news mailing list to docs.
Mon, May 11, 5:45 AM · Documentation, Krusader
yurchor accepted D29611: Add krusader-news mailing list to docs.
Mon, May 11, 5:44 AM · Documentation, Krusader

Sun, May 10

asensi requested review of D29611: Add krusader-news mailing list to docs.
Sun, May 10, 9:00 PM · Documentation, Krusader
asensi requested review of D29609: Several minor changes aimed to make comments and code clearer, following the norms.
Sun, May 10, 8:46 PM · Krusader
asensi added a comment to T13133: Konfigurator: Improve management of tooltips and “What's This” help.

Note: After adding the last review request, this task is assumed to be complete.

Sun, May 10, 8:09 PM · Krusader
asensi added a task to D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Sun, May 10, 7:54 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`.
Sun, May 10, 7:54 PM · Krusader
asensi requested review of D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`.
Sun, May 10, 7:53 PM · Krusader
asensi added a task to D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Sun, May 10, 7:51 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`.
Sun, May 10, 7:51 PM · Krusader
asensi requested review of D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`.
Sun, May 10, 7:51 PM · Krusader
asensi added a task to D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Sun, May 10, 7:49 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`.
Sun, May 10, 7:49 PM · Krusader
asensi requested review of D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`.
Sun, May 10, 7:48 PM · Krusader
gengisdave accepted D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Sun, May 10, 7:42 PM · Krusader
asensi added a task to D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Sun, May 10, 7:41 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`.
Sun, May 10, 7:41 PM · Krusader
asensi requested review of D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`.
Sun, May 10, 7:41 PM · Krusader
asensi updated the diff for D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.

Two lines were also removed.

Sun, May 10, 7:36 PM · Krusader
gengisdave updated the diff for D29500: Close viewer tabs with middle click.

Updating revision with suggestions

Sun, May 10, 12:21 PM · Krusader
gengisdave accepted D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.

Tested on all spinboxes, no problems found

Sun, May 10, 11:42 AM · Krusader

Sat, May 9

asensi added inline comments to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Sat, May 9, 6:32 PM · Krusader
asensi updated the diff for D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.

Add the setToolTip()calling , so hints are also shown on labels on mouse-over .

Sat, May 9, 6:30 PM · Krusader
asensi updated the summary of D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Sat, May 9, 6:28 PM · Krusader
asensi accepted D29500: Close viewer tabs with middle click.

Thank you, Davide, for those important changes!

Sat, May 9, 6:19 PM · Krusader
gengisdave added a comment to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.

All fine, but hints are not shown on labels on mouse-over; only context help does (see inline).

Sat, May 9, 4:40 PM · Krusader
gengisdave accepted D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Sat, May 9, 3:37 PM · Krusader
gengisdave added a comment to D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.

Compiled and tested, no problems found.

Sat, May 9, 3:37 PM · Krusader
gengisdave closed D29453: Update icon size after the user changed it on Konfigurator.
Sat, May 9, 3:19 PM · Krusader
gengisdave added a comment to D29453: Update icon size after the user changed it on Konfigurator.

Better :)

Sat, May 9, 3:12 PM · Krusader
gengisdave closed D29353: Update copyright.
Sat, May 9, 2:31 PM · Krusader, Documentation
asensi added a comment to D29353: Update copyright.

I also accept the new version of the proposal, of course :-)

Sat, May 9, 1:57 PM · Krusader, Documentation
asensi added inline comments to D29453: Update icon size after the user changed it on Konfigurator.
Sat, May 9, 1:42 PM · Krusader
asensi accepted D29453: Update icon size after the user changed it on Konfigurator.

Thanks, Davide! (and Yuri :-) ) The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, using the brief and the detailed view. Other people can do their checks.

Sat, May 9, 1:39 PM · Krusader
asensi accepted D29430: Execute .desktop file.
Sat, May 9, 12:31 PM · Krusader
asensi added a comment to D29430: Execute .desktop file.

Thanks, Davide! The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, other people can do their checks. I attach some .desktop files:

Sat, May 9, 12:27 PM · Krusader
yurchor accepted D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.

Works for me. Thanks.

Sat, May 9, 6:33 AM · Krusader

Fri, May 8

asensi closed D29295: Add repology packaging status.

Both changes described there have been applied. Thanks, Davide!

Fri, May 8, 10:58 PM · Krusader
asensi added a comment to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.

It this code review is accepted, I'll add similar code but for widgets which are not spinBoxes.

Fri, May 8, 9:21 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Fri, May 8, 9:21 PM · Krusader
asensi added a task to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Fri, May 8, 9:21 PM · Krusader
asensi requested review of D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Fri, May 8, 9:20 PM · Krusader
asensi added a task to D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Fri, May 8, 9:16 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Fri, May 8, 9:16 PM · Krusader
asensi updated the summary of D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Fri, May 8, 9:15 PM · Krusader
asensi requested review of D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Fri, May 8, 9:13 PM · Krusader
asensi added a comment to D29429: Konfigurator: Avoid some duplications.

Fine to me, please add a TODO to move the tooltip association inside createSpinBox() (eventually with the related QLabel)

Fri, May 8, 9:03 PM · Krusader
asensi closed D29429: Konfigurator: Avoid some duplications.
Fri, May 8, 8:58 PM · Krusader
asensi added a comment to D29429: Konfigurator: Avoid some duplications.

Thanks for testing and informing, Yuri and Davide!

Fri, May 8, 8:56 PM · Krusader
asensi added a task to D29429: Konfigurator: Avoid some duplications: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Fri, May 8, 8:54 PM · Krusader
asensi added a revision to T13133: Konfigurator: Improve management of tooltips and “What's This” help: D29429: Konfigurator: Avoid some duplications.
Fri, May 8, 8:54 PM · Krusader
asensi updated the test plan for D29429: Konfigurator: Avoid some duplications.
Fri, May 8, 8:53 PM · Krusader
asensi created T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Fri, May 8, 8:48 PM · Krusader

Thu, May 7

asensi closed D28301: Add options for hiding some useless entries from Media Menu.
Thu, May 7, 11:16 PM · Krusader
asensi added a comment to D28301: Add options for hiding some useless entries from Media Menu.

If someone is thinking about another option, please feel free to talk about it.
Thanks, S-trace! (and Davide and Yuri :-) )

Thu, May 7, 11:15 PM · Krusader
asensi closed D29316: Refactor the "New Folder..." dialog so that it keeps a folder history and suggests folder names.
Thu, May 7, 10:26 PM · Krusader
asensi added a comment to D29316: Refactor the "New Folder..." dialog so that it keeps a folder history and suggests folder names.

Thanks for testing and informing, Davide!

Thu, May 7, 10:25 PM · Krusader
yurchor accepted D29500: Close viewer tabs with middle click.

Tested to work as expected. Thanks.

Thu, May 7, 1:18 PM · Krusader

Wed, May 6

gengisdave updated the diff for D29353: Update copyright.

typo fix

Wed, May 6, 9:41 PM · Krusader, Documentation
gengisdave accepted D28301: Add options for hiding some useless entries from Media Menu.

Used in last month, no problems found.

Wed, May 6, 9:34 PM · Krusader
gengisdave requested review of D29500: Close viewer tabs with middle click.
Wed, May 6, 9:33 PM · Krusader
asensi added a comment to D28301: Add options for hiding some useless entries from Media Menu.

Meanwhile, I performed tests under Kubuntu 18.04 and 20.04 and the resulting code worked. I've been using it since March 29, having its advantages without seeing any problem. As previously written, it avoids cases like the one in https://i.stack.imgur.com/QTx1O.jpg (from https://askubuntu.com/questions/1109715/hide-loop-partitions-snaps-in-krusader).

Wed, May 6, 8:36 PM · Krusader
yurchor accepted D29453: Update icon size after the user changed it on Konfigurator.

Works as expected for me. Thanks.

Wed, May 6, 2:48 PM · Krusader

Tue, May 5

gengisdave updated the summary of D29453: Update icon size after the user changed it on Konfigurator.
Tue, May 5, 6:53 PM · Krusader
gengisdave requested review of D29453: Update icon size after the user changed it on Konfigurator.
Tue, May 5, 6:49 PM · Krusader
gengisdave added a comment to D23912: Respect .hidden files.

I always forget to update the ChangeLog

Tue, May 5, 6:48 AM · Krusader
yurchor accepted D29429: Konfigurator: Avoid some duplications.

Thanks, works as expected.

Tue, May 5, 6:42 AM · Krusader