Feed Advanced Search

Today

alex added a comment to D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file.

what do you think about using make -j$(nproc) instead of just make this way all the available cores are used for compiling.
This is just a little trick I sometimes forget to change when I follow build instructions.

Fri, Feb 21, 9:06 AM · Krusader

Yesterday

asensi requested review of D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file.
Thu, Feb 20, 11:31 PM · Krusader

Wed, Feb 19

asensi accepted D27302: Update obsolete KProcess::error.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:30 PM · Krusader
asensi accepted D27290: Update obsolete QWidget::getContentsMargins.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:30 PM · Krusader
asensi accepted D27289: Update obsolete QString::sprintf.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:29 PM · Krusader

Tue, Feb 18

gengisdave accepted D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).

Sounds good to me, no errors found

Tue, Feb 18, 7:16 AM · Krusader

Sun, Feb 16

asensi added a comment to D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Note: There are related changes in https://phabricator.kde.org/D27446

Sun, Feb 16, 9:38 PM · Krusader
asensi requested review of D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).
Sun, Feb 16, 9:30 PM · Krusader

Sat, Feb 15

asensi closed D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Thanks, Yuri and Davide!

Sat, Feb 15, 5:25 PM · Krusader
asensi closed D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.
Sat, Feb 15, 5:15 PM · Documentation, Krusader
asensi closed D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

Closed by commit https://cgit.kde.org/krusader.git/commit/?id=419ac6ec839414bbae52849af536bc8ba1da83e4

Sat, Feb 15, 5:12 PM · Krusader
asensi added a comment to D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

Thanks, Yuri and Davide!

Sat, Feb 15, 5:01 PM · Krusader
asensi added a comment to D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

Thanks, Yuri, Antonio and Davide!

Sat, Feb 15, 5:00 PM · Documentation, Krusader
gengisdave accepted D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Compiled and tested on QT 5.14.1, QT 5.9.5 (Ubuntu 18.04) and QT 5.12.4 (Ubuntu 19.10); all fine

Sat, Feb 15, 11:24 AM · Krusader

Wed, Feb 12

gengisdave accepted D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

All good, thanks.

Wed, Feb 12, 10:16 AM · Documentation, Krusader
Abella accepted D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

Fine

Wed, Feb 12, 8:49 AM · Documentation, Krusader
yurchor accepted D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

No objections if it works.

Wed, Feb 12, 7:01 AM · Documentation, Krusader

Tue, Feb 11

asensi requested review of D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.
Tue, Feb 11, 11:07 PM · Documentation, Krusader

Mon, Feb 10

gengisdave requested review of D27302: Update obsolete KProcess::error.
Mon, Feb 10, 6:58 PM · Krusader
gengisdave requested review of D27290: Update obsolete QWidget::getContentsMargins.
Mon, Feb 10, 3:19 PM · Krusader
gengisdave requested review of D27289: Update obsolete QString::sprintf.
Mon, Feb 10, 2:41 PM · Krusader
gengisdave closed D26325: Update deprecated KUrlLabel::leftClickedUrl.
Mon, Feb 10, 10:18 AM · Krusader
gengisdave closed D23924: Add QT::KeyMenu action to search results.
Mon, Feb 10, 10:13 AM · Krusader
gengisdave closed D26269: Remove deprecated mostLocalUrl.
Mon, Feb 10, 10:01 AM · Krusader
gengisdave accepted D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

All tests fine.

Mon, Feb 10, 9:47 AM · Krusader

Sat, Feb 8

yurchor added a comment to D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

Tested to work as expected.

Sat, Feb 8, 8:25 PM · Krusader
yurchor added a comment to D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Tested to work as expected.

Sat, Feb 8, 8:24 PM · Krusader
asensi requested review of D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.
Sat, Feb 8, 7:37 PM · Krusader
asensi requested review of D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.
Sat, Feb 8, 7:16 PM · Krusader
gengisdave closed D26334: Select item from search window.
Sat, Feb 8, 1:52 PM · Krusader
gengisdave added a comment to D26334: Select item from search window.

Although the current fix works for me, i propose to change the added line into

panel->view->setNameToMakeCurrent(nameToMakeCurrent);
Sat, Feb 8, 1:50 PM · Krusader

Fri, Feb 7

asensi closed D27076: Update information in the INSTALL file, make some steps clearer, cover some more cases.
Fri, Feb 7, 11:47 PM · Krusader

Sat, Feb 1

yurchor accepted D27076: Update information in the INSTALL file, make some steps clearer, cover some more cases.

Thanks.

Sat, Feb 1, 7:59 AM · Krusader

Fri, Jan 31

asensi requested review of D27076: Update information in the INSTALL file, make some steps clearer, cover some more cases.
Fri, Jan 31, 10:10 PM · Krusader

Thu, Jan 30

asensi closed D24480: Change the document about helping Krusader, add other ways (2).

Closing it manually because it wasn't closed automatically when performing the commit.

Thu, Jan 30, 11:13 PM · Krusader
asensi closed D23309: Change the document about helping Krusader, add other ways.
Thu, Jan 30, 11:10 PM · Krusader, Documentation
asensi added a comment to D24480: Change the document about helping Krusader, add other ways (2).

This modification and the related one (https://phabricator.kde.org/D23309) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

Thu, Jan 30, 10:56 PM · Krusader
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This modification and the related one (https://phabricator.kde.org/D24480) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

Thu, Jan 30, 10:50 PM · Krusader, Documentation

Mon, Jan 27

asensi accepted D24987: Add Kompare as compare application with KIO support.

The new version of the proposal keeps being acceptable, of course :-)

Mon, Jan 27, 11:22 PM · Krusader
asensi added a comment to D26291: rework of keyboard widgets focus.

So we have to consider that CTRL+UP/DOWN cannot be used anymore as before and users may complain about it. However, this did
also not work for the embedded terminal (see bug report) and for the sidebar before this patch.

Mon, Jan 27, 11:18 PM · Documentation, Krusader
asensi closed D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.
Mon, Jan 27, 10:59 PM · Krusader
asensi updated the diff for D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.

Previously, syncList->setFocus(); was utilized as it was used in three other places in the same file, although with btnCompareDirs->setFocus(); the intentions becomes clearer. Thanks, Alex! (and Yuri :-)

Mon, Jan 27, 10:57 PM · Krusader
abika accepted D26291: rework of keyboard widgets focus.

Good improvement in my opinion!
My test results:

  • The CTRL+SHIFT+UP/DOWN shortcuts work perfectly. Only when unfocusing the navigation bar a second time, the edit mode stays on. It might be a widget problem, but i consider it minor and it happened also before this patch.
  • Then i set CTRL+UP/DOWN as alternative shortcuts for the same actions to see if this can be used for backwards compatibility: This does not work when trying to unfocusing the navigation bar, the embedded terminal or the command line. All these widgets are capturing the key press and the shortcut action is not activated.
Mon, Jan 27, 5:46 PM · Documentation, Krusader
abika accepted D26334: Select item from search window.

Thanks for the fix Davide! This was also annoying me a lot.

Mon, Jan 27, 4:50 PM · Krusader
abika accepted D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.

Thanks Toni. Works as expected.
But i still would recommend to either use btnCompareDirs->setFocus(); directly instead, or to add a short comment that syncList is focused to have the compare dirs button (which is set as default) being executed on pressing "Enter".
Otherwise it is a bit confusing why the empty tree widget is focused.

Mon, Jan 27, 3:10 PM · Krusader
abika added a comment to D24987: Add Kompare as compare application with KIO support.

I removed the two added brackets again.

Mon, Jan 27, 2:25 PM · Krusader
abika updated the diff for D24987: Add Kompare as compare application with KIO support.
  • fixup! Add Kompare as compare application with KIO support
Mon, Jan 27, 2:18 PM · Krusader
abika added a comment to D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

[Got finally some time for Krusader again:)]

Mon, Jan 27, 2:08 PM · Krusader
Diffusion closed D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.
Mon, Jan 27, 2:05 PM · Krusader

Sat, Jan 25

asensi updated the diff for D24480: Change the document about helping Krusader, add other ways (2).

An address was changed, following what Yuri recently applied (e.g. it can be seen in Fix links on docs.kde.org).

Sat, Jan 25, 7:52 PM · Krusader

Fri, Jan 24

asensi requested review of D26887: Synchronizer: Avoid that, in several cases, the default action is to overwrite a file with an old version of it.
Fri, Jan 24, 12:23 AM · Krusader

Thu, Jan 23

asensi closed D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Thu, Jan 23, 10:03 PM · Documentation, Krusader
asensi retitled D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org from Change docbooks in order to make Krusader build at least under Kubuntu/Ubuntu 18.04 LTS to Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Thu, Jan 23, 9:43 PM · Documentation, Krusader
yurchor accepted D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Thu, Jan 23, 6:59 AM · Documentation, Krusader

Jan 22 2020

asensi updated the diff for D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.

The changes suggested by Yuri Chornoivan were made, also the USB entity was defined.

Jan 22 2020, 9:41 PM · Documentation, Krusader
yurchor added a comment to D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.

This can be solved much more easily without breaking translations by adding entities into index.docbook header (~line 27):

Jan 22 2020, 6:38 AM · Documentation, Krusader

Jan 21 2020

asensi requested review of D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Jan 21 2020, 10:20 PM · Documentation, Krusader

Jan 18 2020

yurchor accepted D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.

Works as expected. Thanks.

Jan 18 2020, 12:45 PM · Krusader
yurchor accepted D24480: Change the document about helping Krusader, add other ways (2).
Jan 18 2020, 12:39 PM · Krusader

Jan 17 2020

asensi requested review of D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.
Jan 17 2020, 10:24 PM · Krusader

Jan 16 2020

asensi added a comment to D24987: Add Kompare as compare application with KIO support.

Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!

Jan 16 2020, 11:20 PM · Krusader
asensi accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)

Jan 16 2020, 10:13 PM · Krusader

Jan 15 2020

asensi accepted D26269: Remove deprecated mostLocalUrl.

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Jan 15 2020, 11:08 PM · Krusader
asensi added a comment to D26291: rework of keyboard widgets focus.

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+ and Ctrl+ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?

Jan 15 2020, 10:49 PM · Documentation, Krusader
asensi accepted D26280: Move 'connect' call before openUrl.

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

Jan 15 2020, 10:21 PM · Krusader
asensi added a comment to D26334: Select item from search window.

Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.

Jan 15 2020, 10:07 PM · Krusader

Jan 14 2020

asensi accepted D26325: Update deprecated KUrlLabel::leftClickedUrl.

The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Jan 14 2020, 10:18 PM · Krusader
asensi accepted D26334: Select item from search window.

That bug has been hindering Krusader users for too long, thanks Davide! :-)

Jan 14 2020, 10:00 PM · Krusader

Jan 9 2020

nicolasfella closed D26535: Remove unused include.
Jan 9 2020, 8:30 PM · Krusader
gengisdave accepted D26535: Remove unused include.

Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3

Jan 9 2020, 1:25 AM · Krusader

Jan 1 2020

gengisdave closed T3479: Krusader freezes when renaming a file that is inside an archive as Resolved.
Jan 1 2020, 5:01 PM · Krusader

Dec 31 2019

gengisdave requested review of D26334: Select item from search window.
Dec 31 2019, 5:56 PM · Krusader
gengisdave requested review of D26325: Update deprecated KUrlLabel::leftClickedUrl.
Dec 31 2019, 11:12 AM · Krusader

Dec 30 2019

tguzairov added a comment to D26280: Move 'connect' call before openUrl.

have changed the comment

Dec 30 2019, 10:31 PM · Krusader
tguzairov updated the diff for D26280: Move 'connect' call before openUrl.

Changed comment

Dec 30 2019, 10:29 PM · Krusader
yurchor accepted D26291: rework of keyboard widgets focus.
Dec 30 2019, 2:58 PM · Documentation, Krusader
gengisdave updated the diff for D26291: rework of keyboard widgets focus.

Updated docbook as stated by @yurchor.

Dec 30 2019, 2:51 PM · Documentation, Krusader
yurchor added a comment to D26291: rework of keyboard widgets focus.

It would be nice to move shortcuts in keyboard-commands.docbook (~line 947) from Ctrl to Ctrl-Shift section ( ~line 1218) or make those sections coherent with this patch.

Dec 30 2019, 2:06 PM · Documentation, Krusader
gengisdave requested review of D26291: rework of keyboard widgets focus.
Dec 30 2019, 1:56 PM · Documentation, Krusader
nmel added a comment to D26280: Move 'connect' call before openUrl.

This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!

Dec 30 2019, 8:45 AM · Krusader

Dec 29 2019

tguzairov added a project to D26280: Move 'connect' call before openUrl: Krusader.
Dec 29 2019, 11:31 PM · Krusader
gengisdave requested review of D26269: Remove deprecated mostLocalUrl.
Dec 29 2019, 8:57 AM · Krusader

Dec 22 2019

gengisdave accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

Compiled and tested with no errors, thanks

Dec 22 2019, 1:16 PM · Krusader

Dec 2 2019

nicolasfella closed D25669: Replace Q_DECL_OVERRIDE with override.
Dec 2 2019, 11:42 AM · Krusader
gengisdave accepted D25669: Replace Q_DECL_OVERRIDE with override.

Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).

Dec 2 2019, 7:03 AM · Krusader

Nov 10 2019

yurchor added a comment to D24987: Add Kompare as compare application with KIO support.
In D24987#560752, @pino wrote:

I have no idea what "Boy Scout rule" is supposed to mean

Nov 10 2019, 5:33 PM · Krusader
pino requested changes to D24987: Add Kompare as compare application with KIO support.

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

Nov 10 2019, 5:26 PM · Krusader
abika added inline comments to D24987: Add Kompare as compare application with KIO support.
Nov 10 2019, 4:31 PM · Krusader
abika updated the diff for D24987: Add Kompare as compare application with KIO support.
  • fixup! Add Kompare as compare application with KIO support
Nov 10 2019, 4:26 PM · Krusader

Nov 2 2019

pino requested changes to D24987: Add Kompare as compare application with KIO support.
Nov 2 2019, 10:48 PM · Krusader
yurchor added a comment to D24987: Add Kompare as compare application with KIO support.

Tested to work as expected. Thanks for your work.

Nov 2 2019, 7:02 PM · Krusader

Oct 27 2019

abika added a project to D24987: Add Kompare as compare application with KIO support: Krusader.
Oct 27 2019, 5:25 PM · Krusader

Oct 20 2019

abika added a project to D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location: Krusader.
Oct 20 2019, 4:54 PM · Krusader
Diffusion closed D24026: Replace explicite type casting with dynamic casts.
Oct 20 2019, 3:12 PM · Krusader
abika added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi Toni,

Oct 20 2019, 3:07 PM · Krusader

Oct 7 2019

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

Oct 7 2019, 9:32 PM · Krusader, Documentation
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Oct 7 2019, 9:31 PM · Krusader, Documentation
asensi requested review of D24480: Change the document about helping Krusader, add other ways (2).
Oct 7 2019, 9:28 PM · Krusader
asensi added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);
Oct 7 2019, 9:17 PM · Krusader

Sep 21 2019

gengisdave closed D23938: Fix warning about macro expansion.
Sep 21 2019, 3:09 PM · Krusader