Moving to Gitlab
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Oct 6 2020
Oct 6 2020
xyquadrat raised the priority of T13050: Help Krusader to celebrate 20 years from Normal to Needs Triage.
Jul 3 2020
Jul 3 2020
May 31 2020
May 31 2020
May 30 2020
May 30 2020
Thanks! This review continues on https://invent.kde.org/utilities/krusader/-/merge_requests/8
Thanks Toni, I missed that.
May 28 2020
May 28 2020
Ctrl+Up and Ctrl+Down would stop working 😔 and IIRC Davide was trying to solve that.
@gengisdave , I don't see this merged. Forgotten?
@asensi , would you like to rebase the change in your fork and create a pull request on GitLab? My VM is working now and it's a useful change - I could help to review and test it.
May 23 2020
May 23 2020
May 15 2020
May 15 2020
Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.
Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.
+1
+1
Dear developers,
Dear developers,
asensi closed T13133: Konfigurator: Improve management of tooltips and “What's This” help as Resolved.
May 14 2020
May 14 2020
Thank you, Davide and Yuri!
Adapted the proposal to the current code base, with minor improvements.
gengisdave accepted D29608: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createURLRequester()`.
Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createURLRequester()
gengisdave accepted D29607: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createFontChooser()`.
Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createFontChooser()
gengisdave accepted D29606: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createEditBox()`.
Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createEditBox()
gengisdave accepted D29605: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createComboBox()`.
Compiled and tested, tooltips are visible when hovering with the mouse and with the help button. No tooltips are set outside createComboBox()
May 13 2020
May 13 2020
May 12 2020
May 12 2020
asensi added a comment to D29433: Add "Copy/move queues" to the list of main advantages of Krusader.
Thank you, Davide!
May 11 2020
May 11 2020
yurchor accepted D29609: Several minor changes aimed to make comments and code clearer, following the norms.
Thanks.
May 10 2020
May 10 2020
asensi added a comment to T13133: Konfigurator: Improve management of tooltips and “What's This” help.
Note: After adding the last review request, this task is assumed to be complete.
asensi updated the diff for D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Two lines were also removed.
Updating revision with suggestions
gengisdave accepted D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Tested on all spinboxes, no problems found
May 9 2020
May 9 2020
asensi updated the diff for D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
Add the setToolTip()calling , so hints are also shown on labels on mouse-over .
Thank you, Davide, for those important changes!
gengisdave added a comment to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
All fine, but hints are not shown on labels on mouse-over; only context help does (see inline).
gengisdave added a comment to D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Compiled and tested, no problems found.
Better :)
I also accept the new version of the proposal, of course :-)
Thanks, Davide! (and Yuri :-) ) The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, using the brief and the detailed view. Other people can do their checks.
Thanks, Davide! The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, other people can do their checks. I attach some .desktop files:
yurchor accepted D29545: Konfigurator: Ease management of tooltips and “What's This” texts by changing create* functions. Add a tooltip also useful as a test item.
Works for me. Thanks.
May 8 2020
May 8 2020
Both changes described there have been applied. Thanks, Davide!
asensi added a comment to D29546: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before calling `createSpinBox()`.
It this code review is accepted, I'll add similar code but for widgets which are not spinBoxes.
In D29429#663490, @gengisdave wrote:Fine to me, please add a TODO to move the tooltip association inside createSpinBox() (eventually with the related QLabel)
Thanks for testing and informing, Yuri and Davide!
May 7 2020
May 7 2020
If someone is thinking about another option, please feel free to talk about it.
Thanks, S-trace! (and Davide and Yuri :-) )