janlepper (Jan Lepper)
User

Projects

Badges

User does not have any badges.
User Since
Dec 9 2016, 3:17 PM (10 w, 3 d)

Recent Activity

Wed, Feb 8

janlepper added a comment to D4146: ListPanel: don't go back in history if refresh failed.
In D4146#84030, @asensi wrote:

Btw: Am I right assuming that having "Krusader" as a blocking reviewer requires all members to accept?

I'm going to accept it, so everybody will see how that works :-)

Wed, Feb 8, 1:27 PM · Krusader
janlepper edited reviewers for D4146: ListPanel: don't go back in history if refresh failed, added: abika, gengisdave, yurchor; removed: Krusader.
Wed, Feb 8, 1:25 PM · Krusader
janlepper added a comment to T5062: Improve search results tab.

Another option: Use Lister and add the necessary methods.

Wed, Feb 8, 1:07 PM · Krusader

Mon, Feb 6

janlepper added a comment to T5062: Improve search results tab.

True, that would be easier and also do the job.
KParts::TextExtension should come in handy here.

Mon, Feb 6, 8:39 AM · Krusader
janlepper added a comment to D4146: ListPanel: don't go back in history if refresh failed.

Before I go forward I would like some more opinions ;)

Mon, Feb 6, 8:28 AM · Krusader
janlepper removed a reviewer for D4146: ListPanel: don't go back in history if refresh failed: martinkostolny.
Mon, Feb 6, 8:27 AM · Krusader

Jan 18 2017

janlepper requested changes to D2857: Use KRun for "Open with"->"Other..." dialog.
Jan 18 2017, 4:38 AM

Jan 15 2017

janlepper updated D4146: ListPanel: don't go back in history if refresh failed.
Jan 15 2017, 8:46 PM · Krusader
janlepper added a task to D4146: ListPanel: don't go back in history if refresh failed: T5017: Avoid nested event dispatching.
Jan 15 2017, 8:32 PM · Krusader
janlepper added a revision to T5017: Avoid nested event dispatching: D4146: ListPanel: don't go back in history if refresh failed.
Jan 15 2017, 8:32 PM · Krusader
janlepper added a reviewer for D4146: ListPanel: don't go back in history if refresh failed: Krusader.
Jan 15 2017, 7:53 PM · Krusader
janlepper updated D4146: ListPanel: don't go back in history if refresh failed.
Jan 15 2017, 7:52 PM · Krusader
janlepper retitled D4146: ListPanel: don't go back in history if refresh failed from to ListPanel: don't go back in history if refresh failed.
Jan 15 2017, 7:21 PM · Krusader

Jan 13 2017

janlepper reopened D2857: Use KRun for "Open with"->"Other..." dialog.

I intentionally went via ListPanelFunc::runCommand() so that the panel's path is set as working directory for the command.
With KRun::displayOpenWithDialog() there is no guarantee for that.

Jan 13 2017, 4:40 PM

Jan 12 2017

janlepper added a comment to T5062: Improve search results tab.

How about that?

Jan 12 2017, 1:43 PM · Krusader
janlepper added a comment to T5062: Improve search results tab.

I'm sorry - it's just a mockup ;)
I don't think I'll be working on this in the near future - just wanted to collect some ideas.
The mc-like result list will probably require a lot of work - in KrView there is a 1:1 relationship between view item and a file, but this would require multiple items per file.

Jan 12 2017, 1:27 PM · Krusader
janlepper edited the description of T5062: Improve search results tab.
Jan 12 2017, 1:16 PM · Krusader

Jan 11 2017

janlepper edited the description of T5062: Improve search results tab.
Jan 11 2017, 4:56 PM · Krusader
janlepper edited the description of T5062: Improve search results tab.
Jan 11 2017, 4:40 PM · Krusader
janlepper created T5062: Improve search results tab.
Jan 11 2017, 4:37 PM · Krusader
janlepper added a comment to D3994: add asynchronous vfs refresh.

Unfortunately I don't have this area studied enough yet to consult the direction. But I certainly can test your code and report issues:). So far I found some regarding refreshing:

  • external changes aren't reflected (I have to manual refresh Ctrl+R to see them)
  • undo action will not refresh view after it is done

    But I understand it is a work in progress, so please say if it is too soon to test these "corner" cases. Anyway, thanks for Your work!
Jan 11 2017, 9:59 AM · Krusader

Jan 10 2017

janlepper added a comment to T5057: Check usage of QDir::setCurrent().

The invocation In ListPanelFunc::doRefresh() seems to rely on the panel being the active one (which was true historically - when refreshing a panel would activate itself first).
Nowadays a panel might refresh while being inactive - breaking code which relies on the workdir matching the active panel.

Jan 10 2017, 7:03 PM · Krusader
janlepper created T5057: Check usage of QDir::setCurrent().
Jan 10 2017, 6:58 PM · Krusader
janlepper removed a dependent revision for D3994: add asynchronous vfs refresh: Unknown Object (Differential Revision).
Jan 10 2017, 2:37 AM · Krusader
janlepper set the repository for D3994: add asynchronous vfs refresh to R167 Krusader.
Jan 10 2017, 2:23 AM · Krusader
janlepper updated the diff for D3994: add asynchronous vfs refresh.
Jan 10 2017, 2:23 AM · Krusader
janlepper added a dependent revision for D3994: add asynchronous vfs refresh: Unknown Object (Differential Revision).
Jan 10 2017, 12:38 AM · Krusader

Jan 9 2017

janlepper changed the visibility for D3994: add asynchronous vfs refresh.
Jan 9 2017, 9:11 PM · Krusader

Jan 8 2017

janlepper added a reviewer for D3994: add asynchronous vfs refresh: Krusader.
Jan 8 2017, 5:11 PM · Krusader

Jan 6 2017

janlepper edited the description of T5017: Avoid nested event dispatching.
Jan 6 2017, 4:58 PM · Krusader
janlepper added a task to D3994: add asynchronous vfs refresh: T5017: Avoid nested event dispatching.
Jan 6 2017, 4:57 PM · Krusader
janlepper added a revision to T5017: Avoid nested event dispatching: D3994: add asynchronous vfs refresh.
Jan 6 2017, 4:57 PM · Krusader
janlepper retitled D3994: add asynchronous vfs refresh from to add asynchronous vfs refresh.
Jan 6 2017, 4:57 PM · Krusader

Jan 4 2017

janlepper added a comment to T3419: Rework of VFS.

Just so we don't duplicate our efforts: T5017

Jan 4 2017, 10:31 AM · Krusader
janlepper edited the description of T5017: Avoid nested event dispatching.
Jan 4 2017, 10:31 AM · Krusader
janlepper edited the description of T5017: Avoid nested event dispatching.
Jan 4 2017, 10:21 AM · Krusader

Jan 3 2017

janlepper edited the description of T5017: Avoid nested event dispatching.
Jan 3 2017, 12:11 AM · Krusader

Jan 2 2017

janlepper created T5017: Avoid nested event dispatching.
Jan 2 2017, 11:37 PM · Krusader
janlepper added a comment to T3419: Rework of VFS.
In T3419#70758, @abika wrote:

I'm still unsure if we should split the vfs class (in e.g. FileLister and FileOperations). Currently there is only one method that is used without vfs: copyFiles().

It's problybly not that important.

Thinking about it, a more beneficial thing would be moving to a non-blocking
refresh refresh like in KDirLister.

Then there is vfs::calcSpace() which also blocks.
From there I stumbled on vfs::calcSpaceKIO and "TODO called from another thread, creating KIO jobs does not work here".
I recall that KIO jobs move themselves to the main (or gui?) thread, or is my memory wrong here?

Jan 2 2017, 11:12 PM · Krusader

Dec 14 2016

janlepper added a comment to T3419: Rework of VFS.
In T3419#70758, @abika wrote:

I'm still unsure if we should split the vfs class (in e.g. FileLister and FileOperations). Currently there is only one method that is used without vfs: copyFiles().

Dec 14 2016, 4:32 AM · Krusader

Dec 9 2016

janlepper added a member for Krusader: janlepper.
Dec 9 2016, 3:40 PM
janlepper added a comment to T3419: Rework of VFS.

If I didn't overlook something this vfs instance is never deleted:
https://cgit.kde.org/krusader.git/tree/krusader/VFS/krvfshandler.cpp?id=2f50bd46ebcc643bd99f88afef45561f4fb5d08e#n54

Dec 9 2016, 3:22 PM · Krusader
janlepper added a watcher for Krusader: janlepper.
Dec 9 2016, 3:18 PM