- User Since
- Dec 9 2016, 3:17 PM (156 w, 1 d)
Jun 8 2017
If you are reworking the views you might want take a look at what I did: https://cgit.kde.org/clones/krusader/janlepper/krusader.git/tree/krusader/ListView?h=port-listview-rework
Among the changes:
- remove KrViewOperator
- KrView inherits QObject
- the actual widget is a separate object of the view (take a look at KrInterView for how I id it)
- more that I can't think of right now ;)
Apr 9 2017
Hmm, I can't update the diff (permissions?)
Sorry for the even later reaction ;)
Well, the QPointer doesn't hurt, but it doesn't fix the problem in this case.
Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.
Apr 4 2017
I'm sorry for the regression.
I assumed this situation (a panel was destroyed while still refreshing) wouldn't occur.
There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.
Asynchronous refresh of course would also fix that problem.
Mar 16 2017
That was fast - thanks!
Mar 7 2017
Right, I didn't really think this through.
So it's probably the lesser effort to embed Lister into the result view.
Mar 5 2017
Well, you could add
static void KViewer::viewWithLister(QUrl url, QString searchText)
Mar 3 2017
I assume gengisdave won't comment on this (hasn't been active for a while)
Feb 27 2017
As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.
Feb 8 2017
Another option: Use Lister and add the necessary methods.
Feb 6 2017
True, that would be easier and also do the job.
KParts::TextExtension should come in handy here.
Before I go forward I would like some more opinions ;)
Jan 18 2017
Jan 15 2017
Jan 13 2017
I intentionally went via ListPanelFunc::runCommand() so that the panel's path is set as working directory for the command.
With KRun::displayOpenWithDialog() there is no guarantee for that.
Jan 12 2017
How about that?
I'm sorry - it's just a mockup ;)
I don't think I'll be working on this in the near future - just wanted to collect some ideas.
The mc-like result list will probably require a lot of work - in KrView there is a 1:1 relationship between view item and a file, but this would require multiple items per file.
Jan 11 2017
Jan 10 2017
The invocation In ListPanelFunc::doRefresh() seems to rely on the panel being the active one (which was true historically - when refreshing a panel would activate itself first).
Nowadays a panel might refresh while being inactive - breaking code which relies on the workdir matching the active panel.
Jan 9 2017
Jan 8 2017
Jan 6 2017
Jan 4 2017
Just so we don't duplicate our efforts: T5017
Jan 3 2017
Jan 2 2017
Dec 14 2016
Dec 9 2016
If I didn't overlook something this vfs instance is never deleted: