rework of keyboard widgets focus
AcceptedPublic

Authored by gengisdave on Mon, Dec 30, 1:56 PM.

Details

Reviewers
yurchor
Group Reviewers
Krusader
Summary

In Krusader you can move between widgets both with two configurable shortcuts "Focus up/down" (default : CTRL+SHIFT+UP/DOWN) and with an hardcoded CTRL+UP/DOWN, but neither can move through all the widgets.

This patch drops the hardcoded version in favor of the configurable one letting all widgets to be focused in sequence, all the unneeded code is removed.

The documentation is changed with the new shortcuts.

FIXED: [ 414831 ] cant focus embedded terminal with ctrl+down
BUG: 414831

Test Plan

With every or part of the widgets active, CTRL+SHIFT+UP/DOWN (or anything else configured as Focus up/down), must move between the widgets in the following order (from top to bottom):

  • Location Bar (edit mode on focus in, navigate mode on focus out)
  • File View
  • Sidebar (it is considered always beneath the file view, unregarding its real position)
  • Embedded emulator
  • Command line

Moreover, CTRL+UP/DOWN should not change widgets focus

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave created this revision.Mon, Dec 30, 1:56 PM
Restricted Application added a project: Documentation. · View Herald TranscriptMon, Dec 30, 1:56 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
gengisdave requested review of this revision.Mon, Dec 30, 1:56 PM

Thanks.

It would be nice to move shortcuts in keyboard-commands.docbook (~line 947) from Ctrl to Ctrl-Shift section ( ~line 1218) or make those sections coherent with this patch.

gengisdave updated this revision to Diff 72383.Mon, Dec 30, 2:51 PM

Updated docbook as stated by @yurchor.

yurchor accepted this revision as: yurchor.Mon, Dec 30, 2:58 PM
This revision is now accepted and ready to land.Mon, Dec 30, 2:58 PM
asensi added a subscriber: asensi.Wed, Jan 15, 10:49 PM

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+ and Ctrl+ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?