Konfigurator: Improve management of tooltips and “What's This” help
Closed, ResolvedPublic

Description

SUMMARY

Improve management of tooltips and “What's This” help in Konfigurator.

As Davide Gianforte wrote:

  • Some other create* methods are missing the setWhatsThis() and setToolTip() because they don't get the string.
  • Move the tooltip association inside createSpinBox() (eventually with the related QLabel).

This task is also related to:

The performed changes have been grouped into several code reviews for an easier reviewing. However, the changes can be applied one after the other and tested at the end (at once, instead of testing each code review separately :-) ).

TEST PLAN

Open Konfigurator, go to:

  • Advanced
    • click on the "?" button, and click on the "Icon cache size (KB):" label in order to check that the “What's This” help is shown. After that: hover over its spinBox in order to check that a tooltip is shown.
  • Other widgets, and perform similar tests on them and their labels:
    • in Panel > View tab
      • the "Tooltip delay (msec)" label and its spinBox.
    • in General > Viewer/Editor tab
      • the "Use lister if the text file is bigger than:" label and its spinBox.
    • etc.

This is another test that I performed (although it also requires changing the source code of Krusader and rebuilding it). This time what was tested was the feature of changing automatically --inside createSpinBox()-- the “What's This” text of a dynamically created QLabel (which is added to a QList<QLabel *>):

Inside

KgColors::KgColors(bool first, QWidget* parent)

I substituted

dimFactor = createSpinBox("Colors", "Dim Factor", 80, 0, 100, spinBoxLabel, colorsGrp);

with

dimFactor = createSpinBox("Colors", "Dim Factor", 80, 0, 100, spinBoxLabel, colorsGrp, false, "EXPERIMENT");

then I checked that the text "EXPERIMENT" was shown:

After clicking on the question button, and later clicking on the label:

After hovering over the editbox: