KrusaderProject
ActivePublic

Recent Activity

Yesterday

palant accepted D4828: Duplicated tab should not be locked.

Fine with me, it sounds like duplicating locked state is indeed undesired with that use case.

Mon, Feb 27, 7:27 PM · Krusader
martinkostolny added a comment to D4828: Duplicated tab should not be locked.

For example me and a few friends of mine use it to keep some tabs in their locked path. When you select such locked tab and start browsing in it, you expect the tab to be duplicated and preserve the original selected tab. This is of course similar to selecting a tab, duplicating it and then browse. But with locked tab you can be sure you don't loose the tabs location. Of course it would be nice to have a visual difference between these two tab states (total commander appends * to such tab name) and a confirmation dialog whether I really want to close a locked tab. But I believe current state is good enough.

Mon, Feb 27, 5:27 PM · Krusader
palant added a comment to D4828: Duplicated tab should not be locked.

Frankly, we explicitly tested that "locked" setting was being duplicated when this was implemented. I have no idea however what users' expectation here might be. I managed to understand what this feature does but not what it is good for. What are people using "Lock Tab" for?

Mon, Feb 27, 5:09 PM · Krusader
martinkostolny created D4828: Duplicated tab should not be locked.
Mon, Feb 27, 4:45 PM · Krusader

Sun, Feb 26

aacid requested changes to D2603: Add advanced debugging to KIso.

Patch doesn't apply anymore

Sun, Feb 26, 10:40 PM · Krusader

Wed, Feb 22

palant added a member for Krusader: palant.
Wed, Feb 22, 5:27 PM

Tue, Feb 14

palant edited the content of Krusader.
Tue, Feb 14, 9:01 AM · Krusader
palant edited the content of Krusader.
Tue, Feb 14, 8:42 AM · Krusader

Mon, Feb 13

abika closed D4433: #375994 - List kio-extras under dependencies as recommended package.

Merged with master

Mon, Feb 13, 8:56 PM · Krusader
abika accepted D4433: #375994 - List kio-extras under dependencies as recommended package.
Mon, Feb 13, 8:55 PM · Krusader
abika closed D4427: Update "get involved" page to indicate how one can register.

Merged with master

Mon, Feb 13, 8:54 PM · Websites, Krusader
abika closed D4420: #375894 - Use case-insensitive as default for text search.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4418: #314258 - Duplicate tab settings when duplicating tabs.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4417: #375831 - Sort empty file extensions correctly.

Merged with master (and Phabricator fails again to autoclose this)

Mon, Feb 13, 8:53 PM · Krusader
palant edited the content of Krusader.
Mon, Feb 13, 7:12 PM · Krusader
abika edited the content of Krusader.
Mon, Feb 13, 7:02 PM · Krusader

Sat, Feb 11

asensi accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

It can be compiled and executed using Kubuntu 16.04 or 16.10, and everything seems to work correctly :-), thanks Wladimir!

Sat, Feb 11, 2:23 PM · Krusader

Fri, Feb 10

martinkostolny accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Yes, that must have been it. It now works nicely, thanks for the patch! :)

Fri, Feb 10, 4:29 PM · Krusader
abika accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Could it be that the issue there was being caused by the extra ListPanel::start() call?

Quick test says: yes!

Fri, Feb 10, 4:16 PM · Krusader
palant updated the diff for D4418: #314258 - Duplicate tab settings when duplicating tabs.

I reverted to the original approach and applied suggested changes. As far as locked tabs are concerned, everything seems to work correctly for me. Could it be that the issue there was being caused by the extra ListPanel::start() call?

Fri, Feb 10, 3:17 PM · Krusader

Thu, Feb 9

martinkostolny added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Alex have good points as well as You Wladimir about the simplicity of the previous code. I also agree now with the previous approach and sorry about the previous suggestion then.

Thu, Feb 9, 9:11 PM · Krusader
abika added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Ok, I see now that this is also not a good solution. The settings are going down to the PanelPopup and KrInterviews. All this should be copied. Sorry I didn't got this earlier.

Thu, Feb 9, 8:44 PM · Krusader

Wed, Feb 8

palant added a comment to T5062: Improve search results tab.

Sure, that would be easy - but there is little point as long as Lister isn't the default.

Wed, Feb 8, 4:04 PM · Krusader
abika accepted D4146: ListPanel: don't go back in history if refresh failed.

I personally prefer the old behavior. After restart going back to the "nearest" parent folder of a deleted path was pretty nice. And if it was a removable device I can mount it and go back to the folder with the history.

Wed, Feb 8, 3:20 PM · Krusader
abika accepted D4420: #375894 - Use case-insensitive as default for text search.

Like I said, I don't really care. In KFind case sensitivity is also off by default.

Wed, Feb 8, 3:02 PM · Krusader
martinkostolny accepted D4146: ListPanel: don't go back in history if refresh failed.
Wed, Feb 8, 1:45 PM · Krusader
yurchor accepted D4146: ListPanel: don't go back in history if refresh failed.
Wed, Feb 8, 1:39 PM · Krusader
janlepper added a comment to D4146: ListPanel: don't go back in history if refresh failed.
In D4146#84030, @asensi wrote:

Btw: Am I right assuming that having "Krusader" as a blocking reviewer requires all members to accept?

I'm going to accept it, so everybody will see how that works :-)

Wed, Feb 8, 1:27 PM · Krusader
janlepper edited reviewers for D4146: ListPanel: don't go back in history if refresh failed, added: abika, gengisdave, yurchor; removed: Krusader.
Wed, Feb 8, 1:25 PM · Krusader
janlepper added a comment to T5062: Improve search results tab.

Another option: Use Lister and add the necessary methods.

Wed, Feb 8, 1:07 PM · Krusader
palant added a comment to T5062: Improve search results tab.

Well, I'm stuck. The way I see it, the searchText method of KTextEditor::Document merely gives you the search results but doesn't affect the UI. There doesn't seem to be a way to manipulate the search bar, in particular the method KateSearchBar::setSearchPattern() is only called by unit tests.

Wed, Feb 8, 9:51 AM · Krusader
asensi accepted D4146: ListPanel: don't go back in history if refresh failed.

This changes the refresh behavior of the list panel to stay at the URL which failed to refresh, instead of going back in
the panel's history until the refresh is successful.

Wed, Feb 8, 9:06 AM · Krusader
asensi accepted D4420: #375894 - Use case-insensitive as default for text search.
Wed, Feb 8, 8:58 AM · Krusader
asensi added a comment to D4420: #375894 - Use case-insensitive as default for text search.

I've looked and: Kate, Konsole, Dolphin, Okular, etc. have case-insensitive search by default...

Wed, Feb 8, 8:51 AM · Krusader
martinkostolny accepted D4420: #375894 - Use case-insensitive as default for text search.

I find these arguments good enough to set the default to case insensitive, like You proposed :).

Wed, Feb 8, 12:00 AM · Krusader

Tue, Feb 7

palant added a comment to T5062: Improve search results tab.

KParts::TextExtension would have been too easy. At least on my system both viewer and editor are using KTextEditor which currently doesn't appear to implement KParts::TextExtension. It implements its own KTextEditor::Document interface instead which also allows searching but requires introducing a new dependency (not to mention fallback code). I am trying to make it work.

Tue, Feb 7, 2:27 PM · Krusader

Mon, Feb 6

palant updated the diff for D4418: #314258 - Duplicate tab settings when duplicating tabs.

I now implemented "proper" settings duplication as suggested. Frankly, I'm not convinced that this approach is better. It introduces quite a bit of code which is almost the same as what was there before but not quite. Also, is there really any setting where it makes sense to restore it on startup but not to duplicate when you duplicate the tab? The only one I left out here is the tab history but even that one should arguably better be duplicated.

Mon, Feb 6, 8:47 AM · Krusader
janlepper added a comment to T5062: Improve search results tab.

True, that would be easier and also do the job.
KParts::TextExtension should come in handy here.

Mon, Feb 6, 8:39 AM · Krusader
janlepper added a comment to D4146: ListPanel: don't go back in history if refresh failed.

Before I go forward I would like some more opinions ;)

Mon, Feb 6, 8:28 AM · Krusader
janlepper removed a reviewer for D4146: ListPanel: don't go back in history if refresh failed: martinkostolny.
Mon, Feb 6, 8:27 AM · Krusader

Sun, Feb 5

asensi added a comment to T5062: Improve search results tab.

This mockup is great but implementation will certainly take time. Unless somebody plans to work on this really soon, maybe a simpler solution
is worth considering: when opening the viewer from the file search with non-empty text, do a search for this text in the viewer automatically.
So the first result line should be selected immediately and pressing F3 should bring up the other matches. That's what Total Commander does.
These proposals aren't mutually exclusive of course.

Sun, Feb 5, 6:25 PM · Krusader
asensi added a comment to D4427: Update "get involved" page to indicate how one can register.

It's better this way, thanks, Wladimir!

Sun, Feb 5, 8:03 AM · Websites, Krusader
asensi accepted D4433: #375994 - List kio-extras under dependencies as recommended package.

Very good! Thanks, Wladimir!

Sun, Feb 5, 7:53 AM · Krusader
asensi accepted D4417: #375831 - Sort empty file extensions correctly.

Nice! Thanks, Wladimir!

Sun, Feb 5, 7:50 AM · Krusader
asensi accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Great! Thanks, Wladimir!

Sun, Feb 5, 7:47 AM · Krusader

Sat, Feb 4

palant added a reviewer for D4433: #375994 - List kio-extras under dependencies as recommended package: Krusader.
Sat, Feb 4, 9:20 PM · Krusader
palant added a comment to D4420: #375894 - Use case-insensitive as default for text search.

Well, grep is a command line utility - usability isn't a huge concern with those. As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either. So IMHO remembering these settings across restarts (or rather the selected search profile) would be nice to have but not a replacement for sane defaults.

Sat, Feb 4, 9:00 PM · Krusader
palant added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Yes, I used a temporary config group because the code in PanelManager::slotRecreatePanels() does it like that - this might not be the cleanest approach however. I will add a ListPanel::duplicateSettings(ListPanel*) method instead that restores a different set than ListPanel::restoreSettings(KConfigGroup). The danger here is however that these two methods get out of sync as new settings are added - some new settings will be restored by the latter but not the former even where both would make sense.

Sat, Feb 4, 7:52 PM · Krusader
martinkostolny accepted D4427: Update "get involved" page to indicate how one can register.
Sat, Feb 4, 2:52 PM · Websites, Krusader