KrusaderProject
ActivePublic

Recent Activity

Yesterday

martinkostolny accepted D12369: BookMan: Fixed various issues related to bookmark reloading from file.

Nicely fixed, thanks Nikita!

Tue, Apr 24, 4:39 PM · Krusader
yurchor accepted D12486: Cleaned up old auxiliary files, updated references and fixed layout in docs.

Thanks. Nice fixes.

Tue, Apr 24, 7:47 AM · Krusader
nmel added a project to D12487: Updated git ignore file: Krusader.
Tue, Apr 24, 7:31 AM · Krusader
nmel added a reviewer for D12486: Cleaned up old auxiliary files, updated references and fixed layout in docs: yurchor.

This is one of the steps towards the release.
Updates to ChangeLog, NEWS and features.docbook describing changes from v2.6 to v2.7 will go to a separate review.

Tue, Apr 24, 7:22 AM · Krusader

Sun, Apr 22

nmel added a project to D12369: BookMan: Fixed various issues related to bookmark reloading from file: Krusader.
Sun, Apr 22, 10:31 PM · Krusader
nmel closed D10352: Fix insufficient icon theme issues.

Didn't close automatically, probably because it was reopened earlier.

Sun, Apr 22, 10:19 PM · Krusader
asensi accepted D10352: Fix insufficient icon theme issues.

Toni, please accept this revision if you think it's good to merge with master.

Sun, Apr 22, 4:42 PM · Krusader

Sat, Apr 21

nmel closed D11903: Fix multirename shortcut.
Sat, Apr 21, 9:42 PM · Krusader
nmel closed D12338: Panel: fixed invisible column issue.
Sat, Apr 21, 9:41 PM · Krusader
nmel added a reviewer for D10352: Fix insufficient icon theme issues: Krusader.

A special case: using Adwaita icons

Adwaita icons using Kubuntu 17.10 (the first icons are not seen)

Adwaita icons using Kubuntu 17.10 - bookmark icons

Adwaita icons using Kubuntu 17.10 and Dolphin (almost all icons are not seen)

Sat, Apr 21, 9:10 PM · Krusader
D10352: Fix insufficient icon theme issues is now accepted and ready to land.

Thanks Toni and Martin for extensive testing!

Sat, Apr 21, 9:03 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

To reproduce this issue: set a dark colours theme and oxygen icons, close all tabs in one panel and observe disabled icon in Window menu's Close Current Tab action. Try this with master
branch and with fix-missing-icons branch.

Sat, Apr 21, 5:21 PM · Krusader
asensi accepted D12338: Panel: fixed invisible column issue.
Sat, Apr 21, 6:41 AM · Krusader

Fri, Apr 20

martinkostolny accepted D12338: Panel: fixed invisible column issue.

Same here, replicated with attached krusaderrc. And it no longer happens with this patch. Thanks, Nikita! :)

Fri, Apr 20, 11:37 PM · Krusader
martinkostolny accepted D10352: Fix insufficient icon theme issues.

Sorry for my late response. Thanks Nikita for fixing all the issues and Toni for useful testing screenshots.

Fri, Apr 20, 11:01 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

More screenshots:

Fri, Apr 20, 8:17 PM · Krusader
asensi added a comment to D12338: Panel: fixed invisible column issue.

Using Ubuntu 18.04 daily build: I could reproduce the problem, and it was solved by the patch made by Nikita. Thanks, Nikita!

Fri, Apr 20, 5:40 PM · Krusader

Thu, Apr 19

nmel added a comment to D10352: Fix insufficient icon theme issues.

Thanks for testing, Toni!
Martin, please let me know if you spot any problem.

Thu, Apr 19, 9:13 PM · Krusader
nmel added a comment to D12338: Panel: fixed invisible column issue.

Hi Toni,

Thu, Apr 19, 9:06 PM · Krusader
asensi added a comment to D12338: Panel: fixed invisible column issue.

Hello! I can't reproduce the "fixed invisible column" issue, so I attach some screenshots and "krusaderrc" files, if it may help:

Thu, Apr 19, 10:20 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

With the latest improvements made by Nikita, In an Ubuntu 18.04 daily build virtual machine, the icons were shown as it was expected:

Thu, Apr 19, 8:05 AM · Krusader
nmel added a project to D12338: Panel: fixed invisible column issue: Krusader.

In case you are eager to repro the problem I faced, here is excerpt from my config:

Thu, Apr 19, 6:29 AM · Krusader

Wed, Apr 18

nmel added a comment to D10352: Fix insufficient icon theme issues.

Resolved all outstanding issues, please check on your end.
Also updated 'icon-missing' icon — please let me know if you like it better or not. If you have a better icon, please attach a particular svg/svgz file you're interested in.

Wed, Apr 18, 7:46 AM · Krusader
nmel updated the diff for D10352: Fix insufficient icon theme issues.
  • Fixed missing icons in the file list (KrView)
  • Updated icon-missing icon to be similar in style to the Breeze icon theme
  • Added dynamic selection of light or dark Breeze fallback theme
  • Replaced KIconLoader::loadMimeTypeIcon with Icon
  • Added workaround for Breeze variant selection based on theme lightness
  • Icon: improved a method name and a comment
Wed, Apr 18, 7:37 AM · Krusader

Mon, Apr 16

nmel added a comment to D10352: Fix insufficient icon theme issues.

Thanks Nikita for your big work! :) It works nicely. I have 2 observations:

  1. choosing dark theme not working in dark environment - I'm proposing a simple solution - please see my code comment

It works if user specifies breeze-dark as the fallback theme in settings. I agree it would be nice to do this automatically. Your patch should work but also we need to make default of the fallback theme in settings empty, because the user's fallback theme takes precedence. Would you like to push it under your name to the remote branch?

Mon, Apr 16, 7:02 AM · Krusader

Sun, Apr 15

asensi added a comment to D10352: Fix insufficient icon theme issues.

Regarding the greyed out icons in Krusader: I believe this is because "breeze" is set
as system theme (not "breeze-dark") and fallback is also set as "breeze", so
there is no "breeze-dark" to fallback to.

Sun, Apr 15, 1:55 PM · Krusader
martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Thanks Nikita for your big work! :) It works nicely. I have 2 observations:

  1. choosing dark theme not working in dark environment - I'm proposing a simple solution - please see my code comment
  2. icon "application-x-cmakecache" (e.g. for file CMakeCache.txt inside krusader/build folder) is now rendered as a fallback icon (even with breeze) although previously it was rendered as "unknown"
    • I'm not sure if this is even solvable, or if it is important; I was currently unable to come up with a solution
Sun, Apr 15, 11:36 AM · Krusader
nmel updated the diff for D10352: Fix insufficient icon theme issues.

Fixing revision diff.

Sun, Apr 15, 4:27 AM · Krusader
nmel added a comment to D10352: Fix insufficient icon theme issues.

However, using Kubuntu 17.10 the icons are "greyed out":

Usually, under Kubuntu 17.10 the icons were the expected ones (not "greyed out"):

Sun, Apr 15, 4:23 AM · Krusader
nmel reopened D10352: Fix insufficient icon theme issues.

Hi Toni, Thanks a lot for testing.

Sun, Apr 15, 4:13 AM · Krusader
nmel closed D10352: Fix insufficient icon theme issues.
Sun, Apr 15, 4:02 AM · Krusader

Sat, Apr 14

asensi added a comment to D10352: Fix insufficient icon theme issues.

Then the appearance of Krusader is improved when using Ubuntu 18.04 daily build (without having Breeze nor Oxygen installed):

Sat, Apr 14, 5:02 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Note: That "icon-missing.svgz" file can be downloaded from https://phabricator.kde.org/file/download/ieoxfxmcslybdhrcwkhf/PHID-FILE-zues6xeejyrafgjglyel/icon-missing.svgz

Sat, Apr 14, 3:58 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Thanks, Nikita! A lot of work! I also wanted to say that, using Ubuntu 18.04 beta, I saw that error message when building Krusader (the "icon-missing.svgz" file was not found):

[ 84%] Built target krusader_autogen
make[2]: *** No hay ninguna regla para construir el objetivo '/home/user/krusader/krusader/icons/icon-missing.svgz', necesario para 'krusader/qrc_resources.cpp'.  Alto.
CMakeFiles/Makefile2:222: recipe for target 'krusader/CMakeFiles/krusader.dir/all' failed
make[1]: *** [krusader/CMakeFiles/krusader.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
Sat, Apr 14, 3:34 PM · Krusader
nmel added a comment to D10352: Fix insufficient icon theme issues.

Alright, this is it. Please help to test.

Sat, Apr 14, 6:16 AM · Krusader
nmel updated the diff for D10352: Fix insufficient icon theme issues.
  • Fixed names of variables, functions, members, methods related to icons
Sat, Apr 14, 6:06 AM · Krusader
nmel updated the diff for D10352: Fix insufficient icon theme issues.
  • Icon: Added overlay support and replaced KDE::icon in the project
Sat, Apr 14, 6:05 AM · Krusader

Fri, Apr 13

nmel added a comment to D10352: Fix insufficient icon theme issues.

I implemented the rest and fixed all the issues I was aware of. As you may notice from the commit message headers, Icon class now unifies loading with QIcon, KIconLoader (aka krLoader that is gone now), ICON macro, FL_LOADICON, SmallIcon etc. Unfortunately, a small number of places were not converted due to the use of overlays. I plan to work on this a little later — I wanted to update the CR early so you can provide feedback.

Fri, Apr 13, 7:42 AM · Krusader
nmel updated the diff for D10352: Fix insufficient icon theme issues.
  • Replaced QIcon::fromTheme with Icon instances
  • Added loading fallback icon from resource file
  • Fixed icons in User Action Examples
  • Implemented icon cache and system theme change handling
  • + Konfigurator option to specify a fallback icon theme
  • Switched app icon to Icon
  • Replaced QIcon::hasThemeIcon calls with Icon::exists; refactored icon search
  • Fixed icons on Synchronizer buttons
  • Switched krLoader->loadIcon to Icon in case it's used as QIcon
  • Switched krLoader->loadIcon to Icon in case it's used as QPixmap
  • Switched from KIconLoader to Icon in ActionMan
  • Fixed misuse of FL_LOADICON
  • Replaced FL_LOADICON with FileListIcon::pixmap
  • Replaced SmallIcon with Icon
  • Used KIconLoader in icon search to improve mime icons
  • Icon: improved comments and messages
  • Removed KrGlobal::iconLoader and cleaned up KIconLoader includes
  • Icon: don't apply fallback in case of empty icon name
  • Fixed icon for dragging multiple items between panels
Fri, Apr 13, 7:26 AM · Krusader

Tue, Apr 10

nmel closed D12061: Changed loading of layout.xml from resource system only.
Tue, Apr 10, 5:10 AM · Krusader
nmel closed D11898: Implemented bookmark quick search.
Tue, Apr 10, 4:14 AM · Krusader

Mon, Apr 9

martinkostolny accepted D12061: Changed loading of layout.xml from resource system only.

Thanks, Nikita!

Mon, Apr 9, 10:39 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

Mon, Apr 9, 8:23 PM · Krusader
nmel added a project to D12061: Changed loading of layout.xml from resource system only: Krusader.
Mon, Apr 9, 7:08 AM · Krusader

Sun, Apr 8

martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Maybe we need to use something neutral like circle or diamond... With these missing/unreadable/broken icons the app looks like a broken one while it's not...
Also, I guess we better save a particular image we pick into the resource file, so we can load it for sure. Are you fine with it?

Sun, Apr 8, 9:07 PM · Krusader
martinkostolny accepted D11898: Implemented bookmark quick search.

Same goes for me, sorry for not replying. The patch works as expected :).

Sun, Apr 8, 8:34 PM · Krusader
rade accepted D11898: Implemented bookmark quick search.
Sun, Apr 8, 8:31 PM · Krusader
rade added a comment to D11898: Implemented bookmark quick search.
In D11898#242741, @nmel wrote:

I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage.

Sun, Apr 8, 8:30 PM · Krusader
nmel added a comment to D11898: Implemented bookmark quick search.

I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage.

Sun, Apr 8, 7:50 PM · Krusader
nmel added a comment to D10352: Fix insufficient icon theme issues.

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

Sun, Apr 8, 7:48 PM · Krusader