KrusaderProject
ActivePublic

Recent Activity

Mon, Oct 7

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

Mon, Oct 7, 9:32 PM · Documentation, Krusader
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Mon, Oct 7, 9:31 PM · Documentation, Krusader
asensi requested review of D24480: Change the document about helping Krusader, add other ways (2).
Mon, Oct 7, 9:28 PM · Krusader
asensi added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);
Mon, Oct 7, 9:17 PM · Krusader

Sat, Sep 21

gengisdave closed D23938: Fix warning about macro expansion.
Sat, Sep 21, 3:09 PM · Krusader
gengisdave accepted D24026: Replace explicite type casting with dynamic casts.

Tested Synchronizer, Konfigurator and DiskUsage, no problems found.

Sat, Sep 21, 2:21 PM · Krusader

Tue, Sep 17

abika added a project to D24026: Replace explicite type casting with dynamic casts: Krusader.
Tue, Sep 17, 4:00 PM · Krusader

Mon, Sep 16

abika added a comment to D22932: Remove 'isExiting' logic from closing sequence.

Thanks, Toni and Nikita.

Mon, Sep 16, 2:58 PM · Krusader
Diffusion closed D22932: Remove 'isExiting' logic from closing sequence.
Mon, Sep 16, 2:57 PM · Krusader
abika accepted D23938: Fix warning about macro expansion.

...where !(_job == 0) is not equal to !_job == 0.

Isn't the result always the same?

Mon, Sep 16, 2:30 PM · Krusader

Sep 16 2019

nmel added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

3rd opinion. I agree it should be shown only if the file is actually going to be hidden (Show Hidden is off in settings), otherwise Krusader looks dumb. I agree that users should be able to disable the warning, because for us it may look like an uncommon operation, however some users may work with dot files extensively. This kind of attention to small details make a huge difference in user experience.

Sep 16 2019, 4:24 AM · Krusader

Sep 15 2019

asensi closed D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sep 15 2019, 10:13 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

I agree with you. Thanks Alex and Nikita! (and Moritz :-)

Sep 15 2019, 10:12 PM · Krusader
asensi closed D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.
Sep 15 2019, 9:57 PM · Krusader
asensi added a comment to D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.

Thanks, Alex!

Sep 15 2019, 9:56 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

And thanks Nikita, Alex, and Moritz! (and Yuri :-)

Sep 15 2019, 9:55 PM · Krusader
asensi closed D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sep 15 2019, 9:40 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Code looks good and still works!

Sep 15 2019, 9:39 PM · Krusader
asensi accepted D23912: Respect .hidden files.
Sep 15 2019, 9:36 PM · Krusader
asensi accepted D23924: Add QT::KeyMenu action to search results.
Sep 15 2019, 9:36 PM · Krusader
gengisdave closed D23880: Handle Ctrl+Left/Right not working in brief view.
Sep 15 2019, 8:29 PM · Krusader
abika added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

Sorry, but not being able to have a way to disable the warning message is not acceptable for me. There may be users who do this renaming very often to filter folders in their list view.
Dolphin has the option to disable it, Krusader should have it too.

Sep 15 2019, 6:40 PM · Krusader
yurchor added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
In D15693#531988, @nmel wrote:

@yurchor, could you please update the docs once it's merged?

Sep 15 2019, 6:38 PM · Krusader
nmel accepted D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Works great and the code looks clean and neat! Thanks for working on this.

Sep 15 2019, 6:36 PM · Krusader
abika accepted D23880: Handle Ctrl+Left/Right not working in brief view.

Thanks for fixing the bug i introduces, Davide! Works fine.
These shortcut redirections a damn complicated.

Sep 15 2019, 6:28 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Alex's recommendations were applied in order to ease the reading of the source code (and the changes could be applied quickly :-) ).

Sep 15 2019, 6:20 PM · Krusader
nmel accepted D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

a) Under non-Windows operating systems: The "#ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN" code paths have to work (as they did before this commit), because Q_OS_WIN is not defined there now, nor Q_WS_WIN was defined there previously.
b) Under Windows operating systems is where the behavior has to change (the Q_OS_WIN code paths are aimed to work, because Q_OS_WIN is defined there).

Sep 15 2019, 6:11 PM · Krusader
abika accepted D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.

Didn't test myself. But if you tested it, Toni, adding the two lines should be safe.

Sep 15 2019, 5:35 PM · Krusader
asensi closed D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sep 15 2019, 5:32 PM · Krusader
asensi added a comment to D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 5:30 PM · Krusader
abika accepted D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

I also don't see any problems. Q_WS_WIN was always false before, now Q_OS_WIN is still false under Linux.
And if it compiles now Windows and seems to work, even better.

Sep 15 2019, 5:23 PM · Krusader
asensi closed D23885: Update build status icon.
Sep 15 2019, 5:16 PM · Krusader
abika accepted D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Code looks good and still works!

Sep 15 2019, 5:13 PM · Krusader
asensi added a comment to D23885: Update build status icon.

All right, Davide and Nikita, thanks!

Sep 15 2019, 4:49 PM · Krusader
asensi closed D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.
Sep 15 2019, 4:32 PM · Krusader
asensi added a comment to D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

Note: For the tests that I performed under Kubuntu 18.04, executing dpkg -l showed:
kio 5.44.0-0ubuntu1 amd64 Resource and network access abstraction

Sep 15 2019, 4:30 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 4:21 PM · Krusader
asensi closed D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.
Sep 15 2019, 4:11 PM · Krusader
asensi added a comment to D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 4:00 PM · Krusader
asensi added a comment to D23912: Respect .hidden files.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:44 PM · Krusader
asensi added a comment to D23924: Add QT::KeyMenu action to search results.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:38 PM · Krusader
asensi added a comment to D23880: Handle Ctrl+Left/Right not working in brief view.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:35 PM · Krusader
ltoscano added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I personally think that the original repo could be used, my perfect solution would be a scratch repo. But (this is a big but) the target of this set of patches shouldn't be a normal user but a distro packager, and we must show big warning saying that this does not mean that the developing is active and only trivial patches for critical bugs could be backported; sometime a single-line patch cannot be backported because all the logic around was changed, or the backport does not fix at all or even worse. Also, because the development is closed, no bugs should be reported because the first answer would be "can you try on a newer version?".

Sep 15 2019, 11:34 AM · Krusader, Documentation

Sep 14 2019

gengisdave added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I personally think that the original repo could be used, my perfect solution would be a scratch repo. But (this is a big but) the target of this set of patches shouldn't be a normal user but a distro packager, and we must show big warning saying that this does not mean that the developing is active and only trivial patches for critical bugs could be backported; sometime a single-line patch cannot be backported because all the logic around was changed, or the backport does not fix at all or even worse. Also, because the development is closed, no bugs should be reported because the first answer would be "can you try on a newer version?".

Sep 14 2019, 1:46 PM · Krusader, Documentation
gengisdave requested review of D23938: Fix warning about macro expansion.
Sep 14 2019, 11:29 AM · Krusader
gengisdave closed D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sep 14 2019, 7:54 AM · Krusader
gengisdave added 1 commit(s) for D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance: R167:f66e2a7481f0: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sep 14 2019, 7:54 AM · Krusader

Sep 13 2019

gengisdave added a comment to D23885: Update build status icon.

I don't have write access to the repo, can someone please push? Thanks

Sep 13 2019, 8:53 PM · Krusader
gengisdave requested review of D23924: Add QT::KeyMenu action to search results.
Sep 13 2019, 10:58 AM · Krusader

Sep 12 2019

gengisdave requested review of D23912: Respect .hidden files.
Sep 12 2019, 5:04 PM · Krusader