KrusaderProject
ActivePublic

Recent Activity

Thu, Aug 22

asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

P.S.: Some steps still have to be done, like the ones that Nikita commented "It will be great to have starting steps for each type of work (for example, want to do Bug Triaging - go to the specific bugzilla link showing the list of not triaged bugs and try to repro bugs one by one, and then post your comments in the bugs)" or mentioning that a linked page is in English.

Thu, Aug 22, 9:31 PM · Documentation, Krusader
asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

I suppose that today you have received a "Invitation to participate in a survey" mail from Lydia Pintscher. It reminds of when she wrote in https://phabricator.kde.org/T9581 about Krusader on Windows and "have you thought about using this as an opportunity to recruit someone new? Maybe a blog post or mailing list post asking if there is someone with the will and knowledge to drive this forward?", which has something to do with the subject of the present code review.

Thu, Aug 22, 9:18 PM · Documentation, Krusader
yurchor added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#516348, @nmel wrote:

@yurchor, in any case, the changes to the docs shall be made only in master, since stable is in the doc-freeze mode, correct?

Thu, Aug 22, 6:38 AM · Documentation, Krusader
nmel added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#516339, @pino wrote:

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

https://cgit.kde.org/websites/krusader-org.git/
Just open a review request for that repository (or commit directly), it is not complicated...

Please always open a review! Committed and pushed changes are deployed directly to live site. People make mistakes, it's normal, and reviews reduce the likelihood of a mistake.

Thu, Aug 22, 6:36 AM · Documentation, Krusader
nmel closed D23197: Updated ChangeLog and NEWS with v2.7.2 changes.
Thu, Aug 22, 5:52 AM · Krusader
nmel added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks everyone!

Thu, Aug 22, 5:48 AM · Krusader
yurchor added a comment to D23309: Change the document about helping Krusader, add other ways.

It seems that we need some thoughts from developers on how to proceed.

Thu, Aug 22, 5:25 AM · Documentation, Krusader
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

Thu, Aug 22, 4:47 AM · Documentation, Krusader
yurchor accepted D23309: Change the document about helping Krusader, add other ways.

Yes, Pino is right on the general level. The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs (slowly updates, no translations, etc.). So I'd better leave the things as is. Just my 2 cents.

Thu, Aug 22, 4:36 AM · Documentation, Krusader

Wed, Aug 21

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

Changes that were suggested.

Wed, Aug 21, 9:30 PM · Documentation, Krusader
asensi added inline comments to D23309: Change the document about helping Krusader, add other ways.
Wed, Aug 21, 9:29 PM · Documentation, Krusader
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

Note: There are some reasons why Krusader users have documentation available in their computers, maybe Yuri Chornoivan can give more information about it.

Wed, Aug 21, 7:17 AM · Documentation, Krusader
yurchor accepted D23309: Change the document about helping Krusader, add other ways.

Personally, I think that there will be no harm if we have as many ways to engage new developers as we can.

Wed, Aug 21, 6:39 AM · Documentation, Krusader
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#515717, @pino wrote:

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.

Wed, Aug 21, 6:32 AM · Documentation, Krusader
yurchor accepted D23276: Add more compressed file types to the list of file types that krarc supports.
Wed, Aug 21, 5:19 AM · Krusader
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.
Just like we do not add compilation/build instructions to documentations anymore, IMHO it makes sense to not add contribution instructions either: they are generally not related to "using the application", and thus the old documentation shipped with an old version would show outdated links. Some of the changes in this patch perfectly show this: imagine that users installing krusader in stable distros have outdated links to freshmeat and linux-apps in the documentation they read.

Wed, Aug 21, 5:03 AM · Documentation, Krusader

Tue, Aug 20

asensi updated the diff for D23276: Add more compressed file types to the list of file types that krarc supports.

Some spaces were added, as Yuri suggested.

Tue, Aug 20, 10:01 PM · Krusader
asensi added inline comments to D23276: Add more compressed file types to the list of file types that krarc supports.
Tue, Aug 20, 9:59 PM · Krusader
asensi requested review of D23309: Change the document about helping Krusader, add other ways.
Tue, Aug 20, 9:53 PM · Documentation, Krusader
yurchor added inline comments to D23276: Add more compressed file types to the list of file types that krarc supports.
Tue, Aug 20, 5:34 AM · Krusader

Mon, Aug 19

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

How do you think a person is going to search whether kde4 version of krusader is getting updates? Will she likely go to a search engine and type something like "krusader kde4" where the mentioned repo will be in top positions due to good naming?

Mon, Aug 19, 9:17 PM · Krusader, Documentation
asensi updated the summary of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:07 PM · Krusader
asensi requested review of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:05 PM · Krusader
gengisdave accepted D23236: Updates related to v2.7.2 release.
Mon, Aug 19, 7:44 PM · Krusader
gengisdave accepted D23235: Released v2.7.2.
Mon, Aug 19, 7:43 PM · Krusader
gengisdave accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.
Mon, Aug 19, 7:43 PM · Krusader
nmel added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

I don't think people would find it, Nikita.

Mon, Aug 19, 6:17 AM · Krusader, Documentation

Sun, Aug 18

asensi accepted D23235: Released v2.7.2.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi accepted D23236: Updates related to v2.7.2 release.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

Sun, Aug 18, 8:21 PM · Krusader, Documentation
yurchor accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Accepted for my part. Thanks.

Sun, Aug 18, 8:21 PM · Krusader
asensi accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

For my part, I accept the proposal, Thanks for it, Nikita!

Sun, Aug 18, 7:57 PM · Krusader
asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.

Sun, Aug 18, 7:50 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
In D22957#513827, @nmel wrote:

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 7:41 PM · Krusader
asensi updated the summary of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sun, Aug 18, 7:33 PM · Krusader
asensi updated subscribers of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:24 PM · Krusader
asensi requested review of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:20 PM · Krusader
nmel added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

When I see the usage of the method, like

const float fontWidth = (fm.QFONTMETRICS_WIDTH("WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW") - fm.QFONTMETRICS_WIDTH("W")) / 99.0;

or

headerView->resizeSection(KrViewProperties::Ext, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("tar.bz2  "));
headerView->resizeSection(KrViewProperties::KrPermissions, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("rwx  "));
headerView->resizeSection(KrViewProperties::Size, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("9") * 10);

which are all dirty hacks, I doubt we need to care too much about the differences mentioned. This code needs to be refactored properly but it's not a goal of this change. QFONTMETRICS_WIDTH will actually become a good marker of the places that need review if someone will find time and courage to make it right one day...

Sun, Aug 18, 6:47 AM · Krusader
nmel added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 6:37 AM · Krusader
nmel added a comment to D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.

Good catch, Toni! No objections for the new shortcut. Please look into

  1. Making the commit headline shorter. Something like "Changed shortcut for the embedded terminal emulator". It's easier to read in the graph view. Please keep everything else, it's very good to have a detailed explanation in the commit message!
  2. Specifying CHANGED: tag, so this is not missed in the ChangeLog on the next release.
Sun, Aug 18, 6:30 AM · Krusader
nmel added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I have no problem when someone is trying to improve a dead branch. If the person finds this useful and wants to share their changes to others — he or she is welcome to do so. It's an Open Source after all. In the same time, I understand what Luigi is saying that it might send a wrong signal to users. In addition, commits we push to the official repo are reviewed and tested, and should be only pushed when approved by at least another dev and no objections from others (unfortunately, it's not enforced due to a weak infrastructure). It means someone needs to test the changes you propose in 10 code reviews. Personally, I have no interest in kde4 commits anymore and even have no environment to test it. I doubt you'll find another dev who has.

Sun, Aug 18, 6:21 AM · Krusader, Documentation
nmel added a project to D23236: Updates related to v2.7.2 release: Krusader.

Related review: D23197 (same changelog)

Sun, Aug 18, 5:59 AM · Krusader
nmel added a project to D23235: Released v2.7.2: Krusader.
Sun, Aug 18, 5:56 AM · Krusader

Sat, Aug 17

nmel added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Hi Toni,

Sat, Aug 17, 5:42 AM · Krusader

Fri, Aug 16

asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:

FIXED: [ 328937 ] Shortcuts for move tab
Fri, Aug 16, 8:55 PM · Krusader
nmel edited the content of Release Howto.
Fri, Aug 16, 5:59 AM · Krusader
nmel added a project to D23197: Updated ChangeLog and NEWS with v2.7.2 changes: Krusader.
Fri, Aug 16, 5:38 AM · Krusader

Mon, Aug 12

asensi retitled D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another one for the embedded terminal emulator to Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:53 PM · Krusader
asensi requested review of D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:52 PM · Krusader
asensi closed D22883: Clarify the aim of two lines written recently by David Faure.
Mon, Aug 12, 9:24 PM · Krusader