KrusaderProject
ActivePublic

Recent Activity

Today

asensi accepted D13626: KIso: Fixed file offsets of the underlying IO device.

Thank you all! For my part, using Kubuntu 18.04: my performed tests went alright; some files (inside an iso file) that could not be seen, now can be seen correctly. Other people can do their checks.

Wed, Jun 20, 2:54 PM · Krusader
nmel added a project to D13626: KIso: Fixed file offsets of the underlying IO device: Krusader.
Wed, Jun 20, 7:21 AM · Krusader
nmel added reviewers for D13499: End a quicksearch after an item has been found: abika, martinkostolny, gengisdave, yurchor.

Added more people explicitly - guys, what's your opinion on this subject and do you know if the behavior is changed intentionally or not?

Wed, Jun 20, 7:15 AM · Krusader

Sun, Jun 17

asensi accepted D13572: Panel: Always delete files by their URL.

Note: The tag "Krusader" was added to the present differential revision so that it's seen now at least in https://phabricator.kde.org/project/view/79/ and https://phabricator.kde.org/tag/krusader/ , and consequently more people may review this proposal.

Sun, Jun 17, 1:48 PM · Krusader
asensi added a project to D13572: Panel: Always delete files by their URL: Krusader.
Sun, Jun 17, 1:46 PM · Krusader
asensi abandoned D13497: Files fed to listbox can be deleted.

Nice! There's more information in https://phabricator.kde.org/D13572

Sun, Jun 17, 1:44 PM · Krusader

Thu, Jun 14

asensi added a comment to D13499: End a quicksearch after an item has been found.

Was it changed for a reason?

Thu, Jun 14, 11:20 AM · Krusader
asensi added a comment to D13497: Files fed to listbox can be deleted.

I confirm what Nikita tried.

Thu, Jun 14, 11:08 AM · Krusader
nmel added a comment to D13499: End a quicksearch after an item has been found.

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and
consider implementing an option to keep current behavior.

Mmm... Krusader's behavior was that, after quicksearching a file, when pressing Return (or Enter), the search bar was hidden (like Total Commander or Double Commander) but after Krusader 2.4.0-beta3 the behavior was changed.

Thu, Jun 14, 4:11 AM · Krusader
nmel added a comment to D13497: Files fed to listbox can be deleted.

Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Thu, Jun 14, 3:37 AM · Krusader

Wed, Jun 13

abika requested changes to D13497: Files fed to listbox can be deleted.
Wed, Jun 13, 7:27 PM · Krusader
abika added a comment to D13497: Files fed to listbox can be deleted.

Explanation, as this is my code:
The files()->isRoot() condition is intended. Virtual deletion is only possible when the current directory is the root of vfs:// containing virtual directories. Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Wed, Jun 13, 7:26 PM · Krusader
asensi added a comment to D13497: Files fed to listbox can be deleted.

Also, using Krusader 2.4.0-beta3, when "files fed to list box" are deleted... they are physically deleted.

Wed, Jun 13, 5:00 PM · Krusader
asensi added a comment to D13497: Files fed to listbox can be deleted.

> Removal of items from virtual lists is not a very handful feature after all...

Wed, Jun 13, 10:57 AM · Krusader
nmel closed D13443: Fixed using Numeric Keypad in the quick search mode.
Wed, Jun 13, 10:01 AM · Krusader
asensi added a comment to D13499: End a quicksearch after an item has been found.

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and
consider implementing an option to keep current behavior.

Wed, Jun 13, 9:54 AM · Krusader
nmel added a comment to D13443: Fixed using Numeric Keypad in the quick search mode.

Thanks for testing, Toni!

Wed, Jun 13, 8:24 AM · Krusader
nmel requested changes to D13499: End a quicksearch after an item has been found.

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and consider implementing an option to keep current behavior.
Also, why have you decided to apply only to Search mode? Following the logic regarding Total Commander, it uses Filter mode for its quicksearch. In addition, for Select + F8/Del it might be useful to hide the bar, as there is nothing remain to select, but I'm not sure if it's good in terms of consistency.

Wed, Jun 13, 8:22 AM · Krusader
nmel added a comment to D13497: Files fed to listbox can be deleted.

I might be wrong but I thought the idea was to remove physical files as well.
Removal of items from virtual lists is not a very handful feature after all...
Can somebody comment on this? Thanks in advance.

Wed, Jun 13, 7:48 AM · Krusader

Tue, Jun 12

asensi requested review of D13499: End a quicksearch after an item has been found.
Tue, Jun 12, 6:31 PM · Krusader
yurchor added a comment to D13497: Files fed to listbox can be deleted.

the physical files remained.

Tue, Jun 12, 6:03 PM · Krusader
asensi requested review of D13497: Files fed to listbox can be deleted.
Tue, Jun 12, 5:17 PM · Krusader

Mon, Jun 11

asensi accepted D13443: Fixed using Numeric Keypad in the quick search mode.

Many thanks, Nikita! For my part, my performed tests (using Kubuntu 18.04) went alright.

Mon, Jun 11, 6:50 PM · Krusader

Sat, Jun 9

nmel added a project to D13443: Fixed using Numeric Keypad in the quick search mode: Krusader.
Sat, Jun 9, 6:47 AM · Krusader

Mon, May 28

gengisdave closed D12904: Fixed ugly message dialog on Compare by Content error.
Mon, May 28, 6:28 PM · Krusader
nmel edited the content of Release Howto.
Mon, May 28, 6:44 AM · Krusader
nmel edited the content of Release Howto.
Mon, May 28, 6:12 AM · Krusader
nmel edited the content of Krusader.
Mon, May 28, 6:03 AM · Krusader
nmel created Release Howto.
Mon, May 28, 5:59 AM · Krusader
nmel added a comment to T8761: Synchronizer Rework.

Hi Martin,

Mon, May 28, 5:54 AM · Krusader
nmel added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Please push this.

Mon, May 28, 5:31 AM · Krusader

Tue, May 22

gengisdave added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

I tried to break as less things as possible. I have a little knowledge of i18n but I think that merging the text will require a new strings translation; from my point of view, translations magically appear when I compile. I can put a comment in the final commit to let others to know that it can be refactored.

Tue, May 22, 4:50 AM · Krusader
gengisdave retitled D12904: Fixed ugly message dialog on Compare by Content error from Ugly message dialog on Compare by Content error to Fixed ugly message dialog on Compare by Content error.
Tue, May 22, 4:48 AM · Krusader

May 21 2018

nmel added inline comments to D12904: Fixed ugly message dialog on Compare by Content error.
May 21 2018, 6:30 AM · Krusader

May 20 2018

andreask added a comment to T8761: Synchronizer Rework.

If you need icons let me know

May 20 2018, 8:15 PM · Krusader
abika added a comment to T8761: Synchronizer Rework.

Hi Martin,
yes, I wanted to work on it and did already some refactoring a year ago but never published it. Now I did a fresh rebase and pushed it to synchronizer/rework. Unfortunately I stopped in the middle of the work and the current state is unfinished and not working.

May 20 2018, 7:02 PM · Krusader
martinkostolny added a comment to T8761: Synchronizer Rework.

Alex, I remember You wanted to do that. So if You still want, feel free to work on it :). If not, I'm going to dive in.

May 20 2018, 5:27 PM · Krusader
martinkostolny created T8761: Synchronizer Rework.
May 20 2018, 5:24 PM · Krusader
nmel added a comment to D12906: Unselect all items when calculating occupied space on "..".

Thanks Davide and Toni.

May 20 2018, 3:45 AM · Krusader

May 19 2018

asensi closed D12906: Unselect all items when calculating occupied space on "..".

Thanks! Davide's commit is available for viewing at https://commits.kde.org/krusader/eb60c734b940063f61064c5bcd25ae448b8aa610

May 19 2018, 12:01 PM · Krusader
gengisdave retitled D12906: Unselect all items when calculating occupied space on ".." from Unselect all items when calculating occupied space to Unselect all items when calculating occupied space on "..".
May 19 2018, 9:49 AM · Krusader

May 18 2018

asensi added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Thank you for your interest, Safa. Patches are welcome :-)

May 18 2018, 5:40 PM · Krusader

May 17 2018

safaalfulaij added inline comments to D12904: Fixed ugly message dialog on Compare by Content error.
May 17 2018, 11:16 PM · Krusader
asensi accepted D12906: Unselect all items when calculating occupied space on "..".

For my part, my performed tests went also OK!

May 17 2018, 9:27 PM · Krusader
asensi added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)

May 17 2018, 9:03 PM · Krusader
asensi accepted D12904: Fixed ugly message dialog on Compare by Content error.

For my part, my performed tests went alright!

May 17 2018, 8:54 PM · Krusader
nmel accepted D12906: Unselect all items when calculating occupied space on "..".

Great, it works as expected. Thanks Davide!
BTW, I didn't know about this nice little feature. It is convenient.

May 17 2018, 5:25 AM · Krusader
nmel added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)

May 17 2018, 5:11 AM · Krusader
nmel accepted D12904: Fixed ugly message dialog on Compare by Content error.

Thanks Davide. I'm fine with any of error and sorry.

May 17 2018, 5:07 AM · Krusader

May 16 2018

martinkostolny accepted D12906: Unselect all items when calculating occupied space on "..".

Works as expected. Thanks! :)

May 16 2018, 7:33 PM · Krusader