KrusaderProject
ActivePublic

Recent Activity

Fri, May 12

martinkostolny closed D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename by committing R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item….
Fri, May 12, 10:06 PM · Krusader
martinkostolny updated the diff for D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks for checking on this. I'm using your suggestion because I agree, it should be fixed closest to the source of troubles.

Fri, May 12, 10:06 PM · Krusader
abika added a comment to D5734: Fix lister unintended selection while scrolling.

I usually never user krViewer.

Fri, May 12, 5:32 PM · Krusader
abika accepted D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.

Fri, May 12, 5:20 PM · Krusader

Mon, May 8

martinkostolny added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

And you don't have to do everything we say.

I know :), but this time I really didn't care that much.

Mon, May 8, 7:22 PM · Krusader
martinkostolny closed D5744: Fix loading a panel profile with locked tabs by committing R167:46f05d032be1: Fix loading a panel profile when existing panels are locked..
Mon, May 8, 7:07 PM · Krusader
martinkostolny closed D5735: Do not change clipboard while opening a searched file in KrSearchDialog by committing R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query….
Mon, May 8, 7:07 PM · Krusader
abika accepted D5744: Fix loading a panel profile with locked tabs.

Yes, I can reproduce this. Looks like I solved an issue and created a new one.

Mon, May 8, 5:42 PM · Krusader
abika edited the content of Krusader.
Mon, May 8, 3:39 PM · Krusader
abika edited the content of Krusader.
Mon, May 8, 3:21 PM · Krusader
abika edited the content of Krusader.
Mon, May 8, 3:19 PM · Krusader
abika accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Alex, please check if I understood right the code combining and code comment.

Mon, May 8, 2:42 PM · Krusader
martinkostolny created D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.
Mon, May 8, 1:28 PM · Krusader
martinkostolny updated the diff for D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Thanks for feedback! Here is an update with the option.

Mon, May 8, 9:57 AM · Krusader
martinkostolny updated the diff for D5744: Fix loading a panel profile with locked tabs.

My apologies, Alex, I must have missed your fix otherwise I'd test my workflow right away. Now I see You have fixed most of the issues. I've found only one edge-case. Loading a profile is reusing opened tabs, so if You already have a locked tab, it is locked before openUrl() is called. Here is the minimal exact steps to reproduce it:

  1. start fresh krusader (empty config)
    • we will focus on left panel only for this test
  2. go to e.g. Downloads
  3. save profile (e.g. "p1")
  4. go back to home folder and lock the tab
  5. load profile p1 -> You should see 2 tabs now instead of one
Mon, May 8, 8:42 AM · Krusader

Sun, May 7

abika added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.

Sun, May 7, 10:12 PM · Krusader
asensi accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

This patch is just a proposal to remove this feature and leave user's clipboard alone.

Sun, May 7, 9:57 PM · Krusader
abika added a comment to D5744: Fix loading a panel profile with locked tabs.

When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.

Sun, May 7, 4:51 PM · Krusader
martinkostolny created D5744: Fix loading a panel profile with locked tabs.
Sun, May 7, 4:34 PM · Krusader
martinkostolny created D5735: Do not change clipboard while opening a searched file in KrSearchDialog.
Sun, May 7, 1:14 AM · Krusader
martinkostolny created D5734: Fix lister unintended selection while scrolling.
Sun, May 7, 12:47 AM · Krusader

Apr 12 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

Alex, thanks a lot for making the release and updating the corresponding wiki!

Apr 12 2017, 8:51 PM · Krusader
abika moved T5716: New release: 2.6.0 from TODO to Done on the Krusader board.
Apr 12 2017, 4:37 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

Done. Somebody has to add 2.6.0 to the release list on bugzilla. I still don't have permission.

Apr 12 2017, 4:36 PM · Krusader

Apr 11 2017

abika edited the content of Krusader.
Apr 11 2017, 6:05 PM · Krusader
abika closed D5292: Fix for crash when closing currently refreshing panel.

I took the liberty and commited your patch.

Apr 11 2017, 5:41 PM · Krusader

Apr 9 2017

palant added a comment to T5716: New release: 2.6.0.

After considering "Developer," "Developer (retired)" and "Code contributor" I decided to wait until next release - if I manage to keep contributing :)

Apr 9 2017, 5:50 PM · Krusader
abika updated subscribers of T5716: New release: 2.6.0.

Tomorrow or Tuesday - hopefully.
@palant If you want to be included in the author list, add yourself to the main.cpp.

Apr 9 2017, 5:23 PM · Krusader
abika edited the content of Krusader.
Apr 9 2017, 5:16 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

Apr 9 2017, 4:37 PM · Krusader
janlepper added a comment to T5716: New release: 2.6.0.

Agreed :)

Apr 9 2017, 4:20 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Hmm, I can't update the diff (permissions?)

This is safer:

diff --git a/krusader/Panel/panelfunc.cpp b/krusader/Panel/panelfunc.cpp
index 3f2b184f7..c3dcaff41 100644
--- a/krusader/Panel/panelfunc.cpp
+++ b/krusader/Panel/panelfunc.cpp
@@ -310,11 +310,15 @@ void ListPanelFunc::doRefresh()
 
     // NOTE: this is blocking. Returns false on error or interruption (cancel requested or panel
     // was deleted)
+    QPointer<ListPanel> panelSave = panel;
     const bool refreshed = fileSystemP->refresh(url);
     if (refreshed) {
         // update the history and address bar, as the actual url might differ from the one requested
         history->setCurrentUrl(fileSystemP->currentDirectory());
         panel->setNavigatorUrl(fileSystemP->currentDirectory());
+    } else if (!panelSave) {
+        // panel was deleted while refreshing
+        return;
     }
 
     panel->view->setNameToMakeCurrent(QString());
Apr 9 2017, 3:24 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Hmm, I can't update the diff (permissions?)

Apr 9 2017, 3:12 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for the even later reaction ;)
Well, the QPointer doesn't hurt, but it doesn't fix the problem in this case.
Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

Apr 9 2017, 2:39 PM · Krusader

Apr 8 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I like "Stiff Challenges" very much! Agreed, 2.6.0 version makes more sense.

Apr 8 2017, 6:38 PM · Krusader
martinkostolny added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for my late reaction. Yes, this is nicer and working. Thanks, Alex! To avoid waiting of each other: You do the commit :).

Apr 8 2017, 6:35 PM · Krusader
abika renamed T5716: New release: 2.6.0 from "New release: 2.5.1" to "New release: 2.6.0".
Apr 8 2017, 4:38 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Apr 8 2017, 4:38 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Ok now?

Apr 8 2017, 3:42 PM · Krusader
abika updated the diff for D5292: Fix for crash when closing currently refreshing panel.
  • Fix for crash when closing currently refreshing panel
  • Safer version of "Fix for crash when closing currently refreshing panel" (f01640db)
Apr 8 2017, 3:40 PM · Krusader

Apr 5 2017

abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

The code was ugly, but accessing a deleted object results in undefinefd behaviour.

Apr 5 2017, 9:01 PM · Krusader

Apr 4 2017

janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.
In D5292#99747, @abika wrote:

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

I removed the whole code together with the previous check

if (p && p->func && p->func->files() && !p->func->files()->vfs_canDelete()) {
    connect(p->func->files(), SIGNAL(deleteAllowed()), p, SLOT(deleteLater()));
    p->func->files()->vfs_requestDelete();
    return;

mainly because it doesn't follow the principle of encapsulation in OOP. The panel manager should not have to check the inner state of the filesystem refresh invoked by the panel function object.
This fix is totally fine imo.

Apr 4 2017, 10:12 PM · Krusader
abika accepted D5292: Fix for crash when closing currently refreshing panel.

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

Apr 4 2017, 2:33 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

I'm sorry for the regression.
I assumed this situation (a panel was destroyed while still refreshing) wouldn't occur.
There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.
Asynchronous refresh of course would also fix that problem.

Apr 4 2017, 10:08 AM · Krusader

Apr 3 2017

martinkostolny updated the summary of D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:33 PM · Krusader
martinkostolny created D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:32 PM · Krusader

Mar 31 2017

ltoscano closed D5207: Port kde4_add_app_icon to ecm_add_app_icon by committing R167:e08b0c9bb0f9: Port kde4_add_app_icon to ecm_add_app_icon.
Mar 31 2017, 8:39 PM · Krusader
abika accepted D5207: Port kde4_add_app_icon to ecm_add_app_icon.

Same here: can compile but not test. I guess, its fine.

Mar 31 2017, 7:37 PM · Krusader
ltoscano added a comment to D5207: Port kde4_add_app_icon to ecm_add_app_icon.

Ping?

Mar 31 2017, 3:28 PM · Krusader

Mar 27 2017

ltoscano added a reviewer for D5207: Port kde4_add_app_icon to ecm_add_app_icon: Krusader.
Mar 27 2017, 9:31 PM · Krusader