Modify createSpinBox(...) in order to require a QLabel as an argument,
therefore applying setWhatsThis(toolTip) and setToolTip() to
that QLabel is done automatically (and that step does not have to
be remembered by developers).
Details
Details
- Reviewers
gengisdave - Group Reviewers
Krusader - Maniphest Tasks
- T13133: Konfigurator: Improve management of tooltips and “What's This” help
- Commits
- R167:d1f744a5e26e: Konfigurator: Avoid needing to apply `setWhatsThis()` and `setToolTip()` before…
The test plan of the task defined in Konfigurator: Improve management of tooltips and “What's This” help.
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It this code review is accepted, I'll add similar code but for widgets which are not spinBoxes.
Comment Actions
All fine, but hints are not shown on labels on mouse-over; only context help does (see inline).
| krusader/Konfigurator/konfiguratorpage.cpp | ||
|---|---|---|
| 99 | without label->setToolTop(toolTip); the help will be shown only on item and not on its label, like WhatsThis command does; it's really optional. | |
| krusader/Konfigurator/konfiguratorpage.cpp | ||
|---|---|---|
| 99 | All right, let hints be also shown on labels on mouse-over :-) | |