mchabrecek (Miroslav Chabrecek)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 2 2018, 4:10 PM (42 w, 7 h)
Availability
Available

Recent Activity

Nov 15 2018

mchabrecek committed R167:2df3af6c3d7f: Replaced old connect() with QT5 style. Part 3 (authored by mchabrecek).
Replaced old connect() with QT5 style. Part 3
Nov 15 2018, 10:52 PM
mchabrecek closed D16689: Replaced old connect() with QT5 style. Part 3.
Nov 15 2018, 10:52 PM

Nov 12 2018

mchabrecek added a comment to D16689: Replaced old connect() with QT5 style. Part 3.

Can I push it now to the master?

Nov 12 2018, 10:12 AM
mchabrecek updated the diff for D16689: Replaced old connect() with QT5 style. Part 3.
  • Remove some dynamic casts
Nov 12 2018, 10:10 AM

Nov 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Kindly ping.

Nov 9 2018, 9:16 AM · Krusader

Nov 6 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello All,

Nov 6 2018, 8:07 AM · Krusader
mchabrecek added a reviewer for D16689: Replaced old connect() with QT5 style. Part 3: Krusader.
Nov 6 2018, 7:56 AM

Nov 5 2018

mchabrecek requested review of D16689: Replaced old connect() with QT5 style. Part 3.
Nov 5 2018, 4:52 PM

Nov 1 2018

mchabrecek committed R167:4654ac3bc7dd: Replaced old connect() with QT5 style. Part 2 (authored by mchabrecek).
Replaced old connect() with QT5 style. Part 2
Nov 1 2018, 4:39 PM
mchabrecek closed D16397: Replaced old connect() with QT5 style. Part 2.
Nov 1 2018, 4:39 PM

Oct 29 2018

mchabrecek added a comment to D16397: Replaced old connect() with QT5 style. Part 2.
In D16397#349121, @nmel wrote:

Also, summary is incorrect:

This is just the fist part, more will follow.

Oct 29 2018, 9:10 AM
mchabrecek updated the summary of D16397: Replaced old connect() with QT5 style. Part 2.
Oct 29 2018, 9:07 AM
mchabrecek added a comment to D16397: Replaced old connect() with QT5 style. Part 2.
Oct 29 2018, 9:05 AM
mchabrecek updated the diff for D16397: Replaced old connect() with QT5 style. Part 2.

Fixed missing this pointer in lamba call.

Oct 29 2018, 8:59 AM

Oct 26 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello Guys,

Oct 26 2018, 10:00 AM · Krusader

Oct 24 2018

mchabrecek added a comment to D16397: Replaced old connect() with QT5 style. Part 2.

I have realized now that used lambdas in two ways, with and without this, examples:
connect(new QShortcut(QKeySequence("Ctrl++"), this), &QShortcut::activated, this, [=]() { zoomIn(); });
connect(diskUsage, &DiskUsage::enteringDirectory, [=]() { DiskUsageViewer::slotUpdateStatus(); });

Oct 24 2018, 10:13 AM
mchabrecek requested review of D16397: Replaced old connect() with QT5 style. Part 2.
Oct 24 2018, 9:04 AM

Oct 21 2018

mchabrecek committed R167:65066df6f57d: Replaced old connect() with QT5 style. Part 1 (authored by mchabrecek).
Replaced old connect() with QT5 style. Part 1
Oct 21 2018, 9:46 PM
mchabrecek closed D16223: Replaced old connect() with QT5 style. Part 1.
Oct 21 2018, 9:46 PM · Krusader

Oct 19 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#345641, @nmel wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

Oct 19 2018, 12:37 PM · Krusader

Oct 17 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#344206, @nmel wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

Oct 17 2018, 7:56 AM · Krusader

Oct 16 2018

mchabrecek updated the diff for D16223: Replaced old connect() with QT5 style. Part 1.
  • Fixed spacing
Oct 16 2018, 10:26 AM · Krusader
mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Oct 16 2018, 9:00 AM · Krusader

Oct 15 2018

mchabrecek added a comment to T2966: Code Cleaning.

I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.

Oct 15 2018, 1:43 PM · Krusader
mchabrecek requested review of D16223: Replaced old connect() with QT5 style. Part 1.
Oct 15 2018, 1:04 PM · Krusader

Oct 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Thank you for help,

Oct 9 2018, 9:35 AM · Krusader

Oct 6 2018

mchabrecek placed T2966: Code Cleaning up for grabs.

Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.

Oct 6 2018, 8:20 AM · Krusader

Oct 2 2018

mchabrecek added a member for Krusader: mchabrecek.
Oct 2 2018, 4:25 PM