abika (Alex Bikadorov)
Animal

Projects

Badges

User does not have any badges.
User Since
Jun 20 2016, 6:53 PM (36 w, 6 h)

Recent Activity

Yesterday

abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I wouldn't say this is "overreacting".

  • The security flaw is real. An attacker can probably get root access by exploiting Krusaders root mode
  • Krusader is the only GUI application that comes with an "execute as root" feature that I know of (anything else?). And yes, there is a reason for it.
  • Again: it is still possible to execute Krusader as root. But we are not advertising it anymore. Those who really need this can still create the desktop entry/action.
Mon, Feb 27, 7:54 PM
abika added a comment to D4747: Rework of size/space calculation.

As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.

Mon, Feb 27, 4:31 PM
abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Just found something: in krservices "kdesu" is still defined for tools and never used.

Mon, Feb 27, 4:04 PM
abika accepted D4735: [SECURITY] Do not assume that kdesu is in PATH for user actions.

Thanks!

Mon, Feb 27, 3:54 PM
abika accepted D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.

Ship it!

Mon, Feb 27, 3:44 PM
abika accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Mon, Feb 27, 3:41 PM

Thu, Feb 23

abika added inline comments to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Thu, Feb 23, 8:16 PM
abika created D4750: Entroducing... lazy panels.
Thu, Feb 23, 7:05 PM
abika created D4747: Rework of size/space calculation.
Thu, Feb 23, 4:04 PM
abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Wait, screw that. I mixed up arguments.

Thu, Feb 23, 3:50 PM
abika requested changes to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

TL;DR: I agree with Wladimir and would recommend to remove Krusader root mode altogether because we shouldn't support unsafe usage.

Thu, Feb 23, 3:30 PM

Mon, Feb 20

abika requested review of D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
Mon, Feb 20, 5:43 PM
abika updated the summary of D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
Mon, Feb 20, 5:40 PM
abika added a comment to D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

Ok, coming back to this. I needed some time to re-think it.

Mon, Feb 20, 5:38 PM
abika updated the diff for D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
  • Dialogs: merged "delay" checkbox with "reverser queue" button in copy/move dialogs
  • JobMan: improved coding style and documentation
  • JobMan: run next job not started yet even if queue mode is off
Mon, Feb 20, 5:33 PM

Fri, Feb 17

abika accepted D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.

Thanks, works fine. Question is why Ubuntu is having a different tool doing the same thing.

Fri, Feb 17, 5:48 PM
abika added a comment to D4610: Panel: Do not select .. in a filtered view if there are other entries.

Added a small fix: _count > 0 instead of _count > 1; the dummy file itself is not counted.

Fri, Feb 17, 5:43 PM
abika closed T5372: Adding category for Krusader User actions as "Resolved".

Great! Thanks again for the quick response.

Fri, Feb 17, 3:36 PM · KDE Store

Thu, Feb 16

abika created T5372: Adding category for Krusader User actions.
Thu, Feb 16, 4:25 PM · KDE Store

Wed, Feb 15

abika abandoned D2857: Use KRun for "Open with"->"Other..." dialog.
In D2857#85422, @asensi wrote:

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

Wed, Feb 15, 6:08 PM
abika added a comment to D4610: Panel: Do not select .. in a filtered view if there are other entries.

I don't want to be pedantic but there is a small misbehavior: when the current item is ".." and "Show hidden files" setting is changed (Alt+".") the current jumps to the first file now. Probably nobody will ever notice but checking against empty _quickFilterMask should also solve it.

Wed, Feb 15, 5:30 PM
abika added a comment to D4512: Rework of vfile and KrPermHandler class.

Thank you testing.

I couldn't find any regressions.
seems to work correctly

Wed, Feb 15, 5:01 PM

Tue, Feb 14

abika retitled D4609: Improved integration of (quick) search bar in panel from to Improved integration of (quick) search bar in panel.
Tue, Feb 14, 4:07 PM

Mon, Feb 13

abika closed D4433: #375994 - List kio-extras under dependencies as recommended package.

Merged with master

Mon, Feb 13, 8:56 PM · Krusader
abika accepted D4433: #375994 - List kio-extras under dependencies as recommended package.
Mon, Feb 13, 8:55 PM · Krusader
abika closed D4427: Update "get involved" page to indicate how one can register.

Merged with master

Mon, Feb 13, 8:54 PM · Websites, Krusader
abika closed D4420: #375894 - Use case-insensitive as default for text search.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4418: #314258 - Duplicate tab settings when duplicating tabs.

Merged with master

Mon, Feb 13, 8:54 PM · Krusader
abika closed D4417: #375831 - Sort empty file extensions correctly.

Merged with master (and Phabricator fails again to autoclose this)

Mon, Feb 13, 8:53 PM · Krusader
abika edited the content of Krusader.
Mon, Feb 13, 7:02 PM · Krusader

Fri, Feb 10

abika added a comment to D2857: Use KRun for "Open with"->"Other..." dialog.

I see. Is the working directory really important for (any) application? It seems strange that Krusader does this different compared to e.g. Dolphin.

Fri, Feb 10, 6:03 PM
abika accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Could it be that the issue there was being caused by the extra ListPanel::start() call?

Quick test says: yes!

Fri, Feb 10, 4:16 PM · Krusader

Thu, Feb 9

abika added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Ok, I see now that this is also not a good solution. The settings are going down to the PanelPopup and KrInterviews. All this should be copied. Sorry I didn't got this earlier.

Thu, Feb 9, 8:44 PM · Krusader

Wed, Feb 8

abika retitled D4512: Rework of vfile and KrPermHandler class from to Rework of vfile and KrPermHandler class.
Wed, Feb 8, 8:27 PM
abika accepted D4146: ListPanel: don't go back in history if refresh failed.

I personally prefer the old behavior. After restart going back to the "nearest" parent folder of a deleted path was pretty nice. And if it was a removable device I can mount it and go back to the folder with the history.

Wed, Feb 8, 3:20 PM · Krusader
abika accepted D4420: #375894 - Use case-insensitive as default for text search.

Like I said, I don't really care. In KFind case sensitivity is also off by default.

Wed, Feb 8, 3:02 PM · Krusader

Sat, Feb 4

abika added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Hmm, works fine but using a temporary config group seems a bit hackish.

Sat, Feb 4, 2:13 PM · Krusader
abika added a comment to D4420: #375894 - Use case-insensitive as default for text search.

I personally don't care. Default search with grep is case sensitive. Any other opinions?

Sat, Feb 4, 2:10 PM · Krusader
abika accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Thanks for the fix!

Sat, Feb 4, 2:09 PM · Krusader
abika accepted D4427: Update "get involved" page to indicate how one can register.
Sat, Feb 4, 2:08 PM · Websites, Krusader
abika accepted D4417: #375831 - Sort empty file extensions correctly.
Sat, Feb 4, 2:08 PM · Krusader

Sun, Jan 29

abika added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.
In D4316#81044, @asensi wrote:

About that F11 subject: Is it a change in the user interface of Krusader? :-?

Sun, Jan 29, 2:35 PM

Jan 28 2017

abika added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

Thanks! Merged with master.

Jan 28 2017, 5:43 PM
abika accepted D4195: Changes in the installation documentation (2) - Web pages.

Sorry, missed it again. Changes are fine!

Jan 28 2017, 4:00 PM · Krusader, Websites

Jan 27 2017

abika retitled D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories from to Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.
Jan 27 2017, 6:19 PM

Jan 25 2017

abika edited the content of Krusader.
Jan 25 2017, 6:48 PM · Krusader

Jan 20 2017

abika edited the content of Krusader.
Jan 20 2017, 8:00 PM · Krusader

Jan 18 2017

abika edited the content of Krusader.
Jan 18 2017, 4:24 PM · Krusader

Jan 17 2017

abika added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

I would not recommend the information of that page, a line like

su -c "make install"

won't work for Debian/Mint/Ubuntu/Kubuntu/etc. users.

Jan 17 2017, 8:58 PM · Krusader, Websites
abika added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

The idea was to follow the Krusader handbook style (in docs.kde.org) to put out a big warning, in this case: "do not follow the next outdated information, it will cause you problems", "follow the linked file" :-)

Jan 17 2017, 3:52 PM · Krusader, Websites

Jan 16 2017

abika updated the diff for D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
  • Dialogs: merged "delay" checkbox with "reverser queue" button in copy/move dialogs
Jan 16 2017, 6:00 PM
abika requested changes to D4008: A warning note, like the formerly used ones, was added to the installation section. .

Hmm, sorry I don't think the different style fits to the rest of the page. There are already a lot of Note:s . We should change all of them. But why a single (big) one with different style?

Jan 16 2017, 2:46 PM · Krusader, Websites

Jan 15 2017

abika added a comment to D3994: add asynchronous vfs refresh.

I'm actually unsure if there is any benefit for a "real" async refresh. The panel currently depends on it and the Qt event loop prevents an UI freeze during a long refresh.

Jan 15 2017, 9:45 PM · Krusader
abika added a comment to T5057: Check usage of QDir::setCurrent().

I have no idea why the directory change is there in the code or why it could be important. Maybe remove it and see what happens(?)

Jan 15 2017, 9:41 PM · Krusader

Jan 11 2017

abika added a comment to T5062: Improve search results tab.

Great! Nice feature. Is that KWrite from KParts?

Jan 11 2017, 5:30 PM · Krusader
abika closed D4071: Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode)..

Merged with master.

Jan 11 2017, 5:20 PM

Jan 10 2017

abika updated subscribers of D4071: Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode)..
Jan 10 2017, 2:58 PM
abika retitled D4071: Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode). from to Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode)..
Jan 10 2017, 2:54 PM

Jan 7 2017

abika added a comment to T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook.

Sorry Tonny. It just happened that we worked on it at the same time.

Jan 7 2017, 8:39 PM · Krusader
abika added a comment to T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook.

... or better: I already did. Check the website.

Jan 7 2017, 6:20 PM · Krusader
abika added a comment to T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook.

I'm currently doing this :/

Jan 7 2017, 6:20 PM · Krusader

Jan 4 2017

abika edited the content of Krusader.
Jan 4 2017, 4:32 PM · Krusader
abika closed D3938: VFS: cleaner code for refresh check on vfs operation without current directory.

And sorry for the terrible long commit messages. arc is still driving me nuts. Automatic merge and commit messages I totally don't want but somehow no automatic differential closing with --merge.

Jan 4 2017, 3:39 PM

Jan 3 2017

abika added a comment to T4993: Fix links in website footer.

If you think everything is resolved please close this.

Jan 3 2017, 8:48 PM · Krusader
abika added a comment to T3419: Rework of VFS.

Oh, the job creation in vfs::calcSpaceKIO() is working now! I could swear that there was an Qt error message the last time I tried, saying something about not being able to create an QObject with a parent in a different thread.

Jan 3 2017, 8:41 PM · Krusader
abika updated D3938: VFS: cleaner code for refresh check on vfs operation without current directory.
Jan 3 2017, 7:45 PM
abika retitled D3938: VFS: cleaner code for refresh check on vfs operation without current directory from to VFS: cleaner code for refresh check on vfs operation without current directory.
Jan 3 2017, 7:37 PM

Dec 29 2016

abika added a comment to T4993: Fix links in website footer.
  • projects.kde.org (actually links to kde.org/.../krusader, text should probably be different since projects went away)

Replaced with Phabricator link

Done

  • kde-files.org (should go to store.kde.org somewhere)

Removed. Krusader is not (yet?) included in the KDE store.

  • donate (this one's ok)

Removed. People should better donate to KDE e.v. instead.

Dec 29 2016, 7:08 PM · Krusader
abika accepted D3855: Add .reviewboardrc and .arcconfig.

Ship it!

Dec 29 2016, 6:37 PM
abika accepted D3856: Add includes..

Cannot test on BSD, but I guess its fine.

Dec 29 2016, 6:05 PM

Dec 14 2016

abika added a comment to T3419: Rework of VFS.

I noticed a minor issue with the toolbar. Since I don't use toolbars very often, I tried to move the Job toolbar to the bottom of the window, but after I restarted Krusader it was always at the top again. I noticed the same behavior with the Main toolbar, so it might be due to KXMLGuiWindow.

Dec 14 2016, 7:07 PM · Krusader

Dec 10 2016

abika added a comment to T3419: Rework of VFS.
Dec 10 2016, 5:07 PM · Krusader

Dec 6 2016

abika added a comment to D3536: Re-add F2 Queue button to copy dialog.

I'm sorry but I really think this is way too complicated now. We have 4 variables which have influence on the job behaviour:

Dec 6 2016, 9:14 PM · Krusader
abika retitled D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay. from to Rework of job start behaviour. With new field for forcing enqueue, start or delay..
Dec 6 2016, 9:03 PM
abika added a comment to T3419: Rework of VFS.

Operations started with drag&drop will (potentially) be manageable with KF5.30

Dec 6 2016, 2:19 PM · Krusader

Dec 5 2016

abika added a comment to D3536: Re-add F2 Queue button to copy dialog.

There is one problem I just noticed now for a special use:

  1. activate QueueMode
  2. create several jobs -> first is started all others are pending
  3. deactivate QueueMode
Dec 5 2016, 6:21 PM · Krusader

Dec 4 2016

abika accepted D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol.

Ship it!

Dec 4 2016, 6:25 PM · Krusader
abika accepted D3429: Browse Archives As Folders option applied to iso files.

Ship it!

Dec 4 2016, 6:06 PM · Krusader

Dec 1 2016

abika accepted D3536: Re-add F2 Queue button to copy dialog.

I will propose some changes. But for simplification just merge it first.

Dec 1 2016, 5:07 PM · Krusader

Nov 30 2016

abika added a comment to D3536: Re-add F2 Queue button to copy dialog.

"F2 in parallel" doesn't do anything different if no jobs are currently running

That's true. Maybe it should be renamed to "F2 Run Immediately"?

Nov 30 2016, 2:41 PM · Krusader

Nov 29 2016

abika added a comment to D3536: Re-add F2 Queue button to copy dialog.

To be honest, I have my problems with this.

Nov 29 2016, 4:33 PM · Krusader

Nov 26 2016

abika added a comment to T3419: Rework of VFS.

Merged with master

Nov 26 2016, 4:44 PM · Krusader

Nov 25 2016

abika added a comment to T3419: Rework of VFS.

So every job added with the checkbox checked has to be unpaused manually to perform.

Not necessarily. If queue mode is turned on it will be started automatically once it is the next job in line.

Nov 25 2016, 7:58 PM · Krusader

Nov 23 2016

abika added a comment to T3419: Rework of VFS.

Maybe for clarification:

  • start job with "Enqueue" -> Job is always created in pause mode
  • start job without "Enqueue" but "Queue Mode" is on -> Job is started only if no other job is running
  • start job without "Enqueue" and "Queue Mode" is off -> Job is always started
Nov 23 2016, 7:34 PM · Krusader

Nov 21 2016

abika added a comment to D3394: [vfs_rework] Do not forcibly focus to just refreshed listpanel.

Thanks guys! Its always a big motivation to hear some nice words:)

Nov 21 2016, 5:20 PM · Krusader
abika added a comment to T3419: Rework of VFS.

Some changes again. Please see commit messages.

Nov 21 2016, 5:18 PM · Krusader

Nov 20 2016

abika added a comment to T3419: Rework of VFS.

More improvements for the job manager:

  • you were right about the "Pause" mode. I just removed it and instead of the clumsy combo box there is now a simple toggle button. (Adding a default configuration setting for the job mode is TODO)
  • I had to add a wrapper class for KIO::Jobs again. But now the queue mode is really working (or better: ready for testing)!
Nov 20 2016, 9:12 PM · Krusader
abika added a comment to T2966: Code Cleaning.

If somebody has too much free time (I don't :) I suggest replacing all connect() lines with the new signal/slot syntax in Qt5. Details: https://wiki.qt.io/New_Signal_Slot_Syntax

Nov 20 2016, 8:36 PM · Krusader
abika added a comment to D3394: [vfs_rework] Do not forcibly focus to just refreshed listpanel.

Thanks for finding the cause! But because it is caused by the search bar it should be fixed by the search bar imo.
I already pushed a fix to master.

Nov 20 2016, 8:29 PM · Krusader
abika added a comment to D2603: Add advanced debugging to KIso.

What distro do you have? I'll dive into KIO to see where the problem is.

Nov 20 2016, 6:46 PM · Krusader
abika added a comment to D2603: Add advanced debugging to KIso.

vfs_rework does not touch iso or krarc itself. But opening iso files with relative symlinks in path works just fine for me - in master and vfs_rework(!?).

Nov 20 2016, 4:35 PM · Krusader

Nov 15 2016

abika added a comment to T3419: Rework of VFS.

About the KIO password problem: it is not the case with visible passwords. I got lucky and found the cause of my problem by comparing vfs_rework and master code - see D3360. Magic. At least for me.

Nov 15 2016, 7:18 PM · Krusader
abika accepted D3360: [vfs_rework] Fix re-asking password with some remote connections.

Thanks, thanks, thanks!

Nov 15 2016, 7:04 PM · Krusader

Nov 14 2016

abika added a comment to T3419: Rework of VFS.
  1. Sometimes I can still see numbers below 100% next to successfully finished jobs (see screenshot below).
  2. Deleted item has "-" instead of its location displayed in overview (see screenshot below).
Nov 14 2016, 7:27 PM · Krusader

Nov 13 2016

abika retitled D3353: Some fixes and simpifying startup settings. from to Some fixes and simpifying startup settings..
Nov 13 2016, 5:52 PM

Nov 9 2016

abika added a comment to T3419: Rework of VFS.
  • when right-clicking on toolbar -> Toolbar Settings... I am unable to actually configure the new Job Toolbar; Job Toolbar is therefore always empty.
Nov 9 2016, 8:21 PM · Krusader
abika edited the content of Krusader.
Nov 9 2016, 6:58 PM · Krusader
abika edited the content of Krusader.
Nov 9 2016, 6:51 PM · Krusader
abika edited the content of Krusader.
Nov 9 2016, 6:45 PM · Krusader