- User Since
- Jun 20 2016, 6:53 PM (104 w, 1 d)
Sat, Jun 16
Wed, Jun 13
Explanation, as this is my code:
The files()->isRoot() condition is intended. Virtual deletion is only possible when the current directory is the root of vfs:// containing virtual directories. Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.
May 20 2018
Please see commit message. If not stated, the functionality/behaviour should not have changed.
yes, I wanted to work on it and did already some refactoring a year ago but never published it. Now I did a fresh rebase and pushed it to synchronizer/rework. Unfortunately I stopped in the middle of the work and the current state is unfinished and not working.
Thanks everybody! I changed the shortcut for "select in folder" to CTRL+SHIFT+S before pushing.
May 12 2018
Oh, yes of course. I initially introduced the combobox for the "start on typing" feature and its obviously still valid for this.
Thanks for pointing this out, diff is adjusted.
- Use default search bar search mode setting always on "start by typing"
May 1 2018
Discussed here: https://bugs.kde.org/show_bug.cgi?id=391946
Apr 9 2018
Thanks for testing and review!
Apr 2 2018
Thanks for testing!
I thought I tested the first behaviour. But probably did changes after that :/
And the second one is strange, don't know exactly why the current is lost only in this particular case.
- Panel: Fix current item not selected when going back in history
- Panel: Fix lost current if the previous item is removed
Mar 31 2018
Oh, fu... this seems to be a replacement for D11699. Didn't see this first, i just get too many mails recently.
Jan 23 2018
I pushed a new branch arcpatch-D9041 with Diff 24441 and the patch file. Merging was not that trivial.
And I already made some fixes but its not done yet (and uncommited).
Jan 21 2018
As I understand it, the problem is that plugins installed to PREFIX/lib/qt/plugins won't always be be found depending on PREFIX.
It will work for "/usr" and probably "/usr/local" (can you confirm the latter, Martin? I didn't test it).
But if I install e.g. to a directory in the Krusader source directory (a quick local installation for testing) the plugins won't work. And this will may be left unnoticed by the user.
Nov 29 2017
And I can confirm the crash in Synchronizer. The checkbox useIgnoredPaths is not initialized here. Should be set to nullptr and checked for it before access. (Crash is in generalFilter.cpp line 547).
Thanks for your contribution! Excluding by folder names is a good idea and very useful.
However, having the string definitions in the configuration settings doesn't feel "right" for me. There is now a checkbox in the search dialog, but the actual folders can only be set in another dialog far away.
Why not combining both, e.g. with a KHistoryComboBox (the main "Search for: " edit line is an example) in the search dialog? This way you have only one GUI element, you can quickly edit it, or clear it, and you have even a history.
Sep 17 2017
Aug 5 2017
Sorry, toke me some time. I corrected a typo in one of the BUG: references. Thanks for the patch!
Jul 29 2017
Merged to make Albert happy (https://marc.info/?l=kde-devel&m=150096948115456&w=2).
Jul 22 2017
Jul 17 2017
- Please use Bugzilla and not Phabricator for bugs and feature requests, like stated here: https://krusader.org/report-bugs/index.html
- Krusader 2.4 is outdated. Please try again with 2.5/2.6
- Information is missing about what you are actually doing while getting the error messages. Browsing facebook with Krusader?
Jul 11 2017
Merged. Thanks for the patch!
Jul 6 2017
I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5
Jul 4 2017
is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.
Jul 3 2017
Jul 2 2017
@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).
Jun 5 2017
Finally mark this done.
Jun 3 2017
Merged. Let's see if somebody will complain...
May 31 2017
May 29 2017
May 14 2017
File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks.
May 12 2017
I usually never user krViewer.
Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.
May 10 2017
Thanks Martin! Not a surprise I missed something again during testing:/
May 8 2017
Thanks for the info. Problem is I can't switch to GCC4.8 (not even an official package in Arch Linux repos) and the CI doesn't cover this either.
Yes, I can reproduce this. Looks like I solved an issue and created a new one.
Alex, please check if I understood right the code combining and code comment.
May 7 2017
I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.
When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.
Oh damn, I overlooked this again. The title lead me to believe this is something unimportant in kde-devel.
Apr 23 2017
Apr 18 2017
Apr 12 2017
Done. Somebody has to add 2.6.0 to the release list on bugzilla. I still don't have permission.
Apr 11 2017
I took the liberty and commited your patch.
Apr 9 2017
Tomorrow or Tuesday - hopefully.
@palant If you want to be included in the author list, add yourself to the main.cpp.
Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.
Apr 8 2017
- Fix for crash when closing currently refreshing panel
- Safer version of "Fix for crash when closing currently refreshing panel" (f01640db)
Apr 5 2017
The code was ugly, but accessing a deleted object results in undefinefd behaviour.
Apr 4 2017
There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.
Mar 31 2017
Can someone please give an opinion on this?
Same here: can compile but not test. I guess, its fine.
Mar 24 2017
Mar 20 2017
Mar 16 2017
Done with 5a26343a.
Thanks for pointing this out! It's my code so I will fix it right away.
Mar 14 2017
Mar 12 2017
Mar 9 2017
Actually, there are some not so far away: KDE Partition Manager, K3b and KFloppy.
Mar 1 2017
Feb 27 2017
I wouldn't say this is "overreacting".
- The security flaw is real. An attacker can probably get root access by exploiting Krusaders root mode
- Krusader is the only GUI application that comes with an "execute as root" feature that I know of (anything else?). And yes, there is a reason for it.
- Again: it is still possible to execute Krusader as root. But we are not advertising it anymore. Those who really need this can still create the desktop entry/action.
As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.
Just found something: in krservices "kdesu" is still defined for tools and never used.
Feb 23 2017
Wait, screw that. I mixed up arguments.
TL;DR: I agree with Wladimir and would recommend to remove Krusader root mode altogether because we shouldn't support unsafe usage.
Feb 20 2017
Ok, coming back to this. I needed some time to re-think it.
- Dialogs: merged "delay" checkbox with "reverser queue" button in copy/move dialogs
- JobMan: improved coding style and documentation
- JobMan: run next job not started yet even if queue mode is off
Feb 17 2017
Thanks, works fine. Question is why Ubuntu is having a different tool doing the same thing.
Added a small fix: _count > 0 instead of _count > 1; the dummy file itself is not counted.