Good improvement in my opinion!
My test results:

• The CTRL+SHIFT+UP/DOWN shortcuts work perfectly. Only when unfocusing the navigation bar a second time, the edit mode stays on. It might be a widget problem, but i consider it minor and it happened also before this patch.
• Then i set CTRL+UP/DOWN as alternative shortcuts for the same actions to see if this can be used for backwards compatibility: This does not work when trying to unfocusing the navigation bar, the embedded terminal or the command line. All these widgets are capturing the key press and the shortcut action is not activated.

Thanks for the fix Davide! This was also annoying me a lot.

Thanks Toni. Works as expected.
But i still would recommend to either use btnCompareDirs->setFocus(); directly instead, or to add a short comment that syncList is focused to have the compare dirs button (which is set as default) being executed on pressing "Enter".
Otherwise it is a bit confusing why the empty tree widget is focused.

I removed the two added brackets again.

• fixup! Add Kompare as compare application with KIO support

[Got finally some time for Krusader again:)]

• fixup! Add Kompare as compare application with KIO support

Hi Toni,

Thanks, Toni and Nikita.

...where !(_job == 0) is not equal to !_job == 0.

Isn't the result always the same?

Sorry, but not being able to have a way to disable the warning message is not acceptable for me. There may be users who do this renaming very often to filter folders in their list view.
Dolphin has the option to disable it, Krusader should have it too.

Thanks for fixing the bug i introduces, Davide! Works fine.
These shortcut redirections a damn complicated.

Didn't test myself. But if you tested it, Toni, adding the two lines should be safe.

I also don't see any problems. Q_WS_WIN was always false before, now Q_OS_WIN is still false under Linux.
And if it compiles now Windows and seems to work, even better.

Code looks good and still works!

I'm unsure about this. In contrast to Dolphin the target audience of Krusader are more advanced users. We should have more confidence in them imo. On the other hand a confirmation doesn't hurt...

Okay, I'm not against adding comments:)

Ah, FileItem::isDir() can also return true for symlinks. Thanks again for fixing the bug i introduced, Toni!

Hmm, when looking at my commit I cannot say what caused setting the "current" item before.
Anyway, thanks for fixing Toni!

Thanks for testing again!

@mporterfield I merged D22174, please close this review.
BTW: I didn't want to "steal" your fix. I just think it's better to have a solution making the code cleaner for the future.

Thanks for testing everyone!

Sorry for the very long delay.
I tested this but unfortunately there is still the same faulty behaviour.
The first resize event for me has the size
(1019, 651)
the second one the correct (1920, 1019). But e->oldSize().width() is returning 100 here so the computation is still wrong.

@gengisdave : A comment would be nice. Thanks.

Looks good. Thanks for the improvement!

Thanks Nikita! Changes applied and pushed into maste.

• fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)

After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.

Discarded in favour of D20373.

Thanks! Landed (Hope this revision will close itself).

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

• SQUASH_ME Panel: Create new local text files directly with QFile

Thanks for the reviews!

Thanks for the review!

Thanks. Working fine.

Thanks!

Please check again.

• Panel: Simplify handling escape key to close search bar when panel is focused

Please get rid of the dynamic casts. Everything else is fine. Thanks!

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Thanks Yuri! That should have not been included in here.

• fixup! Automatic code linting using clang-tidy.

Hi Miro,

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Hi Lydia and everyone else,

pushed. Forgot to include the link to this Diff in the commit message:/

Oh, sorry. Yes, this was lost.
But simply add to the documentation what you think is importance. The wiki is a collaboration tool with edit history for us developers and users No need to ask for permission imo.

Sry, I know not more than https://www.startpage.com/do/search?q=python+kio. You should ask on kde-devel@kde.org.

Tell me this - can other command line applications interact with stash:// ?

Took some time but now its in master.

Explanation, as this is my code:
The files()->isRoot() condition is intended. Virtual deletion is only possible when the current directory is the root of vfs:// containing virtual directories. Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Please see commit message. If not stated, the functionality/behaviour should not have changed.

Hi Martin,
yes, I wanted to work on it and did already some refactoring a year ago but never published it. Now I did a fresh rebase and pushed it to synchronizer/rework. Unfortunately I stopped in the middle of the work and the current state is unfinished and not working.

Thanks everybody! I changed the shortcut for "select in folder" to CTRL+SHIFT+S before pushing.

Oh, yes of course. I initially introduced the combobox for the "start on typing" feature and its obviously still valid for this.
Thanks for pointing this out, diff is adjusted.

• Use default search bar search mode setting always on "start by typing"

Discussed here: https://bugs.kde.org/show_bug.cgi?id=391946

Thanks for testing and review!

Thanks for testing!
I thought I tested the first behaviour. But probably did changes after that :/
And the second one is strange, don't know exactly why the current is lost only in this particular case.

• Panel: Fix current item not selected when going back in history
• Panel: Fix lost current if the previous item is removed

Oh, fu... this seems to be a replacement for D11699. Didn't see this first, i just get too many mails recently.

I pushed a new branch arcpatch-D9041 with Diff 24441 and the patch file. Merging was not that trivial.
And I already made some fixes but its not done yet (and uncommited).

As I understand it, the problem is that plugins installed to PREFIX/lib/qt/plugins won't always be be found depending on PREFIX.
It will work for "/usr" and probably "/usr/local" (can you confirm the latter, Martin? I didn't test it).
But if I install e.g. to a directory in the Krusader source directory (a quick local installation for testing) the plugins won't work. And this will may be left unnoticed by the user.

And I can confirm the crash in Synchronizer. The checkbox useIgnoredPaths is not initialized here. Should be set to nullptr and checked for it before access. (Crash is in generalFilter.cpp line 547).

Thanks for your contribution! Excluding by folder names is a good idea and very useful.
However, having the string definitions in the configuration settings doesn't feel "right" for me. There is now a checkbox in the search dialog, but the actual folders can only be set in another dialog far away.
Why not combining both, e.g. with a KHistoryComboBox (the main "Search for: " edit line is an example) in the search dialog? This way you have only one GUI element, you can quickly edit it, or clear it, and you have even a history.