abika (Alex Bikadorov)
Animal

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2016, 6:53 PM (65 w, 5 d)
Availability
Available

Recent Activity

Sun, Sep 17

abika edited the content of Krusader.
Sun, Sep 17, 6:22 PM · Krusader
abika edited the content of Krusader.
Sun, Sep 17, 3:13 PM · Krusader
abika edited the content of Krusader.
Sun, Sep 17, 3:08 PM · Krusader
abika edited the content of Krusader.
Sun, Sep 17, 3:08 PM · Krusader

Aug 5 2017

abika added a comment to D6850: KrViewer looses focus - fixed.

Sorry, toke me some time. I corrected a typo in one of the BUG: references. Thanks for the patch!

Aug 5 2017, 6:16 PM · Krusader

Jul 29 2017

abika added a comment to D3491: Fix compile warning in krArc.

Merged to make Albert happy (https://marc.info/?l=kde-devel&m=150096948115456&w=2).

Jul 29 2017, 6:19 PM · Krusader

Jul 22 2017

abika accepted D6788: Resolves T1971 with no further code changes.

Good!

Jul 22 2017, 5:06 PM

Jul 17 2017

abika closed T6514: kio_thumbnail errors as Invalid.
  1. Please use Bugzilla and not Phabricator for bugs and feature requests, like stated here: https://krusader.org/report-bugs/index.html
  2. Krusader 2.4 is outdated. Please try again with 2.5/2.6
  3. Information is missing about what you are actually doing while getting the error messages. Browsing facebook with Krusader?
Jul 17 2017, 5:58 PM · Krusader

Jul 11 2017

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Merged. Thanks for the patch!

Jul 11 2017, 8:18 PM · Krusader

Jul 6 2017

abika moved T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) from TODO to In progress on the Krusader board.
Jul 6 2017, 6:13 PM · Krusader
abika accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

Jul 6 2017, 6:06 PM · Krusader

Jul 4 2017

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

Jul 4 2017, 7:08 PM · Krusader

Jul 3 2017

abika added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 3 2017, 6:48 PM · Krusader

Jul 2 2017

abika added a comment to T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).

Jul 2 2017, 4:13 PM · Krusader

Jun 5 2017

abika moved T3419: Rework of VFS (Now: FileSystem) from In progress to Done on the Krusader board.

Finally mark this done.

Jun 5 2017, 2:58 PM · Krusader
abika renamed T3419: Rework of VFS (Now: FileSystem) from Rework of VFS to Rework of VFS (Now: FileSystem).
Jun 5 2017, 2:58 PM · Krusader

Jun 3 2017

abika edited the content of Krusader.
Jun 3 2017, 2:30 PM · Krusader
abika added a comment to D6010: Changes/Fixes for tab labels.

Merged. Let's see if somebody will complain...

Jun 3 2017, 1:45 PM

May 31 2017

abika created T6237: Replace virtual:/ protocol with KIO-Stash.
May 31 2017, 5:18 PM · Krusader

May 29 2017

abika created D6010: Changes/Fixes for tab labels.
May 29 2017, 12:06 PM

May 14 2017

abika added a comment to D4552: [PreviewJob] Remove maximum size for local files by default.

File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks.

May 14 2017, 2:14 PM · Frameworks

May 12 2017

abika added a comment to D5734: Fix lister unintended selection while scrolling.

I usually never user krViewer.

May 12 2017, 5:32 PM · Krusader
abika accepted D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.

May 12 2017, 5:20 PM · Krusader

May 10 2017

abika added a comment to D5776: Show a lock icon for Locked tabs.

Thanks Martin! Not a surprise I missed something again during testing:/

May 10 2017, 6:38 PM

May 8 2017

abika added a comment to D5714: Fix build with gcc 4.8.

Thanks for the info. Problem is I can't switch to GCC4.8 (not even an official package in Arch Linux repos) and the CI doesn't cover this either.

May 8 2017, 6:23 PM
abika updated the summary of D5776: Show a lock icon for Locked tabs.
May 8 2017, 5:52 PM
abika created D5776: Show a lock icon for Locked tabs.
May 8 2017, 5:48 PM
abika accepted D5744: Fix loading a panel profile with locked tabs.

Yes, I can reproduce this. Looks like I solved an issue and created a new one.

May 8 2017, 5:42 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:39 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:21 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:19 PM · Krusader
abika accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Alex, please check if I understood right the code combining and code comment.

May 8 2017, 2:42 PM · Krusader

May 7 2017

abika added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.

May 7 2017, 10:12 PM · Krusader
abika added a comment to D5744: Fix loading a panel profile with locked tabs.

When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.

May 7 2017, 4:51 PM · Krusader
abika added a comment to D5714: Fix build with gcc 4.8.

Oh damn, I overlooked this again. The title lead me to believe this is something unimportant in kde-devel.

May 7 2017, 3:35 PM

Apr 23 2017

abika added a comment to D5493: New detailed tooltip for name column in panel view.

Thanks Martin!

Apr 23 2017, 4:55 PM

Apr 18 2017

abika updated the test plan for D5493: New detailed tooltip for name column in panel view.
Apr 18 2017, 2:19 PM
abika updated the summary of D5493: New detailed tooltip for name column in panel view.
Apr 18 2017, 2:17 PM
abika created D5493: New detailed tooltip for name column in panel view.
Apr 18 2017, 2:10 PM

Apr 12 2017

abika moved T5716: New release: 2.6.0 from TODO to Done on the Krusader board.
Apr 12 2017, 4:37 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

Done. Somebody has to add 2.6.0 to the release list on bugzilla. I still don't have permission.

Apr 12 2017, 4:36 PM · Krusader

Apr 11 2017

abika edited the content of Krusader.
Apr 11 2017, 6:05 PM · Krusader
abika closed D5292: Fix for crash when closing currently refreshing panel.

I took the liberty and commited your patch.

Apr 11 2017, 5:41 PM · Krusader

Apr 9 2017

abika updated subscribers of T5716: New release: 2.6.0.

Tomorrow or Tuesday - hopefully.
@palant If you want to be included in the author list, add yourself to the main.cpp.

Apr 9 2017, 5:23 PM · Krusader
abika edited the content of Krusader.
Apr 9 2017, 5:16 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

Apr 9 2017, 4:37 PM · Krusader

Apr 8 2017

abika renamed T5716: New release: 2.6.0 from New release: 2.5.1 to New release: 2.6.0.
Apr 8 2017, 4:38 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Apr 8 2017, 4:38 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Ok now?

Apr 8 2017, 3:42 PM · Krusader
abika updated the diff for D5292: Fix for crash when closing currently refreshing panel.
  • Fix for crash when closing currently refreshing panel
  • Safer version of "Fix for crash when closing currently refreshing panel" (f01640db)
Apr 8 2017, 3:40 PM · Krusader

Apr 5 2017

abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

The code was ugly, but accessing a deleted object results in undefinefd behaviour.

Apr 5 2017, 9:01 PM · Krusader

Apr 4 2017

abika accepted D5292: Fix for crash when closing currently refreshing panel.

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

Apr 4 2017, 2:33 PM · Krusader

Mar 31 2017

abika added a comment to D5165: Avoiding root mode.

Can someone please give an opinion on this?

Mar 31 2017, 7:57 PM
abika accepted D5207: Port kde4_add_app_icon to ecm_add_app_icon.

Same here: can compile but not test. I guess, its fine.

Mar 31 2017, 7:37 PM · Krusader

Mar 24 2017

abika created D5165: Avoiding root mode.
Mar 24 2017, 3:02 PM

Mar 20 2017

abika created T5716: New release: 2.6.0.
Mar 20 2017, 10:10 PM · Krusader

Mar 16 2017

abika closed T5673: Fix unsafe lambda usage as Resolved.

Done with 5a26343a.

Mar 16 2017, 12:06 PM · Krusader
abika added a comment to T5673: Fix unsafe lambda usage.

Thanks for pointing this out! It's my code so I will fix it right away.

Mar 16 2017, 11:53 AM · Krusader

Mar 14 2017

abika added a comment to D4994: Rework of checksum dialogs..

Thanks! Typos fixed

Mar 14 2017, 8:33 PM

Mar 12 2017

abika edited the content of Krusader.
Mar 12 2017, 8:11 PM · Krusader

Mar 9 2017

abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Actually, there are some not so far away: KDE Partition Manager, K3b and KFloppy.

Mar 9 2017, 7:12 PM
abika created D4994: Rework of checksum dialogs..
Mar 9 2017, 6:41 PM

Mar 1 2017

abika added a comment to D4146: ListPanel: don't go back in history if refresh failed.

FYI: https://bugs.kde.org/show_bug.cgi?id=298292

Mar 1 2017, 7:00 PM · Krusader

Feb 27 2017

abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I wouldn't say this is "overreacting".

  • The security flaw is real. An attacker can probably get root access by exploiting Krusaders root mode
  • Krusader is the only GUI application that comes with an "execute as root" feature that I know of (anything else?). And yes, there is a reason for it.
  • Again: it is still possible to execute Krusader as root. But we are not advertising it anymore. Those who really need this can still create the desktop entry/action.
Feb 27 2017, 7:54 PM
abika added a comment to D4747: Rework of size/space calculation.

As a next step, if I didn't miss anything, calcSpaceFileSystem in AbstractJobThread::countLocalFiles() could be removed.
The packjob should be passed a list of URLs instead of file names which would eliminate the need to determine the URLs.

Feb 27 2017, 4:31 PM
abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Just found something: in krservices "kdesu" is still defined for tools and never used.

Feb 27 2017, 4:04 PM
abika accepted D4735: [SECURITY] Do not assume that kdesu is in PATH for user actions.

Thanks!

Feb 27 2017, 3:54 PM
abika accepted D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.

Ship it!

Feb 27 2017, 3:44 PM
abika accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Feb 27 2017, 3:41 PM

Feb 23 2017

abika added inline comments to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Feb 23 2017, 8:16 PM
abika created D4750: Entroducing... lazy panels.
Feb 23 2017, 7:05 PM
abika created D4747: Rework of size/space calculation.
Feb 23 2017, 4:04 PM
abika added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Wait, screw that. I mixed up arguments.

Feb 23 2017, 3:50 PM
abika requested changes to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

TL;DR: I agree with Wladimir and would recommend to remove Krusader root mode altogether because we shouldn't support unsafe usage.

Feb 23 2017, 3:30 PM

Feb 20 2017

abika requested review of D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
Feb 20 2017, 5:43 PM
abika updated the summary of D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
Feb 20 2017, 5:40 PM
abika added a comment to D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

Ok, coming back to this. I needed some time to re-think it.

Feb 20 2017, 5:38 PM
abika updated the diff for D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..
  • Dialogs: merged "delay" checkbox with "reverser queue" button in copy/move dialogs
  • JobMan: improved coding style and documentation
  • JobMan: run next job not started yet even if queue mode is off
Feb 20 2017, 5:33 PM

Feb 17 2017

abika accepted D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.

Thanks, works fine. Question is why Ubuntu is having a different tool doing the same thing.

Feb 17 2017, 5:48 PM
abika added a comment to D4610: Panel: Do not select .. in a filtered view if there are other entries.

Added a small fix: _count > 0 instead of _count > 1; the dummy file itself is not counted.

Feb 17 2017, 5:43 PM
abika closed T5372: Adding category for Krusader User actions as Resolved.

Great! Thanks again for the quick response.

Feb 17 2017, 3:36 PM · KDE Store

Feb 16 2017

abika created T5372: Adding category for Krusader User actions.
Feb 16 2017, 4:25 PM · KDE Store

Feb 15 2017

abika abandoned D2857: Use KRun for "Open with"->"Other..." dialog.
In D2857#85422, @asensi wrote:

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

Feb 15 2017, 6:08 PM
abika added a comment to D4610: Panel: Do not select .. in a filtered view if there are other entries.

I don't want to be pedantic but there is a small misbehavior: when the current item is ".." and "Show hidden files" setting is changed (Alt+".") the current jumps to the first file now. Probably nobody will ever notice but checking against empty _quickFilterMask should also solve it.

Feb 15 2017, 5:30 PM
abika added a comment to D4512: Rework of vfile and KrPermHandler class.

Thank you testing.

I couldn't find any regressions.
seems to work correctly

Feb 15 2017, 5:01 PM

Feb 14 2017

abika retitled D4609: Improved integration of (quick) search bar in panel from to Improved integration of (quick) search bar in panel.
Feb 14 2017, 4:07 PM

Feb 13 2017

abika closed D4433: #375994 - List kio-extras under dependencies as recommended package.

Merged with master

Feb 13 2017, 8:56 PM · Krusader
abika accepted D4433: #375994 - List kio-extras under dependencies as recommended package.
Feb 13 2017, 8:55 PM · Krusader
abika closed D4427: Update "get involved" page to indicate how one can register.

Merged with master

Feb 13 2017, 8:54 PM · Websites, Krusader
abika closed D4420: #375894 - Use case-insensitive as default for text search.

Merged with master

Feb 13 2017, 8:54 PM · Krusader
abika closed D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Merged with master

Feb 13 2017, 8:54 PM · Krusader
abika closed D4418: #314258 - Duplicate tab settings when duplicating tabs.

Merged with master

Feb 13 2017, 8:54 PM · Krusader
abika closed D4417: #375831 - Sort empty file extensions correctly.

Merged with master (and Phabricator fails again to autoclose this)

Feb 13 2017, 8:53 PM · Krusader
abika edited the content of Krusader.
Feb 13 2017, 7:02 PM · Krusader

Feb 10 2017

abika added a comment to D2857: Use KRun for "Open with"->"Other..." dialog.

I see. Is the working directory really important for (any) application? It seems strange that Krusader does this different compared to e.g. Dolphin.

Feb 10 2017, 6:03 PM
abika accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Could it be that the issue there was being caused by the extra ListPanel::start() call?

Quick test says: yes!

Feb 10 2017, 4:16 PM · Krusader

Feb 9 2017

abika added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Ok, I see now that this is also not a good solution. The settings are going down to the PanelPopup and KrInterviews. All this should be copied. Sorry I didn't got this earlier.

Feb 9 2017, 8:44 PM · Krusader

Feb 8 2017

abika retitled D4512: Rework of vfile and KrPermHandler class from to Rework of vfile and KrPermHandler class.
Feb 8 2017, 8:27 PM
abika accepted D4146: ListPanel: don't go back in history if refresh failed.

I personally prefer the old behavior. After restart going back to the "nearest" parent folder of a deleted path was pretty nice. And if it was a removable device I can mount it and go back to the folder with the history.

Feb 8 2017, 3:20 PM · Krusader
abika accepted D4420: #375894 - Use case-insensitive as default for text search.

Like I said, I don't really care. In KFind case sensitivity is also off by default.

Feb 8 2017, 3:02 PM · Krusader