miroslavm (Miroslav Milanovic)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 1 2017, 7:31 PM (98 w, 1 d)
Availability
Available

Recent Activity

Sep 5 2017

miroslavm accepted D7610: Support for "mkdir -p" re-added.

the changes are working as expected.

Sep 5 2017, 7:33 PM · Krusader

Aug 5 2017

Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:4f0fbcb507bb: KrViewer looses focus - fixed (authored by miroslavm).
KrViewer looses focus - fixed
Aug 5 2017, 6:14 PM
miroslavm closed D6850: KrViewer looses focus - fixed by committing R167:4f0fbcb507bb: KrViewer looses focus - fixed (authored by miroslavm).
Aug 5 2017, 6:14 PM · Krusader

Aug 1 2017

miroslavm added a project to D6850: KrViewer looses focus - fixed: Krusader.
Aug 1 2017, 8:33 PM · Krusader

Jul 23 2017

miroslavm added a comment to D6850: KrViewer looses focus - fixed.

I have also added the changes of D6788 with arc in the previous diff ... :(

Jul 23 2017, 12:59 PM · Krusader
miroslavm updated the diff for D6850: KrViewer looses focus - fixed.

FIXED: [363437] Edit field looses focus after closing one of Editor's/Viewer's tab
FIXED: [376372] KrViewer window loses focus on closing tabs
BUG: 363437
BUG: 376382

Jul 23 2017, 12:56 PM · Krusader
miroslavm added a reviewer for D6850: KrViewer looses focus - fixed: Krusader.
Jul 23 2017, 12:48 PM · Krusader
miroslavm created D6850: KrViewer looses focus - fixed.
Jul 23 2017, 12:47 PM · Krusader

Jul 22 2017

Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:02d23309df0f: KrViewer: close tab immediately if file cannot be opened (authored by miroslavm).
KrViewer: close tab immediately if file cannot be opened
Jul 22 2017, 5:17 PM
miroslavm closed T1971: Opening Big File Warning as Resolved by committing R167:02d23309df0f: KrViewer: close tab immediately if file cannot be opened.
Jul 22 2017, 5:17 PM · Krusader
miroslavm closed D6788: Resolves T1971 with no further code changes by committing R167:02d23309df0f: KrViewer: close tab immediately if file cannot be opened (authored by miroslavm).
Jul 22 2017, 5:17 PM

Jul 19 2017

miroslavm added a reviewer for D6788: Resolves T1971 with no further code changes: Krusader.
Jul 19 2017, 8:53 PM
miroslavm created D6788: Resolves T1971 with no further code changes.
Jul 19 2017, 8:52 PM
miroslavm added a revision to T1971: Opening Big File Warning: D6788: Resolves T1971 with no further code changes.
Jul 19 2017, 8:52 PM · Krusader
miroslavm moved T1971: Opening Big File Warning from TODO to In progress on the Krusader board.
Jul 19 2017, 8:03 PM · Krusader

Jul 11 2017

Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:6687fad746d2: Make "Disk Usage window" a regular window (authored by miroslavm).
Make "Disk Usage window" a regular window
Jul 11 2017, 8:14 PM
miroslavm closed D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)" by committing R167:6687fad746d2: Make "Disk Usage window" a regular window (authored by miroslavm).
Jul 11 2017, 8:14 PM · Krusader
miroslavm claimed T1971: Opening Big File Warning.

I would like to solve this issue

Jul 11 2017, 7:16 PM · Krusader

Jul 8 2017

miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
In D6471#122384, @abika wrote:

I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

Patch is ok. The double show() and useless 0 argument is still there.
@miroslavm you can merge if you have write access.

Jul 8 2017, 1:03 PM · Krusader
miroslavm updated the diff for D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Update after review. DiskUsage dialog non-modal. Segmentation fault fixed.

Jul 8 2017, 12:56 PM · Krusader

Jul 5 2017

miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
In D6471#121701, @abika wrote:
setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

And a matter of taste is keeping the parent argument for the constructor (keep MAIN_VIEW instead of 0). This will make the dialog a child the mainwindow but with show() it will not block. If you don't like this (I don't care) the parent parameter should be removed.

For Search and Locate only one dialog instance is created. SynchronizerGUI has indeed the same problem (for the last 7+ years). And krusader/UserAction/expander.cpp:702 looks strange.

Jul 5 2017, 9:37 PM · Krusader
miroslavm updated the diff for D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Update after review

Jul 5 2017, 9:26 PM · Krusader
miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 5 2017, 9:06 PM · Krusader

Jul 4 2017

miroslavm added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 4 2017, 5:49 PM · Krusader

Jul 2 2017

miroslavm claimed T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

I would like to solve this issue (patch already submitted)

Jul 2 2017, 8:55 PM · Krusader
miroslavm created D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 2 2017, 8:53 PM · Krusader
miroslavm added a member for Krusader: miroslavm.
Jul 2 2017, 8:11 PM
miroslavm added a watcher for Krusader: miroslavm.
Jul 2 2017, 12:16 PM
miroslavm updated subscribers of T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more then one Disk Usage windows at the same time.

The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.

But if it would be too difficult to rework, I'm fine with modal dialog.

Jul 2 2017, 12:07 PM · Krusader