Move 'connect' call before openUrl
AcceptedPublic

Authored by tguzairov on Sun, Dec 29, 11:29 PM.

Details

Summary

Parts::ReadOnlyPart::completed signal is connected after openUrl has been called.
And it won't be emited, if openUrl was fast enough.
In this case openUrlFinished won't be emited which could, for example, cause the text not receiving a focus.

Diff Detail

Repository
R167 Krusader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20425
Build 20443: arc lint + arc unit
tguzairov requested review of this revision.Sun, Dec 29, 11:29 PM
tguzairov created this revision.
nmel added a comment.Mon, Dec 30, 8:45 AM

This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!

tguzairov updated this revision to Diff 72425.Mon, Dec 30, 10:29 PM

Changed comment

have changed the comment

asensi accepted this revision.Wed, Jan 15, 10:21 PM
asensi added a subscriber: asensi.

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

This revision is now accepted and ready to land.Wed, Jan 15, 10:21 PM