KrusaderProject
ActivePublic

Recent Activity

Fri, Mar 8

Diffusion closed D19277: Create new text files with umask applied.
Fri, Mar 8, 8:21 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

Thanks! Landed (Hope this revision will close itself).

Fri, Mar 8, 7:45 PM · Krusader

Thu, Mar 7

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Thu, Mar 7, 6:54 AM · Krusader

Mon, Mar 4

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mon, Mar 4, 7:44 AM · Krusader

Sun, Mar 3

abika updated the summary of D19277: Create new text files with umask applied.
Sun, Mar 3, 7:16 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

Sun, Mar 3, 7:07 PM · Krusader
abika updated the diff for D19277: Create new text files with umask applied.
  • SQUASH_ME Panel: Create new local text files directly with QFile
Sun, Mar 3, 7:05 PM · Krusader

Mon, Feb 25

nmel added a comment to D19277: Create new text files with umask applied.

Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.

Mon, Feb 25, 6:49 AM · Krusader
nmel closed D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Mon, Feb 25, 6:32 AM · Krusader

Sun, Feb 24

abika added a comment to D19104: Search: Improve right-click context menu.

Thanks for the reviews!

Sun, Feb 24, 5:08 PM · Krusader
Diffusion closed D19104: Search: Improve right-click context menu.
Sun, Feb 24, 5:07 PM · Krusader
abika accepted D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks. Working fine.

Sun, Feb 24, 4:17 PM · Krusader
abika added a project to D19277: Create new text files with umask applied: Krusader.
Sun, Feb 24, 4:02 PM · Krusader

Feb 18 2019

nmel added reviewers for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert: abika, asensi, mchabrecek.
Feb 18 2019, 7:53 AM · Krusader
nmel accepted D19104: Search: Improve right-click context menu.

Nice fix and improvement. Thanks!

Feb 18 2019, 7:50 AM · Krusader
nmel updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
  • fixed build and formatting
Feb 18 2019, 7:13 AM · Krusader
nmel commandeered D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Due to no response from Davide, I'm taking over. I also see lots of deprecation warnings and would like to fix it. The most recent revision doesn't compile, however. I have a fix and will update shortly.

Feb 18 2019, 7:11 AM · Krusader

Feb 17 2019

yurchor added a comment to D19104: Search: Improve right-click context menu.

+1
Compiles, installs and works as expected.

Feb 17 2019, 8:31 PM · Krusader
abika added a project to D19104: Search: Improve right-click context menu: Krusader.
Feb 17 2019, 8:03 PM · Krusader

Nov 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Kindly ping.

Nov 9 2018, 9:16 AM · Krusader

Nov 6 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello All,

Nov 6 2018, 8:07 AM · Krusader

Oct 27 2018

nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Kindly ping.

Oct 27 2018, 7:52 AM · Krusader

Oct 26 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello Guys,

Oct 26 2018, 10:00 AM · Krusader

Oct 21 2018

mchabrecek closed D16223: Replaced old connect() with QT5 style. Part 1.
Oct 21 2018, 9:46 PM · Krusader

Oct 20 2018

yurchor added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Oct 20 2018, 7:21 PM · Krusader

Oct 19 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#345641, @nmel wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

Oct 19 2018, 12:37 PM · Krusader
nmel added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Oct 19 2018, 6:30 AM · Krusader

Oct 17 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#344206, @nmel wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

Oct 17 2018, 7:56 AM · Krusader

Oct 16 2018

nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

Oct 16 2018, 3:36 PM · Krusader
mchabrecek updated the diff for D16223: Replaced old connect() with QT5 style. Part 1.
  • Fixed spacing
Oct 16 2018, 10:26 AM · Krusader
shubham added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

You have to make the changes requested by Nikita.

Oct 16 2018, 10:07 AM · Krusader
mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Oct 16 2018, 9:00 AM · Krusader
nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Thanks and welcome aboard Miroslav!

Oct 16 2018, 7:21 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Looks much better, thanks!

Oct 16 2018, 6:27 AM · Krusader

Oct 15 2018

abika added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 15 2018, 7:04 PM · Krusader
abika accepted D16223: Replaced old connect() with QT5 style. Part 1.

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Oct 15 2018, 6:43 PM · Krusader
abika added a project to D16223: Replaced old connect() with QT5 style. Part 1: Krusader.
Oct 15 2018, 6:28 PM · Krusader
mchabrecek added a comment to T2966: Code Cleaning.

I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.

Oct 15 2018, 1:43 PM · Krusader

Oct 11 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

I thought I had already committed that... changed to a more human macro name

Oct 11 2018, 8:20 PM · Krusader

Oct 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Thank you for help,

Oct 9 2018, 9:35 AM · Krusader

Oct 7 2018

asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Maybe a visual hint would be good so that the users know this feature exists.

Oct 7 2018, 5:26 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 5:01 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 7 2018, 4:43 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 4:08 PM · Krusader

Oct 6 2018

abika added a comment to T2966: Code Cleaning.

Hi Miro,

Oct 6 2018, 3:28 PM · Krusader
mchabrecek placed T2966: Code Cleaning up for grabs.

Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.

Oct 6 2018, 8:20 AM · Krusader

Oct 4 2018

abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Oct 4 2018, 7:22 PM · Krusader

Oct 2 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Oct 2 2018, 5:13 PM · Krusader
mchabrecek added a member for Krusader: mchabrecek.
Oct 2 2018, 4:25 PM

Sep 28 2018

asensi closed D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 28 2018, 6:38 AM · Krusader