Sat, Jan 18
Works as expected. Thanks.
Fri, Jan 17
Thu, Jan 16
Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!
The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)
Wed, Jan 15
The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!
The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+↑ and Ctrl+↓ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?
Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.
Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.
Tue, Jan 14
The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!
That bug has been hindering Krusader users for too long, thanks Davide! :-)
Thu, Jan 9
Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3
Wed, Jan 1
Tue, Dec 31
Mon, Dec 30
have changed the comment
Updated docbook as stated by @yurchor.
It would be nice to move shortcuts in keyboard-commands.docbook (~line 947) from Ctrl to Ctrl-Shift section ( ~line 1218) or make those sections coherent with this patch.
This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!
Sun, Dec 29
Sun, Dec 22
Compiled and tested with no errors, thanks
Dec 2 2019
Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).
Nov 10 2019
Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.
- fixup! Add Kompare as compare application with KIO support
Nov 2 2019
Tested to work as expected. Thanks for your work.
Oct 27 2019
Oct 20 2019
Oct 7 2019
The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .
This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.
Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing
auto keyEvent = static_cast<QKeyEvent *>(event);
auto keyEvent = dynamic_cast<QKeyEvent *>(event);
would not be what it's written in https://doc.qt.io/qt-5/qobject.html:
QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);
The same could be said about
and its existing
auto *ke = static_cast<QKeyEvent *>(event);
Sep 21 2019
Tested Synchronizer, Konfigurator and DiskUsage, no problems found.
Sep 17 2019
Sep 16 2019
Thanks, Toni and Nikita.
...where !(_job == 0) is not equal to !_job == 0.
Isn't the result always the same?
3rd opinion. I agree it should be shown only if the file is actually going to be hidden (Show Hidden is off in settings), otherwise Krusader looks dumb. I agree that users should be able to disable the warning, because for us it may look like an uncommon operation, however some users may work with dot files extensively. This kind of attention to small details make a huge difference in user experience.