The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )
@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.
Isn't it be easier to use boundingRect(text).width() as a replacement of horizontalAdvance(text) which does not require Qt 5.11 and is not deprecated?
Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.
Wed, Jul 17
Sat, Jul 13
Tested on Fedora 30; it compiles and the bug is not present anymore; during the same test, a Krusader version without this patch was having this problem while the patched one was able to rename the file.
Reminder for git push :)
Wed, Jul 3
Works fine for me (3-day testing). Thanks.
Mon, Jul 1
Reviewed the code and tested — everything is great!
Sun, Jun 30
Tested to work as expected.
Jun 16 2019
Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab
Jun 14 2019
New revision is also good - feel free to push to master.
Jun 9 2019
Removed the single tab check in favor of a comment, like proposed by @abika
Jun 2 2019
@gengisdave : A comment would be nice. Thanks.
May 29 2019
@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic
May 25 2019
Looks good. Thanks for the improvement!
The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )
May 22 2019
May 21 2019
Tested to compile, install and work as expected.
May 5 2019
Thanks Nikita! Changes applied and pushed into maste.
- fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
Apr 27 2019
Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.
Apr 22 2019
Apr 15 2019
Thank you, Yuri and Alex!
Apr 13 2019
After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.
Apr 10 2019
Apr 8 2019
QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.
Mar 8 2019
Thanks! Landed (Hope this revision will close itself).
Mar 7 2019
Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!
Mar 4 2019
Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.
Mar 3 2019
You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.
- SQUASH_ME Panel: Create new local text files directly with QFile
Feb 25 2019
Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.
Feb 24 2019
Thanks for the reviews!