KrusaderProject
ActivePublic

Recent Activity

Sat, Jan 18

yurchor accepted D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.

Works as expected. Thanks.

Sat, Jan 18, 12:45 PM · Krusader
yurchor accepted D24480: Change the document about helping Krusader, add other ways (2).
Sat, Jan 18, 12:39 PM · Krusader

Fri, Jan 17

asensi requested review of D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.
Fri, Jan 17, 10:24 PM · Krusader

Thu, Jan 16

asensi added a comment to D24987: Add Kompare as compare application with KIO support.

Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!

Thu, Jan 16, 11:20 PM · Krusader
asensi accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)

Thu, Jan 16, 10:13 PM · Krusader

Wed, Jan 15

asensi accepted D26269: Remove deprecated mostLocalUrl.

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Wed, Jan 15, 11:08 PM · Krusader
asensi added a comment to D26291: rework of keyboard widgets focus.

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+ and Ctrl+ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?

Wed, Jan 15, 10:49 PM · Krusader, Documentation
asensi accepted D26280: Move 'connect' call before openUrl.

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

Wed, Jan 15, 10:21 PM · Krusader
asensi added a comment to D26334: Select item from search window.

Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.

Wed, Jan 15, 10:07 PM · Krusader

Tue, Jan 14

asensi accepted D26325: Update deprecated KUrlLabel::leftClickedUrl.

The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Tue, Jan 14, 10:18 PM · Krusader
asensi accepted D26334: Select item from search window.

That bug has been hindering Krusader users for too long, thanks Davide! :-)

Tue, Jan 14, 10:00 PM · Krusader

Thu, Jan 9

nicolasfella closed D26535: Remove unused include.
Thu, Jan 9, 8:30 PM · Krusader
gengisdave accepted D26535: Remove unused include.

Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3

Thu, Jan 9, 1:25 AM · Krusader

Wed, Jan 1

gengisdave closed T3479: Krusader freezes when renaming a file that is inside an archive as Resolved.
Wed, Jan 1, 5:01 PM · Krusader

Tue, Dec 31

gengisdave requested review of D26334: Select item from search window.
Tue, Dec 31, 5:56 PM · Krusader
gengisdave requested review of D26325: Update deprecated KUrlLabel::leftClickedUrl.
Tue, Dec 31, 11:12 AM · Krusader

Mon, Dec 30

tguzairov added a comment to D26280: Move 'connect' call before openUrl.

have changed the comment

Mon, Dec 30, 10:31 PM · Krusader
tguzairov updated the diff for D26280: Move 'connect' call before openUrl.

Changed comment

Mon, Dec 30, 10:29 PM · Krusader
yurchor accepted D26291: rework of keyboard widgets focus.
Mon, Dec 30, 2:58 PM · Krusader, Documentation
gengisdave updated the diff for D26291: rework of keyboard widgets focus.

Updated docbook as stated by @yurchor.

Mon, Dec 30, 2:51 PM · Krusader, Documentation
yurchor added a comment to D26291: rework of keyboard widgets focus.

It would be nice to move shortcuts in keyboard-commands.docbook (~line 947) from Ctrl to Ctrl-Shift section ( ~line 1218) or make those sections coherent with this patch.

Mon, Dec 30, 2:06 PM · Krusader, Documentation
gengisdave requested review of D26291: rework of keyboard widgets focus.
Mon, Dec 30, 1:56 PM · Krusader, Documentation
nmel added a comment to D26280: Move 'connect' call before openUrl.

This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!

Mon, Dec 30, 8:45 AM · Krusader

Sun, Dec 29

tguzairov added a project to D26280: Move 'connect' call before openUrl: Krusader.
Sun, Dec 29, 11:31 PM · Krusader
gengisdave requested review of D26269: Remove deprecated mostLocalUrl.
Sun, Dec 29, 8:57 AM · Krusader

Sun, Dec 22

gengisdave accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

Compiled and tested with no errors, thanks

Sun, Dec 22, 1:16 PM · Krusader

Dec 2 2019

nicolasfella closed D25669: Replace Q_DECL_OVERRIDE with override.
Dec 2 2019, 11:42 AM · Krusader
gengisdave accepted D25669: Replace Q_DECL_OVERRIDE with override.

Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).

Dec 2 2019, 7:03 AM · Krusader

Nov 10 2019

yurchor added a comment to D24987: Add Kompare as compare application with KIO support.
In D24987#560752, @pino wrote:

I have no idea what "Boy Scout rule" is supposed to mean

Nov 10 2019, 5:33 PM · Krusader
pino requested changes to D24987: Add Kompare as compare application with KIO support.

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

Nov 10 2019, 5:26 PM · Krusader
abika added inline comments to D24987: Add Kompare as compare application with KIO support.
Nov 10 2019, 4:31 PM · Krusader
abika updated the diff for D24987: Add Kompare as compare application with KIO support.
  • fixup! Add Kompare as compare application with KIO support
Nov 10 2019, 4:26 PM · Krusader

Nov 2 2019

pino requested changes to D24987: Add Kompare as compare application with KIO support.
Nov 2 2019, 10:48 PM · Krusader
yurchor added a comment to D24987: Add Kompare as compare application with KIO support.

Tested to work as expected. Thanks for your work.

Nov 2 2019, 7:02 PM · Krusader

Oct 27 2019

abika added a project to D24987: Add Kompare as compare application with KIO support: Krusader.
Oct 27 2019, 5:25 PM · Krusader

Oct 20 2019

abika added a project to D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location: Krusader.
Oct 20 2019, 4:54 PM · Krusader
Diffusion closed D24026: Replace explicite type casting with dynamic casts.
Oct 20 2019, 3:12 PM · Krusader
abika added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi Toni,

Oct 20 2019, 3:07 PM · Krusader

Oct 7 2019

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

Oct 7 2019, 9:32 PM · Krusader, Documentation
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Oct 7 2019, 9:31 PM · Krusader, Documentation
asensi requested review of D24480: Change the document about helping Krusader, add other ways (2).
Oct 7 2019, 9:28 PM · Krusader
asensi added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);
Oct 7 2019, 9:17 PM · Krusader

Sep 21 2019

gengisdave closed D23938: Fix warning about macro expansion.
Sep 21 2019, 3:09 PM · Krusader
gengisdave accepted D24026: Replace explicite type casting with dynamic casts.

Tested Synchronizer, Konfigurator and DiskUsage, no problems found.

Sep 21 2019, 2:21 PM · Krusader

Sep 17 2019

abika added a project to D24026: Replace explicite type casting with dynamic casts: Krusader.
Sep 17 2019, 4:00 PM · Krusader

Sep 16 2019

abika added a comment to D22932: Remove 'isExiting' logic from closing sequence.

Thanks, Toni and Nikita.

Sep 16 2019, 2:58 PM · Krusader
Diffusion closed D22932: Remove 'isExiting' logic from closing sequence.
Sep 16 2019, 2:57 PM · Krusader
abika accepted D23938: Fix warning about macro expansion.

...where !(_job == 0) is not equal to !_job == 0.

Isn't the result always the same?

Sep 16 2019, 2:30 PM · Krusader
nmel added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

3rd opinion. I agree it should be shown only if the file is actually going to be hidden (Show Hidden is off in settings), otherwise Krusader looks dumb. I agree that users should be able to disable the warning, because for us it may look like an uncommon operation, however some users may work with dot files extensively. This kind of attention to small details make a huge difference in user experience.

Sep 16 2019, 4:24 AM · Krusader

Sep 15 2019

asensi closed D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sep 15 2019, 10:13 PM · Krusader