KrusaderProject
ActivePublic

Recent Activity

Yesterday

asensi added a comment to D22177: Panel: Improve open actions in context menu.

The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )

Thu, Jul 18, 9:36 PM · Krusader
gengisdave added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.

Thu, Jul 18, 6:29 PM · Krusader
yurchor added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Isn't it be easier to use boundingRect(text).width() as a replacement of horizontalAdvance(text) which does not require Qt 5.11 and is not deprecated?

Thu, Jul 18, 5:06 PM · Krusader
yurchor closed D22504: Get rid of some deprecated methods.
Thu, Jul 18, 2:54 PM · Krusader
gengisdave accepted D22504: Get rid of some deprecated methods.

Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.

Thu, Jul 18, 2:40 PM · Krusader

Wed, Jul 17

gengisdave added a project to D22504: Get rid of some deprecated methods: Krusader.
Wed, Jul 17, 10:15 AM · Krusader

Sat, Jul 13

gengisdave requested review of D22443: Wrap text in copy/move confirmation dialog.
Sat, Jul 13, 4:43 PM · Krusader
gengisdave requested review of D22435: Remove obsolete qt version check.
Sat, Jul 13, 12:13 PM · Krusader
gengisdave requested review of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sat, Jul 13, 12:03 PM · Krusader
gengisdave accepted D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.

Tested on Fedora 30; it compiles and the bug is not present anymore; during the same test, a Krusader version without this patch was having this problem while the patched one was able to rename the file.

Sat, Jul 13, 9:52 AM · Krusader
nmel added a comment to D22177: Panel: Improve open actions in context menu.

Reminder for git push :)

Sat, Jul 13, 7:04 AM · Krusader
nmel added a project to D22431: Fixed lost editor when file is updating and the list model to correctly handle next item: Krusader.
Sat, Jul 13, 6:59 AM · Krusader

Wed, Jul 3

yurchor added a comment to D22174: Synchronizer: Set column headers to adjust widths automatically.

Works fine for me (3-day testing). Thanks.

Wed, Jul 3, 5:02 PM · Krusader

Mon, Jul 1

nmel accepted D22177: Panel: Improve open actions in context menu.

Reviewed the code and tested — everything is great!

Mon, Jul 1, 6:32 AM · Krusader

Sun, Jun 30

yurchor added a comment to D22177: Panel: Improve open actions in context menu.

Tested to work as expected.

Sun, Jun 30, 7:07 PM · Krusader
abika added a project to D22177: Panel: Improve open actions in context menu: Krusader.
Sun, Jun 30, 6:11 PM · Krusader
abika added a project to D22174: Synchronizer: Set column headers to adjust widths automatically: Krusader.
Sun, Jun 30, 5:04 PM · Krusader

Jun 16 2019

gengisdave closed D21323: Shortcuts for move tab.

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab

Jun 16 2019, 11:10 AM · Krusader
fbampaloukas added a watcher for Krusader: fbampaloukas.
Jun 16 2019, 8:33 AM

Jun 14 2019

nmel accepted D21323: Shortcuts for move tab.

New revision is also good - feel free to push to master.

Jun 14 2019, 5:25 AM · Krusader

Jun 9 2019

gengisdave updated the diff for D21323: Shortcuts for move tab.

Removed the single tab check in favor of a comment, like proposed by @abika

Jun 9 2019, 6:20 AM · Krusader

Jun 2 2019

abika added a comment to D21323: Shortcuts for move tab.

@gengisdave : A comment would be nice. Thanks.

Jun 2 2019, 3:04 PM · Krusader

May 29 2019

gengisdave added a comment to D21323: Shortcuts for move tab.

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

May 29 2019, 5:18 AM · Krusader

May 25 2019

abika accepted D21323: Shortcuts for move tab.

Looks good. Thanks for the improvement!

May 25 2019, 4:56 PM · Krusader
asensi accepted D21323: Shortcuts for move tab.

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

May 25 2019, 7:09 AM · Krusader

May 22 2019

nmel accepted D21323: Shortcuts for move tab.

Thanks Davide!

May 22 2019, 6:58 AM · Krusader

May 21 2019

yurchor added a comment to D21323: Shortcuts for move tab.

Tested to compile, install and work as expected.

May 21 2019, 7:21 PM · Krusader
gengisdave requested review of D21323: Shortcuts for move tab.
May 21 2019, 7:00 PM · Krusader

May 5 2019

abika added a comment to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks Nikita! Changes applied and pushed into maste.

May 5 2019, 7:24 PM · Krusader
Diffusion closed D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
May 5 2019, 7:23 PM · Krusader
abika updated the diff for D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
  • fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
May 5 2019, 7:18 PM · Krusader

Apr 27 2019

nmel accepted D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.

Apr 27 2019, 3:47 AM · Krusader

Apr 22 2019

abika added a project to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime): Krusader.
Apr 22 2019, 3:58 PM · Krusader

Apr 15 2019

nmel added a comment to D20373: Updated minimal Qt version to the earliest supported version (5.9).

Thank you, Yuri and Alex!

Apr 15 2019, 6:51 AM · Krusader
nmel closed D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 15 2019, 6:49 AM · Krusader

Apr 13 2019

abika accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).

After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.

Apr 13 2019, 4:40 PM · Krusader

Apr 10 2019

yurchor accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 10 2019, 7:21 AM · Krusader
nmel added reviewers for D20373: Updated minimal Qt version to the earliest supported version (5.9): mchabrecek, abika, yurchor.
Apr 10 2019, 6:49 AM · Krusader

Apr 8 2019

nmel added a project to D20373: Updated minimal Qt version to the earliest supported version (5.9): Krusader.

QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.

Apr 8 2019, 7:59 AM · Krusader

Mar 8 2019

Diffusion closed D19277: Create new text files with umask applied.
Mar 8 2019, 8:21 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

Thanks! Landed (Hope this revision will close itself).

Mar 8 2019, 7:45 PM · Krusader

Mar 7 2019

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Mar 7 2019, 6:54 AM · Krusader

Mar 4 2019

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mar 4 2019, 7:44 AM · Krusader

Mar 3 2019

abika updated the summary of D19277: Create new text files with umask applied.
Mar 3 2019, 7:16 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

Mar 3 2019, 7:07 PM · Krusader
abika updated the diff for D19277: Create new text files with umask applied.
  • SQUASH_ME Panel: Create new local text files directly with QFile
Mar 3 2019, 7:05 PM · Krusader

Feb 25 2019

nmel added a comment to D19277: Create new text files with umask applied.

Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.

Feb 25 2019, 6:49 AM · Krusader
nmel closed D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Feb 25 2019, 6:32 AM · Krusader

Feb 24 2019

abika added a comment to D19104: Search: Improve right-click context menu.

Thanks for the reviews!

Feb 24 2019, 5:08 PM · Krusader
Diffusion closed D19104: Search: Improve right-click context menu.
Feb 24 2019, 5:07 PM · Krusader