I also tested and it seems to work fine. Thanks for the work to both Martins!
I've changed delimiter to space and used KShell::splitArgs() method to allow using
- quoted folder names
- folder names with escaped spaces
Now the names of Jakub Buczak (Jakkubu) and Nate Graham are mentioned in the commit.
One more small update - fix include order.
Thanks, Toni, for testing the patch and the pretty good idea to change colon to space!
Fri, Feb 23
It's pushed by Davide already.
Thanks for testing, Martin!
The reporter's name is Jakub Buczak, according to his email address, in case you want to use his full name in the commit message.
Thanks, Nikita, for making this work!
Thu, Feb 22
For more consistency, I'm thinking that, if in the "Search for:" text field, Krusader users space as a delimiter... maybe it would also use it in the same window, in the proposed «Exclude Folder Names» text field.
I also accept to prevent another code review iteration. Please integrate the requested changes into the final commit.
Works nicely on Arch Linux. Thanks Davide! :)
Wed, Feb 21
Thank you! For my part, I accept this because I performed some tests and the new patch worked correctly (items inside the specified folders are excluded, files and folders that are shown are the expected ones, etc.), although when there was a folder with a ":" inside its name then the folder couldn't be excluded.
Thanks Davide! The changes that Nikita (nmel) wrote are also improvements. For my part, I accept this because my performed tests (using Kubuntu 17.10) seemed to work correctly.
Mon, Feb 19
Sun, Feb 18
Thank you both for informative answers!
Sat, Feb 17
Thanks for the bug fix. I checked the code and tested - it works nicely!
Fri, Feb 16
Thanks, Toni, for trying it out! :-)
Tue, Feb 13
-Thanks, Toni, for trying it out! :-) I believe that cmake is installing into /user/local by default no matter KDE_INSTALL_USE_QT_SYS_PATHS is set or not. At least on Arch Linux it works out like that. Only after setting -DCMAKE_INSTALL_PREFIX=... the install prefix get changed. And that is persisted even if next cmake call is performed without this switch. Best practice for me is cleaning up build folder before calling cmake to have a predictable results. Again, it works like that in Arch Linux with cmake version 3.10.2, I'm not sure if other distributions behave the same.
Sun, Feb 11
Fri, Feb 9
Hi! I tried the patch, using Kubuntu 17.10, and everything seems to work correctly.
Wed, Feb 7
Sat, Feb 3
Diff updated to show a waring if CMAKE_INSTALL_PREFIX is not standard with a hint how to force installing plugins to standard location.
Jan 23 2018
Thanks for the lot of good info!
Jan 22 2018
Because you added this
Jan 21 2018
As I understand it, the problem is that plugins installed to PREFIX/lib/qt/plugins won't always be be found depending on PREFIX.
It will work for "/usr" and probably "/usr/local" (can you confirm the latter, Martin? I didn't test it).
But if I install e.g. to a directory in the Krusader source directory (a quick local installation for testing) the plugins won't work. And this will may be left unnoticed by the user.
Oct 7 2017
Sep 29 2017
For my part, I accept this because my performed tests (using Kubuntu 17.04) went alright.
Sep 24 2017
Sep 17 2017
Sep 10 2017
Sep 9 2017
I've noticed a regression after this push. Creation of new directory no longer focused the new directory. This should now be fixed in git with commit https://phabricator.kde.org/R167:ac22d0fc4412cc9a2f9130ba85184817c1667094. I didn't want to bother you with another review request. If there are another issues with this, I'll be happy to fix them.
Thanks a lot for your thorough testing :).