Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

Also we are trying to move over to gitlab for patches - https://invent.kde.org/kde/konsole/merge_requests

In D26479#589291, @hindenburg wrote:

Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

That warning is new in Qt 5.14:
https://code.qt.io/cgit/qt/qtbase.git/commit/src/corelib/tools/qcommandlineparser.cpp?h=5.14&id=90c86d738e0f36eaa48c7f81f6f5cc035a339d6b

KAboutData::setupCommandLine calls addHelpVersion() and addVersionOption() since kcoreaddons 5.7.0:
https://cgit.kde.org/kcoreaddons.git/commit/src/lib/kaboutdata.cpp?id=e73140695268a8d94812d74178bc0a225a319d17

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

In D26479#589560, @wbauer wrote:

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

In D26479#589562, @wbauer wrote:

In D26479#589560, @wbauer wrote:

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

The KF5 version has never been tested to see what's actually required - that is just a low #.

I think this needs a Qt5 and KF5 check; there's no reason to remove in earlier versions.

In D26479#589636, @hindenburg wrote:

I think this needs a Qt5 and KF5 check; there's no reason to remove in earlier versions.

It would only need a KF5 check:
#if KCOREADDONS_VERSION < QT_VERSION_CHECK(5,7,0)

The Qt version doesn't matter, it's just that earlier versions don't print a runtime warning if an option is added twice.

But, @lmontel already committed this change also to konsole an hour ago:
https://cgit.kde.org/konsole.git/commit/?id=ac630f7fb15506ef4a49bab519361697c30ff273

So it's probably best to just raise the minimum KF5 version to at least 5.7.0 now (which still is ancient).

Yea I noticed that - he does that a lot - thanks for this patch regardless - you can close this.