Differential D27433

Check activeModule before using it
ClosedPublic
Actions

Authored by wbauer on Feb 16 2020, 1:35 PM.

Details

Reviewers
davidedmundson
ervin
Group Reviewers
Frameworks
Commits
R295:ea7120ed901b: Check activeModule before using it
Summary

activeModule can be a nullptr here, as this is outside/after the if (activeModule).
This causes kontact to crash when opening its settings.

BUG: 417396
FIXED-IN: 5.68.0

Test Plan

Start kontact and select "Configure Kontact" in ist "Settings" menu. It doesn't crash anymore.

Diff Detail

Repository
R295 KCMUtils
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer created this revision.Feb 16 2020, 1:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 16 2020, 1:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
wbauer edited the summary of this revision. (Show Details)Feb 16 2020, 1:41 PM
davidedmundson accepted this revision.Feb 16 2020, 2:25 PM
This revision is now accepted and ready to land.Feb 16 2020, 2:25 PM
ervin accepted this revision.Feb 16 2020, 2:45 PM

Revision Contents
Changeset List

PathPackages
Msrc/kcmultidialog.cpp (2 lines)

Diff 75767

View Options

src/kcmultidialog.cpp

Loading...