Copy _colorRandomization when copying a new ColorScheme
ClosedPublic

Authored by wbauer on Jan 5 2020, 5:28 PM.

Details

Summary

The _colorRandomization property is new in 19.12, and should be
copied by the copy constructor as well.

This fixes the problem that it was not possible to disable the
"Randomly adjust colors for each session" option again once it was
enabled.

CCBUG: 415242
FIXED-IN: 19.12.1

Test Plan

In the color scheme editor:
Choose "Black on Random Light" and click on Edit, disable
"Randomly adjust colors for each session", and click OK.
It's saved correctly now, previously it stayed on.

Alternatively, select some other color scheme, enable the option and
click OK. Then try to disable it again. This works now, previously it
also stayed on.

Select an existing colorscheme and click on New, the new color scheme
still properly inherits the "Randomly adjust colors for each session"
setting.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Jan 5 2020, 5:28 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJan 5 2020, 5:28 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
wbauer requested review of this revision.Jan 5 2020, 5:28 PM
wbauer edited the test plan for this revision. (Show Details)Jan 5 2020, 5:33 PM
hindenburg accepted this revision.Jan 5 2020, 6:12 PM
hindenburg added a subscriber: hindenburg.

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

https://invent.kde.org/kde/konsole/merge_requests

This revision is now accepted and ready to land.Jan 5 2020, 6:12 PM
hindenburg retitled this revision from Also copy _colorRandomization when creating a new ColorScheme from another one to Copy _colorRandomization when copying a new ColorScheme.Jan 5 2020, 6:15 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg edited the summary of this revision. (Show Details)Jan 5 2020, 6:20 PM
wbauer added a comment.Jan 5 2020, 6:21 PM

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

https://invent.kde.org/kde/konsole/merge_requests

Ok, I will keep this in mind.

This revision was automatically updated to reflect the committed changes.