pavelmos (Pavel Mos)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2018, 1:12 PM (28 w, 5 d)
Availability
Available

Recent Activity

Thu, Apr 11

pavelmos added a comment to D18842: Add language-team settings to Lokalize.

It's a great idea, I would have a few suggestions :

  • Scrap the automatic option
    • if the application checkbox (kcfg_overrideLangTeam) is unchecked (by default), show the default value in the text field next to it instead (greyed out)
  • Replace the combobox in the Project setting by a checkbox
    • show the Application value (default or override) if it is unchecked (greyed out)
Thu, Apr 11, 3:16 PM

Tue, Apr 9

pavelmos added reviewers for D20222: Plasma-Workspace. The last checkbox in the widget settings: davidre, ngraham.
Tue, Apr 9, 2:54 PM · Plasma
pavelmos added reviewers for D20223: Make disk monitor widget only show real devices by default: davidre, ngraham, mart.
Tue, Apr 9, 2:53 PM · Plasma
pavelmos set the repository for D18842: Add language-team settings to Lokalize to R456 Lokalize.
Tue, Apr 9, 2:23 PM
pavelmos set the repository for D17796: Show accurate checked state for system monitor configuration pages to R120 Plasma Workspace.
Tue, Apr 9, 8:07 AM · Plasma

Wed, Apr 3

pavelmos added a comment to D20223: Make disk monitor widget only show real devices by default.

I've edited the title and summary to be a bit more clear. Does that help and is it accurate?

Wed, Apr 3, 3:11 PM · Plasma
pavelmos added a comment to D17796: Show accurate checked state for system monitor configuration pages.

It seems to me that everything is fine.
Are there any other comments or questions?

Wed, Apr 3, 12:34 PM · Plasma
pavelmos added a comment to D16057: Fix opening URL's to help files.

After fixing https://bugs.kde.org/show_bug.cgi?id=399274, the duplicated menu under KInfoCenter Modules" -> <module_name> -> "KInfoCenter" does not exist anymore. Is this fix still relevant then?

Wed, Apr 3, 12:29 PM · Documentation
pavelmos added a comment to D20223: Make disk monitor widget only show real devices by default.

Can you explain not what the change is doing, but why we're making it?

What happens if I'm trying to monitor a removable USB disk?

Wed, Apr 3, 12:19 PM · Plasma
pavelmos requested review of D20223: Make disk monitor widget only show real devices by default.
Wed, Apr 3, 8:23 AM · Plasma
pavelmos requested review of D20222: Plasma-Workspace. The last checkbox in the widget settings.
Wed, Apr 3, 8:07 AM · Plasma

Tue, Apr 2

pavelmos updated the diff for D18842: Add language-team settings to Lokalize.

Removed NOKDE from code

Tue, Apr 2, 3:15 PM

Feb 8 2019

pavelmos requested review of D18842: Add language-team settings to Lokalize.
Feb 8 2019, 9:32 AM
pavelmos added a comment to D17796: Show accurate checked state for system monitor configuration pages.

I have no commit access.

Feb 8 2019, 9:02 AM · Plasma

Dec 29 2018

pavelmos added a comment to D17796: Show accurate checked state for system monitor configuration pages.

There we go, it works now! Code change looks sane to me.

Please change the title to something more descriptive, such as "Show accurate checked state for system monitor configuration pages". And then we'll wait for a review from a Plasma developer.

Dec 29 2018, 9:04 AM · Plasma
pavelmos retitled D17796: Show accurate checked state for system monitor configuration pages from Plasma Workspace. Fixed general settings of the widgets. to Show accurate checked state for system monitor configuration pages.
Dec 29 2018, 8:58 AM · Plasma

Dec 28 2018

pavelmos updated the diff for D17796: Show accurate checked state for system monitor configuration pages.
Dec 28 2018, 9:42 AM · Plasma

Dec 25 2018

pavelmos added a reviewer for D17796: Show accurate checked state for system monitor configuration pages: jriddell.
Dec 25 2018, 12:44 PM · Plasma
pavelmos requested review of D17796: Show accurate checked state for system monitor configuration pages.
Dec 25 2018, 12:43 PM · Plasma

Nov 23 2018

pavelmos added a comment to D17094: Fixed comic widget context menu crash.

I have no commit access.

Nov 23 2018, 11:35 AM · Plasma
pavelmos added a comment to D17095: Fixed comic widget crash.

I have no commit access.

Nov 23 2018, 11:34 AM · Plasma
pavelmos updated the diff for D17094: Fixed comic widget context menu crash.
Nov 23 2018, 8:50 AM · Plasma

Nov 22 2018

pavelmos added inline comments to D17095: Fixed comic widget crash.
Nov 22 2018, 10:07 AM · Plasma
pavelmos updated the diff for D17095: Fixed comic widget crash.
Nov 22 2018, 10:06 AM · Plasma
pavelmos added reviewers for D17095: Fixed comic widget crash: jriddell, bshah, davidedmundson.
Nov 22 2018, 9:27 AM · Plasma
pavelmos added reviewers for D17094: Fixed comic widget context menu crash: jriddell, bshah, davidedmundson.
Nov 22 2018, 9:26 AM · Plasma
pavelmos requested review of D17095: Fixed comic widget crash.
Nov 22 2018, 9:23 AM · Plasma
pavelmos requested review of D17094: Fixed comic widget context menu crash.
Nov 22 2018, 9:22 AM · Plasma

Oct 31 2018

pavelmos added a comment to D16352: Contents items expanding issue.

The review that fixes a bug should have the BUG: entry, so it's all up to whether that review and that bug are really linked. They have the same author, so let's hear from @pavelmos

Oct 31 2018, 8:12 AM · Documentation
pavelmos added a comment to D16308: Remove duplicate submenus..

I corrected the description. Do you have any comments?

Oct 31 2018, 7:53 AM · Documentation
pavelmos added a comment to D16057: Fix opening URL's to help files.

I corrected the description. Do you have any comments?

Oct 31 2018, 7:52 AM · Documentation
pavelmos updated the summary of D16057: Fix opening URL's to help files.
Oct 31 2018, 7:51 AM · Documentation

Oct 23 2018

pavelmos retitled D16057: Fix opening URL's to help files from Fix sublist expanding on the left panel to Fix opening URL's to help files.
Oct 23 2018, 7:24 AM · Documentation
pavelmos updated the summary of D16057: Fix opening URL's to help files.
Oct 23 2018, 7:20 AM · Documentation

Oct 22 2018

pavelmos updated the test plan for D16057: Fix opening URL's to help files.
Oct 22 2018, 1:08 PM · Documentation
pavelmos updated the test plan for D16308: Remove duplicate submenus..
Oct 22 2018, 12:58 PM · Documentation
pavelmos added a comment to D16057: Fix opening URL's to help files.

Not the commit message; for example, "STEPS TO REPRODUCE BUG" do not belong here.

Another user proposed a different fix for this issue:
https://phabricator.kde.org/D16352

I'm still not sure which is the better fix, but for sure you can take a look at the other commit message as an example on how to write a commit message.

Oct 22 2018, 8:33 AM · Documentation
pavelmos added a comment to D16057: Fix opening URL's to help files.

Not the commit message; for example, "STEPS TO REPRODUCE BUG" do not belong here.

Another user proposed a different fix for this issue:
https://phabricator.kde.org/D16352

I'm still not sure which is the better fix, but for sure you can take a look at the other commit message as an example on how to write a commit message.

Oct 22 2018, 7:31 AM · Documentation

Oct 19 2018

pavelmos abandoned D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).
Oct 19 2018, 2:23 PM · Documentation
pavelmos added a comment to D16057: Fix opening URL's to help files.

I fixed everything

Oct 19 2018, 11:37 AM · Documentation
pavelmos updated the summary of D16057: Fix opening URL's to help files.
Oct 19 2018, 9:42 AM · Documentation
pavelmos added a comment to D16308: Remove duplicate submenus..

I fixed everything

Oct 19 2018, 9:34 AM · Documentation
pavelmos updated the summary of D16308: Remove duplicate submenus..
Oct 19 2018, 9:34 AM · Documentation
pavelmos added a comment to D16057: Fix opening URL's to help files.

Do I need to do anything else with this patch?
When will it be included in the KHelpCenter?

Oct 19 2018, 9:24 AM · Documentation
pavelmos updated the summary of D16308: Remove duplicate submenus..
Oct 19 2018, 9:03 AM · Documentation
pavelmos added a comment to D16308: Remove duplicate submenus..

Please note that "A bit more " does not mean "the exact same content of the bug report".

I already mentioned this: https://chris.beams.io/posts/git-commit/ , please check it.
For example, all the details about the software where the bug were reproduced belong only to the bug, not here.

If this fixes a bug, you need to add a line with

BUG: <num>

Oct 19 2018, 8:52 AM · Documentation
pavelmos added a reviewer for D16308: Remove duplicate submenus.: ltoscano.
Oct 19 2018, 8:46 AM · Documentation
pavelmos added a reviewer for D16308: Remove duplicate submenus.: yurchor.
Oct 19 2018, 8:44 AM · Documentation
pavelmos requested review of D16308: Remove duplicate submenus..
Oct 19 2018, 7:51 AM · Documentation

Oct 9 2018

pavelmos abandoned D16047: Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified.
Oct 9 2018, 7:05 AM · Documentation
pavelmos added reviewers for D16057: Fix opening URL's to help files: yurchor, ltoscano.
Oct 9 2018, 6:51 AM · Documentation
pavelmos requested review of D16057: Fix opening URL's to help files.
Oct 9 2018, 6:49 AM · Documentation
pavelmos added a comment to D16047: Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified.

Oops... Arcanist is not the answer to any question on KDE commits (Luigi, please...).

  1. Please remove Dolphin directory file from the commit.
  2. Change the title to something like "Fix sublist expanding on the left panel".
  3. Add "BUG: 399275" to the description.

    or

    Luigi, if you do not mind, can I process this oneliner in an appropriate way?
Oct 9 2018, 6:33 AM · Documentation
pavelmos added reviewers for D16047: Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified: yurchor, ltoscano.
Oct 9 2018, 6:17 AM · Documentation

Oct 8 2018

pavelmos added a comment to D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Thank you.
Unfortunately, I can't use Arcanist as it is not included in AltLinux.

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

I guess we need to link that inside https://community.kde.org/Infrastructure/Phabricator#Installing_Arcanist

Oct 8 2018, 3:00 PM · Documentation
pavelmos requested review of D16047: Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified.
Oct 8 2018, 2:53 PM · Documentation

Oct 5 2018

pavelmos added a comment to D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Oct 5 2018, 8:17 AM · Documentation

Oct 2 2018

pavelmos updated the summary of D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).
Oct 2 2018, 8:26 AM · Documentation
pavelmos updated the test plan for D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).
Oct 2 2018, 8:23 AM · Documentation

Oct 1 2018

pavelmos added reviewers for D15880: Khelpcenter menu does not work (some parts of TreeView not expanded): yurchor, mlaurent, anemeth, lueck.
Oct 1 2018, 2:59 PM · Documentation
pavelmos requested review of D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).
Oct 1 2018, 2:48 PM · Documentation