Differential D16047

Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified
AbandonedPublic
Actions

Authored by pavelmos on Oct 8 2018, 2:51 PM.

Details

Reviewers
yurchor
ltoscano
Summary

Khelpcenter menu does not work (some parts of TreeView not expanded)

Package: khelpcenter version 5.7.3
KDE Frameworks Version 5.51.0
Qt Version 5.11.1

KDE Plasma Version 5.13.90
Kernel Version 4.15.0-34-generic
OS Type: 64-bit

NAME="KDE neon"
VERSION="Developer Edition"
ID=neon
ID_LIKE="ubuntu debian"
PRETTY_NAME="KDE neon Developer Edition"
VERSION_ID="18.04"
HOME_URL="http://neon.kde.org/"
SUPPORT_URL="http://neon.kde.org/"
BUG_REPORT_URL="http://bugs.kde.org/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

On 2018.09.26, an upgrade was made by command dist-upgrade.
Incorrect to works the contents index tree on left half of application window (TreeWidget) khelpcenter.

STEPS TO REPRODUCE BUG

0. Open «System Settings» (systemsettings5) → Input Devices → Mouse → General → Choose «Double-click to open files and folders» (!!!)

Start khelpcenter (in any way).
Choose menu item - "Kinfocenter Modules" - in the left half of the application window.
Choose "Memory" in the right half of the application window.
Look on the left half of the application window.
Choose «KinfoCenter» menu item in the left half of the application window.
The corresponding help is not displayed in the right half of the application window.
Similarly with other submenus of «KinfoCenter Modules» -> ... .

OBSERVED RESULT

User uses - Double-click to open files and folders.
Start khelpcenter.
Pressing some of the menu items does not produce any results (the corresponding help information is not displayed in the right half of the application window). For example - look at "STEPS TO REPRODUCE BUG".

EXPECTED RESULT
Menu should work correctly:

all menu items should be displayed,
subparagraphs should open and disclose subtrees,
the corresponding help is displayed in the right half of the application window.
Test Plan

STEPS TO REPRODUCE

Open «System Settings» (systemsettings5) → Input Devices → Mouse → General → Choose «Double-click to open files and folders»
Start khelpcenter (in any way).
Choose menu item - "Kinfocenter Modules" - in the left half of the application window.
Choose "Memory" in the right half of the application window.
Choose «KinfoCenter» menu item in the left half of the application window.
Choose any submenu item of «KinfoCenter» menu in the left half of the application window.
Now the corresponding help is displayed in the right half of the application window.

Diff Detail

Repository
R125 KHelpCenter
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3643
Build 3661: arc lint + arc unit
pavelmos created this revision.Oct 8 2018, 2:51 PM
Restricted Application added a project: Documentation. · View Herald TranscriptOct 8 2018, 2:52 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
pavelmos requested review of this revision.Oct 8 2018, 2:52 PM
pavelmos retitled this revision from navigatorappitem.cpp modified to Khelpcenter menu does not work (some parts of TreeView not expanded) - navigatorappitem.cpp modified.Oct 9 2018, 6:17 AM
pavelmos edited the summary of this revision. (Show Details)
pavelmos edited the test plan for this revision. (Show Details)
pavelmos added reviewers: yurchor, ltoscano.
yurchor requested changes to this revision.Oct 9 2018, 6:28 AM

Oops... Arcanist is not the answer to any question on KDE commits (Luigi, please...).

  1. Please remove Dolphin directory file from the commit.
  2. Change the title to something like "Fix sublist expanding on the left panel".
  3. Add "BUG: 399275" to the description.

or

Luigi, if you do not mind, can I process this oneliner in an appropriate way?

This revision now requires changes to proceed.Oct 9 2018, 6:28 AM
pavelmos added a comment.Oct 9 2018, 6:32 AM
In D16047#339616, @yurchor wrote:

Oops... Arcanist is not the answer to any question on KDE commits (Luigi, please...).

  1. Please remove Dolphin directory file from the commit.
  2. Change the title to something like "Fix sublist expanding on the left panel".
  3. Add "BUG: 399275" to the description.

    or

    Luigi, if you do not mind, can I process this oneliner in an appropriate way?

Thank you. I will try to fix it.

pavelmos abandoned this revision.Oct 9 2018, 7:05 AM

Revision Contents
Changeset List

PathPackages
AM.directory (6 lines)
Mnavigatorappitem.cpp (2 lines)

Diff 43136

View Options

.directory

Loading...
View Options

navigatorappitem.cpp

Loading...