Plasma-Workspace. The last checkbox in the widget settings
ClosedPublic

Authored by pavelmos on Apr 3 2019, 8:07 AM.

Details

Reviewers
broulik
davidre
ngraham
davidedmundson
Group Reviewers
Plasma
Summary

Added a ban on disabling the last checkbox in the widget settings.
There will always be at least one graph.

If the user disables the last checkbox, all other checkboxes will automatically get enabled in the settings.
It may be inconvenient for users to uncheck a large number of checkboxes.

This fix is aimed at improving the usability of Plasma-Workspace widgets.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos created this revision.Apr 3 2019, 8:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 3 2019, 8:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Apr 3 2019, 8:07 AM

Please skip this.

Oops, sorry for losing track of this. Is it replaced by something else? If you don't think it's needed anymore you can Abandon it from the Add Action... menu.

davidedmundson accepted this revision.May 16 2019, 11:42 PM
davidedmundson added a subscriber: davidedmundson.

Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent.

If the user disables the last checkbox, all other checkboxes will automatically get enabled in the settings.

Yeah, that's weird behaviour.

Lets do this.

This revision is now accepted and ready to land.May 16 2019, 11:42 PM

Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent.

If the user disables the last checkbox, all other checkboxes will automatically get enabled in the settings.

Yeah, that's weird behaviour.

Lets do this.

Thanks!
I have no commit access.

This doesn't apply to master anymore:

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20222.
Checking patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml...
error: while searching for:
                        }
                    } else {
                        var idx = cfg_sources.indexOf(model.source);
                        if (idx !== -1) {
                            cfg_sources.splice(idx, 1);
                        }
                    }
                    cfg_sourcesChanged();

error: patch failed: applets/systemmonitor/common/contents/ui/ConfigGeneral.qml:134
Applying patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml with 1 reject...
Rejected hunk #1.

 Patch Failed! 
Usage Exception: Unable to apply patch!

Can you rebase the patch so we can land it?

@pavelmos would you like to continue working on this or should someone else take it over?

If it's just a rebase needed, I'll land it.