Add language-team settings to Lokalize
Needs ReviewPublic

Authored by pavelmos on Feb 8 2019, 9:32 AM.

Details

Summary
  • add settings for explicitly setting the value of Language-Team
  • it allows to specify the value of Language-Team setting for application and to override it for specific projects

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos requested review of this revision.Feb 8 2019, 9:32 AM
pavelmos created this revision.
sdepiets added inline comments.Feb 8 2019, 3:12 PM
src/catalog/gettextheader.cpp
365

you can remove the ifndef NOKDE we don't release a non-kde build anymore for lokalize. It's built with craft, for instance here https://binary-factory.kde.org/job/Lokalize_Nightly_win32/

pavelmos updated this revision to Diff 55287.Tue, Apr 2, 3:15 PM

Removed NOKDE from code

pavelmos set the repository for this revision to R456 Lokalize.

Sorry I've been a bit slow on this review, I'll check the behavior by the end of the week

src/prefs/prefs.cpp
116

Can you use the new signal API for this one ?

sdepiets requested changes to this revision.Thu, Apr 11, 2:53 PM

It's a great idea, I would have a few suggestions :

  • Scrap the automatic option
    • if the application checkbox (kcfg_overrideLangTeam) is unchecked (by default), show the default value in the text field next to it instead (greyed out)
  • Replace the combobox in the Project setting by a checkbox
    • show the Application value (default or override) if it is unchecked (greyed out)
src/prefs/prefs_identity.ui
156

You can add change the label to "Default Language-Team:"

src/project/prefs_projectmain.ui
143

Please add a Langage-Team: label before the combobox or we don't know what this relates to

This revision now requires changes to proceed.Thu, Apr 11, 2:53 PM

It's a great idea, I would have a few suggestions :

  • Scrap the automatic option
    • if the application checkbox (kcfg_overrideLangTeam) is unchecked (by default), show the default value in the text field next to it instead (greyed out)
  • Replace the combobox in the Project setting by a checkbox
    • show the Application value (default or override) if it is unchecked (greyed out)

Thanks for your reply!
I'll do it when I have enough time (unfortunately, I'm too busy to get to it right now).

pavelmos updated this revision to Diff 56824.Tue, Apr 23, 2:13 PM
pavelmos updated this revision to Diff 56826.Tue, Apr 23, 2:27 PM