Differential D16308

Remove duplicate submenus.
ClosedPublic
Actions

Authored by pavelmos on Oct 19 2018, 7:51 AM.

Details

Reviewers
yurchor
ltoscano
Commits
R125:3e5549ebe181: Remove duplicate submenus.
Summary

Signed-off-by: Pavel Mars <mars@basealt.ru>

Remove duplicate submenus.

On the left side of the khelpcenter window is the content ("Contents").
If you open the item "Application Manuals" -> "System" -> "Info Center", the item "Info Center" will generate a tree of additional menu items.

If you open the menu item "KInfoCenter Modules" in the same content and then open the menu items that appear (for example, "Device Viewer", "Memory", "OpenGL" or any other item), the same additional menu item tree will be generated.

This change removes duplication of generated trees.

This is achieved by registering the URLs of the elements of the content tree in a separate container and checking the URL to be opened: if the base address from the URL is registered, then we request the generation of the menu tree from the registered element of the tree, but not from the current one.

BUG: 399274

Diff Detail

Repository
R125 KHelpCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pavelmos created this revision.Oct 19 2018, 7:51 AM
Restricted Application added a project: Documentation. · View Herald TranscriptOct 19 2018, 7:51 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
pavelmos requested review of this revision.Oct 19 2018, 7:51 AM
ltoscano added a subscriber: ltoscano.Oct 19 2018, 8:18 AM

Thanks for change, but which menu items? Can you please extend a *bit* the commit message?

pavelmos edited the summary of this revision. (Show Details)Oct 19 2018, 8:44 AM
pavelmos edited the test plan for this revision. (Show Details)
pavelmos added a reviewer: yurchor.
pavelmos added a reviewer: ltoscano.
ltoscano added a comment.Oct 19 2018, 8:50 AM

Please note that "A bit more " does not mean "the exact same content of the bug report".

I already mentioned this: https://chris.beams.io/posts/git-commit/ , please check it.
For example, all the details about the software where the bug were reproduced belong only to the bug, not here.

If this fixes a bug, you need to add a line with

BUG: <num>

pavelmos added a comment.Oct 19 2018, 8:52 AM
In D16308#345687, @ltoscano wrote:

Please note that "A bit more " does not mean "the exact same content of the bug report".

I already mentioned this: https://chris.beams.io/posts/git-commit/ , please check it.
For example, all the details about the software where the bug were reproduced belong only to the bug, not here.

If this fixes a bug, you need to add a line with

BUG: <num>

Thank. I'll fix it now

pavelmos edited the summary of this revision. (Show Details)Oct 19 2018, 9:03 AM
pavelmos edited the summary of this revision. (Show Details)Oct 19 2018, 9:34 AM

I fixed everything

pavelmos edited the summary of this revision. (Show Details)Oct 22 2018, 12:58 PM
pavelmos edited the test plan for this revision. (Show Details)
pavelmos added a comment.Oct 31 2018, 7:53 AM

I corrected the description. Do you have any comments?

yurchor accepted this revision.Nov 18 2018, 7:26 PM

The patch does exactly what is written in its description. Works fine here. I think it can be committed after removing whitespaces.

navigatorappitem.h
48

Whitespace should be removed from this line.

50

Same here.

This revision is now accepted and ready to land.Nov 18 2018, 7:26 PM
ltoscano accepted this revision.Nov 19 2018, 12:19 AM

Thanks and sorry for the delay.

Closed by commit R125:3e5549ebe181: Remove duplicate submenus. (authored by pavelmos, committed by ltoscano). · Explain WhyNov 19 2018, 12:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mnavigatorappitem.h (3 lines)
Mnavigatorappitem.cpp (36 lines)

Diff 45770

View Options

navigatorappitem.h

Loading...
View Options

navigatorappitem.cpp

Loading...