In D20222#466116, @davidedmundson wrote:

Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent.

If the user disables the last checkbox, all other checkboxes will automatically get enabled in the settings.

Yeah, that's weird behaviour.

Lets do this.

Please skip this.

Please skip this.

In D18842#448170, @sdepiets wrote:

It's a great idea, I would have a few suggestions :

• Scrap the automatic option
  • if the application checkbox (kcfg_overrideLangTeam) is unchecked (by default), show the default value in the text field next to it instead (greyed out)
• Replace the combobox in the Project setting by a checkbox
  • show the Application value (default or override) if it is unchecked (greyed out)

In D20223#442883, @ngraham wrote:

I've edited the title and summary to be a bit more clear. Does that help and is it accurate?

It seems to me that everything is fine.
Are there any other comments or questions?

In D16057#361900, @ltoscano wrote:

After fixing https://bugs.kde.org/show_bug.cgi?id=399274, the duplicated menu under KInfoCenter Modules" -> <module_name> -> "KInfoCenter" does not exist anymore. Is this fix still relevant then?

In D20223#442762, @davidedmundson wrote:

Can you explain not what the change is doing, but why we're making it?

What happens if I'm trying to monitor a removable USB disk?

Removed NOKDE from code

I have no commit access.

In D17796#382974, @ngraham wrote:

There we go, it works now! Code change looks sane to me.

Please change the title to something more descriptive, such as "Show accurate checked state for system monitor configuration pages". And then we'll wait for a review from a Plasma developer.

I have no commit access.

I have no commit access.

In D16352#346737, @ltoscano wrote:

The review that fixes a bug should have the BUG: entry, so it's all up to whether that review and that bug are really linked. They have the same author, so let's hear from @pavelmos

I corrected the description. Do you have any comments?

I corrected the description. Do you have any comments?

In D16057#346697, @ltoscano wrote:

Not the commit message; for example, "STEPS TO REPRODUCE BUG" do not belong here.

Another user proposed a different fix for this issue:
https://phabricator.kde.org/D16352

I'm still not sure which is the better fix, but for sure you can take a look at the other commit message as an example on how to write a commit message.

In D16057#346697, @ltoscano wrote:

Not the commit message; for example, "STEPS TO REPRODUCE BUG" do not belong here.

Another user proposed a different fix for this issue:
https://phabricator.kde.org/D16352

I'm still not sure which is the better fix, but for sure you can take a look at the other commit message as an example on how to write a commit message.

I fixed everything

I fixed everything

Do I need to do anything else with this patch?
When will it be included in the KHelpCenter?

In D16308#345687, @ltoscano wrote:

Please note that "A bit more " does not mean "the exact same content of the bug report".

I already mentioned this: https://chris.beams.io/posts/git-commit/ , please check it.
For example, all the details about the software where the bug were reproduced belong only to the bug, not here.

If this fixes a bug, you need to add a line with

BUG: <num>

In D16047#339616, @yurchor wrote:

Oops... Arcanist is not the answer to any question on KDE commits (Luigi, please...).

1. Please remove Dolphin directory file from the commit.
2. Change the title to something like "Fix sublist expanding on the left panel".
3. Add "BUG: 399275" to the description.
   
   or
   
   Luigi, if you do not mind, can I process this oneliner in an appropriate way?

In D15880#337021, @ltoscano wrote:

In D15880#337020, @pavelmos wrote:

In D15880#335630, @ltoscano wrote:

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Thank you.
Unfortunately, I can't use Arcanist as it is not included in AltLinux.

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

I guess we need to link that inside https://community.kde.org/Infrastructure/Phabricator#Installing_Arcanist

In D15880#335630, @ltoscano wrote:

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)