Feed Advanced Search

Sun, Jun 30

abika added a project to D22177: Panel: Improve open actions in context menu: Krusader.
Sun, Jun 30, 6:11 PM · Krusader
abika requested review of D22177: Panel: Improve open actions in context menu.
Sun, Jun 30, 6:11 PM · Krusader
abika added a comment to D21420: Ignore Synchronize Folders redundant resize.

Sorry for the very long delay.
I tested this but unfortunately there is still the same faulty behaviour.
The first resize event for me has the size
(1019, 651)
the second one the correct (1920, 1019). But e->oldSize().width() is returning 100 here so the computation is still wrong.

Sun, Jun 30, 5:27 PM
abika added a project to D22174: Synchronizer: Set column headers to adjust widths automatically: Krusader.
Sun, Jun 30, 5:04 PM · Krusader
abika requested review of D22174: Synchronizer: Set column headers to adjust widths automatically.
Sun, Jun 30, 5:03 PM · Krusader

Jun 2 2019

abika added a comment to D21323: Shortcuts for move tab.

@gengisdave : A comment would be nice. Thanks.

Jun 2 2019, 3:04 PM · Krusader

May 25 2019

abika accepted D21323: Shortcuts for move tab.

Looks good. Thanks for the improvement!

May 25 2019, 4:56 PM · Krusader

May 5 2019

abika added a comment to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks Nikita! Changes applied and pushed into maste.

May 5 2019, 7:24 PM · Krusader
abika updated the diff for D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
  • fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
May 5 2019, 7:18 PM · Krusader

Apr 22 2019

abika added a project to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime): Krusader.
Apr 22 2019, 3:58 PM · Krusader
abika requested review of D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
Apr 22 2019, 3:57 PM · Krusader

Apr 13 2019

abika accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).

After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.

Apr 13 2019, 4:40 PM · Krusader
abika abandoned D19623: Replace all usages QOverload with static_cast.

Discarded in favour of D20373.

Apr 13 2019, 4:32 PM

Mar 8 2019

abika added a comment to D19277: Create new text files with umask applied.

Thanks! Landed (Hope this revision will close itself).

Mar 8 2019, 7:45 PM · Krusader
abika requested review of D19623: Replace all usages QOverload with static_cast.
Mar 8 2019, 7:18 PM

Mar 3 2019

abika updated the summary of D19277: Create new text files with umask applied.
Mar 3 2019, 7:16 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

Mar 3 2019, 7:07 PM · Krusader
abika updated the diff for D19277: Create new text files with umask applied.
  • SQUASH_ME Panel: Create new local text files directly with QFile
Mar 3 2019, 7:05 PM · Krusader

Feb 24 2019

abika added a comment to D19104: Search: Improve right-click context menu.

Thanks for the reviews!

Feb 24 2019, 5:08 PM · Krusader
abika added a comment to D15987: Automatic code linting using clang-tidy..

Thanks for the review!

Feb 24 2019, 4:46 PM
abika accepted D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks. Working fine.

Feb 24 2019, 4:17 PM · Krusader
abika added a project to D19277: Create new text files with umask applied: Krusader.
Feb 24 2019, 4:02 PM · Krusader
abika requested review of D19277: Create new text files with umask applied.
Feb 24 2019, 4:01 PM · Krusader

Feb 17 2019

abika added a project to D19104: Search: Improve right-click context menu: Krusader.
Feb 17 2019, 8:03 PM · Krusader
abika requested review of D19104: Search: Improve right-click context menu.
Feb 17 2019, 8:02 PM · Krusader

Feb 14 2019

abika accepted D18880: Register krusader as handler of inode/directory.

Thanks!

Feb 14 2019, 7:15 PM
abika added a comment to D15987: Automatic code linting using clang-tidy..

Please check again.

Feb 14 2019, 5:02 PM
abika updated the diff for D15987: Automatic code linting using clang-tidy..
  • Panel: Simplify handling escape key to close search bar when panel is focused
Feb 14 2019, 4:59 PM

Nov 11 2018

abika accepted D16689: Replaced old connect() with QT5 style. Part 3.

Please get rid of the dynamic casts. Everything else is fine. Thanks!

Nov 11 2018, 1:53 PM

Oct 15 2018

abika added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 15 2018, 7:04 PM · Krusader
abika accepted D16223: Replaced old connect() with QT5 style. Part 1.

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Oct 15 2018, 6:43 PM · Krusader
abika added a project to D16223: Replaced old connect() with QT5 style. Part 1: Krusader.
Oct 15 2018, 6:28 PM · Krusader

Oct 6 2018

abika added a comment to D15987: Automatic code linting using clang-tidy..

Thanks Yuri! That should have not been included in here.

Oct 6 2018, 7:36 PM
abika updated the diff for D15987: Automatic code linting using clang-tidy..
  • fixup! Automatic code linting using clang-tidy.
Oct 6 2018, 7:33 PM
abika requested review of D15987: Automatic code linting using clang-tidy..
Oct 6 2018, 7:19 PM
abika added a comment to T2966: Code Cleaning.

Hi Miro,

Oct 6 2018, 3:28 PM · Krusader

Oct 4 2018

abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Oct 4 2018, 7:22 PM · Krusader

Sep 3 2018

abika added a comment to T9581: Publish Krusader in the Microsoft Store.

Hi Lydia and everyone else,

Sep 3 2018, 7:20 PM · Krusader, Windows

Aug 12 2018

abika closed D14265: Search: Simplify result tab layout in search dialog.

pushed. Forgot to include the link to this Diff in the commit message:/

Aug 12 2018, 3:59 PM · Krusader

Jul 21 2018

abika added a project to D14265: Search: Simplify result tab layout in search dialog: Krusader.
Jul 21 2018, 4:29 PM · Krusader
abika requested review of D14265: Search: Simplify result tab layout in search dialog.
Jul 21 2018, 4:27 PM · Krusader

Jul 14 2018

abika added a comment to T8661: In the developer documentation: add how to know when a Krusader bug report is created (or changed).

Oh, sorry. Yes, this was lost.
But simply add to the documentation what you think is importance. The wiki is a collaboration tool with edit history for us developers and users No need to ask for permission imo.

Jul 14 2018, 2:07 PM · Krusader

Jul 9 2018

abika added a comment to T6237: Replace virtual:/ protocol with KIO-Stash.

Sry, I know not more than https://www.startpage.com/do/search?q=python+kio. You should ask on kde-devel@kde.org.

Jul 9 2018, 6:28 PM · Krusader
abika added a comment to T6237: Replace virtual:/ protocol with KIO-Stash.

Tell me this - can other command line applications interact with stash:// ?

Jul 9 2018, 7:38 AM · Krusader

Jul 8 2018

abika closed D13572: Panel: Always delete files by their URL.

Took some time but now its in master.

Jul 8 2018, 7:35 PM · Krusader

Jun 16 2018

abika requested review of D13572: Panel: Always delete files by their URL.
Jun 16 2018, 5:06 PM · Krusader

Jun 13 2018

abika requested changes to D13497: Files fed to listbox can be deleted.
Jun 13 2018, 7:27 PM · Krusader
abika added a comment to D13497: Files fed to listbox can be deleted.

Explanation, as this is my code:
The files()->isRoot() condition is intended. Virtual deletion is only possible when the current directory is the root of vfs:// containing virtual directories. Deletion (== physical deletion OR moveToTrash) should be possible inside the virtual directories the normal way with the Delete key, F11, etc.. This has always been like that (or as far as i know Krusader), I only refactored the code.

Jun 13 2018, 7:26 PM · Krusader

May 20 2018

abika added a comment to D13007: Synchronizer: Rework.

Please see commit message. If not stated, the functionality/behaviour should not have changed.

May 20 2018, 7:15 PM
abika requested review of D13007: Synchronizer: Rework.
May 20 2018, 7:04 PM
abika added a comment to T8761: Synchronizer Rework.

Hi Martin,
yes, I wanted to work on it and did already some refactoring a year ago but never published it. Now I did a fresh rebase and pushed it to synchronizer/rework. Unfortunately I stopped in the middle of the work and the current state is unfinished and not working.

May 20 2018, 7:02 PM · Krusader
abika added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

Thanks everybody! I changed the shortcut for "select in folder" to CTRL+SHIFT+S before pushing.

May 20 2018, 6:34 PM

May 12 2018

abika added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

Oh, yes of course. I initially introduced the combobox for the "start on typing" feature and its obviously still valid for this.
Thanks for pointing this out, diff is adjusted.

May 12 2018, 6:12 PM
abika updated the diff for D12640: Replace default search bar search mode setting with dedicated shortcuts.
  • Use default search bar search mode setting always on "start by typing"
May 12 2018, 6:09 PM

May 1 2018

abika added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

Discussed here: https://bugs.kde.org/show_bug.cgi?id=391946

May 1 2018, 5:36 PM
abika requested review of D12640: Replace default search bar search mode setting with dedicated shortcuts.
May 1 2018, 5:33 PM

Apr 9 2018

abika added a comment to D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.

Thanks for testing and review!

Apr 9 2018, 6:13 PM

Apr 2 2018

abika added a comment to D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.

Thanks for testing!
I thought I tested the first behaviour. But probably did changes after that :/
And the second one is strange, don't know exactly why the current is lost only in this particular case.

Apr 2 2018, 5:52 PM
abika updated the diff for D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.
  • Panel: Fix current item not selected when going back in history
  • Panel: Fix lost current if the previous item is removed
Apr 2 2018, 5:49 PM

Mar 31 2018

abika added a comment to D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.

Oh, fu... this seems to be a replacement for D11699. Didn't see this first, i just get too many mails recently.

Mar 31 2018, 5:49 PM
abika requested review of D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.
Mar 31 2018, 5:08 PM

Jan 23 2018

abika reopened D9041: Ability to ignore defined files and directories from search results.

I pushed a new branch arcpatch-D9041 with Diff 24441 and the patch file. Merging was not that trivial.
And I already made some fixes but its not done yet (and uncommited).

Jan 23 2018, 7:32 PM · Krusader

Jan 21 2018

abika updated subscribers of D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

As I understand it, the problem is that plugins installed to PREFIX/lib/qt/plugins won't always be be found depending on PREFIX.
It will work for "/usr" and probably "/usr/local" (can you confirm the latter, Martin? I didn't test it).
But if I install e.g. to a directory in the Krusader source directory (a quick local installation for testing) the plugins won't work. And this will may be left unnoticed by the user.

Jan 21 2018, 4:18 PM · Krusader

Nov 29 2017

abika requested changes to D9041: Ability to ignore defined files and directories from search results.

And I can confirm the crash in Synchronizer. The checkbox useIgnoredPaths is not initialized here. Should be set to nullptr and checked for it before access. (Crash is in generalFilter.cpp line 547).

Nov 29 2017, 8:51 PM · Krusader
abika added a comment to D9041: Ability to ignore defined files and directories from search results.

Thanks for your contribution! Excluding by folder names is a good idea and very useful.
However, having the string definitions in the configuration settings doesn't feel "right" for me. There is now a checkbox in the search dialog, but the actual folders can only be set in another dialog far away.
Why not combining both, e.g. with a KHistoryComboBox (the main "Search for: " edit line is an example) in the search dialog? This way you have only one GUI element, you can quickly edit it, or clear it, and you have even a history.

Nov 29 2017, 8:35 PM · Krusader

Sep 17 2017

abika edited the content of Krusader.
Sep 17 2017, 6:22 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:13 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:08 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:08 PM · Krusader

Aug 5 2017

abika added a comment to D6850: KrViewer looses focus - fixed.

Sorry, toke me some time. I corrected a typo in one of the BUG: references. Thanks for the patch!

Aug 5 2017, 6:16 PM · Krusader

Jul 29 2017

abika added a comment to D3491: Fix compile warning in krArc.

Merged to make Albert happy (https://marc.info/?l=kde-devel&m=150096948115456&w=2).

Jul 29 2017, 6:19 PM · Krusader

Jul 22 2017

abika accepted D6788: Resolves T1971 with no further code changes.

Good!

Jul 22 2017, 5:06 PM

Jul 17 2017

abika closed T6514: kio_thumbnail errors as Invalid.
  1. Please use Bugzilla and not Phabricator for bugs and feature requests, like stated here: https://krusader.org/report-bugs/index.html
  2. Krusader 2.4 is outdated. Please try again with 2.5/2.6
  3. Information is missing about what you are actually doing while getting the error messages. Browsing facebook with Krusader?
Jul 17 2017, 5:58 PM · Krusader

Jul 11 2017

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Merged. Thanks for the patch!

Jul 11 2017, 8:18 PM · Krusader

Jul 6 2017

abika moved T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) from TODO to In progress on the Krusader board.
Jul 6 2017, 6:13 PM · Krusader
abika accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

Jul 6 2017, 6:06 PM · Krusader

Jul 4 2017

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

Jul 4 2017, 7:08 PM · Krusader

Jul 3 2017

abika added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 3 2017, 6:48 PM · Krusader

Jul 2 2017

abika added a comment to T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).

Jul 2 2017, 4:13 PM · Krusader

Jun 5 2017

abika moved T3419: Rework of VFS (Now: FileSystem) from In progress to Done on the Krusader board.

Finally mark this done.

Jun 5 2017, 2:58 PM · Krusader
abika renamed T3419: Rework of VFS (Now: FileSystem) from Rework of VFS to Rework of VFS (Now: FileSystem).
Jun 5 2017, 2:58 PM · Krusader

Jun 3 2017

abika edited the content of Krusader.
Jun 3 2017, 2:30 PM · Krusader
abika added a comment to D6010: Changes/Fixes for tab labels.

Merged. Let's see if somebody will complain...

Jun 3 2017, 1:45 PM

May 31 2017

abika created T6237: Replace virtual:/ protocol with KIO-Stash.
May 31 2017, 5:18 PM · Krusader

May 29 2017

abika created D6010: Changes/Fixes for tab labels.
May 29 2017, 12:06 PM

May 14 2017

abika added a comment to D4552: [PreviewJob] Remove maximum size for local files by default.

File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks.

May 14 2017, 2:14 PM · Frameworks

May 12 2017

abika added a comment to D5734: Fix lister unintended selection while scrolling.

I usually never user krViewer.

May 12 2017, 5:32 PM · Krusader
abika accepted D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.

May 12 2017, 5:20 PM · Krusader

May 10 2017

abika added a comment to D5776: Show a lock icon for Locked tabs.

Thanks Martin! Not a surprise I missed something again during testing:/

May 10 2017, 6:38 PM

May 8 2017

abika added a comment to D5714: Fix build with gcc 4.8.

Thanks for the info. Problem is I can't switch to GCC4.8 (not even an official package in Arch Linux repos) and the CI doesn't cover this either.

May 8 2017, 6:23 PM
abika updated the summary of D5776: Show a lock icon for Locked tabs.
May 8 2017, 5:52 PM
abika created D5776: Show a lock icon for Locked tabs.
May 8 2017, 5:48 PM
abika accepted D5744: Fix loading a panel profile with locked tabs.

Yes, I can reproduce this. Looks like I solved an issue and created a new one.

May 8 2017, 5:42 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:39 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:21 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:19 PM · Krusader
abika accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Alex, please check if I understood right the code combining and code comment.

May 8 2017, 2:42 PM · Krusader

May 7 2017

abika added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.

May 7 2017, 10:12 PM · Krusader
abika added a comment to D5744: Fix loading a panel profile with locked tabs.

When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.

May 7 2017, 4:51 PM · Krusader
abika added a comment to D5714: Fix build with gcc 4.8.

Oh damn, I overlooked this again. The title lead me to believe this is something unimportant in kde-devel.

May 7 2017, 3:35 PM