Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled
ClosedPublic

Authored by asensi on Jul 22 2019, 10:06 PM.

Details

Summary

Achieve that Krusader searches correctly if the the "Follow links" checkbox is disabled (note: it's the default).

This change is aimed to solve https://bugs.kde.org/show_bug.cgi?id=410120

Test Plan

The test folder mentioned in https://bugs.kde.org/show_bug.cgi?id=410120 can be used to search anything in it (having the "Follow links" checkbox disabled, which is the default).

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Jul 22 2019, 10:06 PM
asensi created this revision.
nmel accepted this revision.Sun, Jul 28, 6:48 AM

It works properly now - thanks!
I checked the commit you mentioned in the bug. Before it the checkbox was still ignored but the links were always not followed.

This revision is now accepted and ready to land.Sun, Jul 28, 6:48 AM
nmel added a comment.Wed, Jul 31, 4:25 PM

If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.

This revision was automatically updated to reflect the committed changes.
asensi retitled this revision from Achieve that Krusader searches correctly if the the "Follow links" checkbox is disabled to Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.Thu, Aug 1, 8:38 PM

I agree with you, Nikita. Thanks for testing and all the information!

abika added a comment.Sun, Aug 4, 3:28 PM

Ah, FileItem::isDir() can also return true for symlinks. Thanks again for fixing the bug i introduced, Toni!

(QFileInfo::isDir() has the same (documented) behaviour and I guess KFileItem::isDir() as well.)

If any developer is reading this, he'll probably know that those developments end up being a very complex subject. Thank you for all the source code, Alex!