Differential D16689

Replaced old connect() with QT5 style. Part 3
ClosedPublic
Actions

Authored by mchabrecek on Nov 5 2018, 4:52 PM.

Details

Reviewers

abika

Group Reviewers

Krusader

Commits

R167:2df3af6c3d7f: Replaced old connect() with QT5 style. Part 3

Summary

Replacing connect() lines with the new signal/slot syntax in Qt5. Details: https://wiki.qt.io/New_Signal_Slot_Syntax.

There many of them. This is the third part.

Diff Detail

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mchabrecek requested review of this revision.Nov 5 2018, 4:52 PM

mchabrecek created this revision.

Harbormaster completed remote builds in B4599: Diff 44922.Nov 5 2018, 4:52 PM

mchabrecek added a reviewer: Krusader.Nov 6 2018, 7:56 AM

yurchor added a subscriber: yurchor.Nov 10 2018, 4:38 PM

yurchor added inline comments.

krusader/KViewer/lister.cpp
1933–1934	Maybe it would be better to declare KIO::TransferJob *saveJob = KIO::put(url, -1, KIO::Overwrite); and avoid dynamic casts?

Please get rid of the dynamic casts. Everything else is fine. Thanks!

krusader/KViewer/lister.cpp
1933–1934	yes, i agree.
krusader/Konfigurator/krresulttable.cpp
200	here, too: better change the type of `_label` to `KUrlLabel`
krusader/Panel/krlayoutfactory.cpp
305	And here, too: please change the type of `frame` to `ListPanelFrame` and `panel` to `ListPanel`.
krusader/Synchronizer/synchronizerdirlist.cpp
146–148	And here, too: please change the type of `job` to `ListJob`.

This revision is now accepted and ready to land.Nov 11 2018, 1:53 PM

Remove some dynamic casts

Harbormaster completed remote builds in B4863: Diff 45345.Nov 12 2018, 10:10 AM

Can I push it now to the master?

Thank you,
Miro

krusader/Konfigurator/krresulttable.cpp
200	_label as QLabel is used for creating more compoments, many of them are Qlabels, so it won't work without bigger refactoring. So I won't change it
krusader/Panel/krlayoutfactory.cpp
305	Panel to ListPanel is not so strait forward. It forces dynamic cast at KrLayoutFactory constructor: ../Panel/krlayoutfactory.h:39:103: error: invalid conversion from ‘QWidget’ to ‘ListPanel’ [-fpermissive] KrLayoutFactory(QWidget panel, QHash<QString, QWidget> &widgets) : panel(panel), widgets(widgets) {} So I won't change it

In D16689#358275, @mchabrecek wrote:

Can I push it now to the master?

Thank you,
Miro

I guess so. At least, no objections from me. Thanks for your patience.

Closed by commit R167:2df3af6c3d7f: Replaced old connect() with QT5 style. Part 3 (authored by mchabrecek). · Explain WhyNov 15 2018, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krusader/Archive/abstractthreadedjob.cpp (2 lines)
M			krusader/Dialogs/krpleasewait.cpp (2 lines)
M			krusader/DiskUsage/diskusagegui.cpp (2 lines)
M			krusader/DiskUsage/dulines.cpp (2 lines)
M			krusader/FileSystem/sizecalculator.cpp (2 lines)
M			krusader/Filter/generalfilter.cpp (4 lines)
M			krusader/GUI/kcmdline.cpp (8 lines)
M			krusader/GUI/terminaldock.cpp (2 lines)
M			krusader/KViewer/krviewer.cpp (6 lines)
M			krusader/KViewer/lister.h (4 lines)
M			krusader/KViewer/lister.cpp (15 lines)
M			krusader/KViewer/panelviewer.cpp (14 lines)
M			krusader/Konfigurator/konfiguratoritems.cpp (34 lines)
M			krusader/Konfigurator/krresulttable.cpp (3 lines)
M			krusader/Locate/locate.cpp (29 lines)
M			krusader/MountMan/kmountmangui.cpp (22 lines)
M			krusader/Panel/PanelView/krinterbriefview.cpp (7 lines)
M			krusader/Panel/PanelView/krinterdetailedview.cpp (6 lines)
M			krusader/Panel/krlayoutfactory.cpp (7 lines)
M			krusader/Panel/krpreviewjob.cpp (8 lines)
M			krusader/Panel/krpreviewpopup.cpp (5 lines)
M			krusader/Panel/listpanel.h (4 lines)
M			krusader/Panel/listpanel.cpp (69 lines)
M			krusader/Panel/listpanelframe.h (2 lines)
M			krusader/Search/krsearchdialog.cpp (18 lines)
M			krusader/Splitter/combiner.cpp (20 lines)
M			krusader/Splitter/splitter.cpp (21 lines)
M			krusader/Splitter/splittergui.cpp (8 lines)
M			krusader/Synchronizer/synchronizedialog.cpp (6 lines)
M			krusader/Synchronizer/synchronizer.cpp (18 lines)
M			krusader/Synchronizer/synchronizerdirlist.cpp (8 lines)
M			krusader/Synchronizer/synchronizergui.cpp (77 lines)
M			krusader/Synchronizer/synchronizertask.cpp (22 lines)
M			krusader/UserAction/kraction.cpp (23 lines)
M			krusader/panelmanager.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44922	4654ac3		Nov 5 2018, 4:52 PM	★	★
Diff 2	45345	4654ac3	- Remove some dynamic casts	Nov 12 2018, 10:10 AM	★	★
Diff 3	45553	4654ac3	R167:2df3af6c3d7f61afeb6ee21908f582dd31e96a55	Nov 15 2018, 9:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
417bf395f0c2	bb08039c0fd7	fe036d6bc241	Miroslav Chabrecek	Remove some dynamic casts	Nov 12 2018, 10:10 AM
fe036d6bc241	a6a4c73210e1	4654ac3bc7dd	Miroslav Chabrecek	Replaced old connect() with QT5 style. Part 3 (Show More…)	Nov 5 2018, 4:51 PM