Shortcuts for move tab
ClosedPublic

Authored by gengisdave on Tue, May 21, 7:00 PM.

Details

Reviewers
nmel
asensi
abika
Group Reviewers
Krusader
Summary

This adds two new actions to tab popup (with relative harcoded shortcuts) to move the current tab to the left or right.

You can move the first tab to to left or the last one to the right.

FIXED: [ 328937 ] Shortcuts for move tab
BUG: 328937

Test Plan

I'm not sure if some action should be called after moveTab().

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.Tue, May 21, 7:00 PM
gengisdave created this revision.

Tested to compile, install and work as expected.

+1

nmel accepted this revision.Wed, May 22, 6:58 AM
nmel added a subscriber: nmel.

Thanks Davide!

Just a few minor corrections in the commit message needed:

This adds two new actions to tab popup (with relative harcoded shortcuts) to move the current tab to the left or right.
You can move the first tab to to left or the last one to the right.

harcoded -> hardcoded
can -> can't
to to -> to

This revision is now accepted and ready to land.Wed, May 22, 6:58 AM
asensi accepted this revision.Sat, May 25, 7:09 AM
asensi added a subscriber: asensi.

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

abika accepted this revision.Sat, May 25, 4:56 PM
abika added a subscriber: abika.

Looks good. Thanks for the improvement!

krusader/panelmanager.cpp
258

Isn't this check unnecessary as it is logically covered by the next one?

269

Same here?

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

abika added a comment.Sun, Jun 2, 3:04 PM

@gengisdave : A comment would be nice. Thanks.

gengisdave updated this revision to Diff 59431.Sun, Jun 9, 6:20 AM

Removed the single tab check in favor of a comment, like proposed by @abika

gengisdave marked 2 inline comments as done.Sun, Jun 9, 6:21 AM
nmel accepted this revision.Fri, Jun 14, 5:25 AM

New revision is also good - feel free to push to master.

gengisdave closed this revision.Sun, Jun 16, 11:10 AM

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab