Shortcuts for move tab
ClosedPublic
Actions

Authored by gengisdave on May 21 2019, 7:00 PM.

Details

Reviewers

nmel
asensi
abika

Group Reviewers

Krusader

Summary

This adds two new actions to tab popup (with relative harcoded shortcuts) to move the current tab to the left or right.

You can move the first tab to to left or the last one to the right.

FIXED: [ 328937 ] Shortcuts for move tab
BUG: 328937

Test Plan

I'm not sure if some action should be called after moveTab().

Diff Detail

Repository

R167 Krusader

Lint

Lint Skipped

Unit

Unit Tests Skipped

gengisdave requested review of this revision.May 21 2019, 7:00 PM

gengisdave created this revision.

Tested to compile, install and work as expected.

Thanks Davide!

Just a few minor corrections in the commit message needed:

This adds two new actions to tab popup (with relative harcoded shortcuts) to move the current tab to the left or right.
You can move the first tab to to left or the last one to the right.

harcoded -> hardcoded
can -> can't
to to -> to

This revision is now accepted and ready to land.May 22 2019, 6:58 AM

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

Looks good. Thanks for the improvement!

krusader/panelmanager.cpp
258	Isn't this check unnecessary as it is logically covered by the next one?
269	Same here?

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

@gengisdave : A comment would be nice. Thanks.

Removed the single tab check in favor of a comment, like proposed by @abika

gengisdave marked 2 inline comments as done.Jun 9 2019, 6:21 AM

New revision is also good - feel free to push to master.

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab

Revision Contents
Changeset List

			Path	Packages
M			krusader/panelmanager.h (2 lines)
M			krusader/panelmanager.cpp (18 lines)
M			krusader/paneltabbar.cpp (2 lines)
M			krusader/tabactions.h (3 lines)
M			krusader/tabactions.cpp (14 lines)