Remove 'isExiting' logic from closing sequence
AcceptedPublic

Authored by abika on Sun, Aug 4, 5:25 PM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Summary

The flag was preventing Krusader from exiting if Krusader::queryClose() was
called but the exit was later cancelled (e.g. by a file save dialog of
KrViewer).

And the destructor Krusader::~Krusader() is not called on a SIGTERM signal
anyways.

FIXED: [ 409473 ] Computer shutdown gets cancelled
BUG: 409473

AND

Fix main window beeing closed to tray instead of exit on session logout

Test Plan

Tested exit behaviour on session logout and normal close request.

Diff Detail

Repository
R167 Krusader
Branch
my-fix-session-logout-arc
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14737
Build 14755: arc lint + arc unit
abika requested review of this revision.Sun, Aug 4, 5:25 PM
abika created this revision.
abika added a subscriber: Krusader.
asensi accepted this revision as: asensi.Mon, Aug 5, 5:23 AM
asensi added a subscriber: asensi.

The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:

  • when its internal editor is not used,
  • when its internal editor has a file that is not saved,
  • when its internal editor has a file that is not saved and the computer is asked to reboot.

Other people can do their checks. Thanks, Alex!

This revision is now accepted and ready to land.Mon, Aug 5, 5:23 AM