In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

Thanks for reply

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

You have to make the changes requested by Nikita.

In D16223#344206, @nmel wrote:

In D16223#344018, @mchabrecek wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

I can push it, I might need some help, what is the best way :
Merge my branch to master and then push the master? Is there some thing else needed?

In D16223#344206, @nmel wrote:

In D16223#344018, @mchabrecek wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Thank you,
Miro

In D16223#344556, @mchabrecek wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

In D16223#345641, @nmel wrote:

In D16223#344556, @mchabrecek wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Thank you !

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Sure.

Can you follow these instructions?

https://community.kde.org/Infrastructure/Get_a_Developer_Account

BTW, many thanks for your work!