FileSystem: Fix using creation time from KIO as changed time (ctime)
ClosedPublic

Authored by abika on Mon, Apr 22, 3:57 PM.

Details

Summary

Added new field to FileItem instead. And do not show dummy value in UI for
missing file times - also for other time types.

FIXED: [ 397398 ] Misleading ‘Created’ date in file properties
BUG: 397398

Test Plan

Tested correct file times for files in

  • local/default file system
  • KIO protocol file system (smb)k

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.Mon, Apr 22, 3:57 PM
abika created this revision.
abika added a subscriber: Krusader.
huftis added a subscriber: huftis.Mon, Apr 22, 7:09 PM
nmel accepted this revision.Sat, Apr 27, 3:47 AM
nmel added a subscriber: nmel.

Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.

krusader/FileSystem/fileitem.cpp
207–210

better use functions, i.e. getModificationTime, getchangeTime, to align with the rest of the code

krusader/FileSystem/fileitem.h
59

change time

61

creation time

101–105

getChangeTime

102

change time

145

change time

This revision is now accepted and ready to land.Sat, Apr 27, 3:47 AM
abika updated this revision to Diff 57606.Sun, May 5, 7:18 PM
abika marked 6 inline comments as done.
  • fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
Closed by commit R167:0920b04b4a84: FileSystem: Fix using creation time from KIO as changed time (ctime) (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhySun, May 5, 7:23 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.Sun, May 5, 7:24 PM

Thanks Nikita! Changes applied and pushed into maste.