Feed Advanced Search

Apr 28 2020

dvratil requested review of D29252: Port 'Add To Addressbook' action to Akonadi::TagWidget.
Apr 28 2020, 12:51 PM · KDE PIM
dvratil committed R165:dd761e0d86a2: Fix TagWidget's lineedit not being read-only (authored by dvratil).
Fix TagWidget's lineedit not being read-only
Apr 28 2020, 12:50 PM
dvratil added a reviewer for D29241: Replace QRegExp with QRegularExpression: KDE PIM.
Apr 28 2020, 7:46 AM · KDE PIM

Apr 27 2020

dvratil committed R208:77d485b5ae39: Use Akonadi::ServerManager to get a DBus service name of an agent (authored by dvratil).
Use Akonadi::ServerManager to get a DBus service name of an agent
Apr 27 2020, 1:00 PM
dvratil committed R205:cb0757071703: Use Akonadi::ServerManager to get a DBus service name of an agent (authored by dvratil).
Use Akonadi::ServerManager to get a DBus service name of an agent
Apr 27 2020, 12:56 PM
dvratil created T13049: [Akonadi] Basic C++ wrapper for resource's /Settings DBus interfaces.
Apr 27 2020, 10:42 AM · KDE PIM
dvratil accepted D29217: [KJots] Port to NoteMessageWrapper.

Thanks for the fixes.

Apr 27 2020, 10:36 AM · KDE PIM
dvratil committed R199:36c9484ba5ad: Merge branch 'release/20.04' (authored by dvratil).
Merge branch 'release/20.04'
Apr 27 2020, 10:34 AM
dvratil committed R199:f8ec920d883c: Port away from a DBus call to deprecated KConfigSkeleton::writeConfig() (authored by dvratil).
Port away from a DBus call to deprecated KConfigSkeleton::writeConfig()
Apr 27 2020, 10:33 AM
dvratil accepted D28523: Save configuration when creating resources for new user.

Nice catch! Thanks a lot for the patch.

Apr 27 2020, 10:31 AM · KDE PIM
dvratil accepted D29148: [KJotsWidget] Fix several KJotsEdit focus issues (race condition).
Apr 27 2020, 10:23 AM · KDE PIM
dvratil accepted D28994: Fix sorting & tabs preset in config file.

Looks OK, thanks for the patch.

Apr 27 2020, 10:22 AM · KDE PIM
dvratil requested changes to D29217: [KJots] Port to NoteMessageWrapper.
Apr 27 2020, 10:17 AM · KDE PIM
dvratil accepted D29187: T6445 Fix order of the GnuPG option groups.

Nicely done, thanks for the patch.

Apr 27 2020, 10:09 AM · KDE PIM: Kleopatra, KDE PIM
dvratil committed R42:3d8fb2fa2342: Merge branch 'release/20.04' (authored by dvratil).
Merge branch 'release/20.04'
Apr 27 2020, 10:06 AM
dvratil committed R42:432945a88dc5: Use get_description() instead of get_error_message() to obtain Xapian… (authored by acracan).
Use get_description() instead of get_error_message() to obtain Xapian…
Apr 27 2020, 10:05 AM
dvratil closed D29164: Use get_description() instead of get_error_message() to obtain Xapian DatabaseError exception string..
Apr 27 2020, 10:05 AM · KDE PIM
dvratil accepted D29164: Use get_description() instead of get_error_message() to obtain Xapian DatabaseError exception string..

Good catch, thanks.

Apr 27 2020, 10:03 AM · KDE PIM
dvratil accepted D29162: [KJots] Drop custom internal links, use akonadi default ones.

Good idea, thanks.

Apr 27 2020, 10:02 AM · KDE PIM
dvratil added inline comments to D29148: [KJotsWidget] Fix several KJotsEdit focus issues (race condition).
Apr 27 2020, 10:00 AM · KDE PIM

Apr 24 2020

dvratil accepted D29094: [KJotsEdit] Fix links handling in editing mode.
Apr 24 2020, 9:56 AM · KDE PIM
dvratil accepted D28761: T6445 Fix order of the GnuPG options.
Apr 24 2020, 7:38 AM · KDE PIM: Kleopatra, KDE PIM
dvratil added a comment to D28775: [KJots] Fix bookmarks actions.

@poboiko just bump the dependency

Apr 24 2020, 7:32 AM · KDE PIM
dvratil accepted D29087: [KJotsTreeView] Fix "copy link address" action.
Apr 24 2020, 7:25 AM · KDE PIM
dvratil requested changes to D29094: [KJotsEdit] Fix links handling in editing mode.

Nice work, just a small nitpick :)

Apr 24 2020, 7:24 AM · KDE PIM

Apr 22 2020

dvratil requested changes to D29087: [KJotsTreeView] Fix "copy link address" action.
Apr 22 2020, 12:07 PM · KDE PIM
dvratil added a comment to D28903: Akonadi server should not expect specific mysql server process name.

The patch still correct, though. The assumption that the process is always called simply mysqld is wrong.

Apr 22 2020, 7:09 AM · KDE PIM
dvratil accepted D29073: [KJots] Port bookmarks code, unify link handling code.
Apr 22 2020, 7:07 AM · KDE PIM

Apr 21 2020

dvratil accepted D29053: Fix plain text template.
Apr 21 2020, 6:59 PM · KDE PIM
dvratil accepted D29045: [KJots] Revive printing support.

Thanks!

Apr 21 2020, 6:59 PM · KDE PIM
dvratil added inline comments to D29030: AppArmor DBus rules for AkonadiServer.
Apr 21 2020, 6:58 PM · KDE PIM
dvratil accepted D29060: Port placeholder message to Kirigami.PlaceholderMessage.
Apr 21 2020, 6:57 PM · Plasma
dvratil requested changes to D29045: [KJots] Revive printing support.
Apr 21 2020, 2:26 PM · KDE PIM
dvratil accepted D29048: [KJots] Translate statusbar messages.
Apr 21 2020, 2:23 PM · KDE PIM
dvratil accepted D29047: [KJots] Remove ancient migration code.
Apr 21 2020, 11:36 AM · KDE PIM
dvratil committed R44:114d93863dad: Bump required Akonadi version (authored by dvratil).
Bump required Akonadi version
Apr 21 2020, 11:33 AM
dvratil closed D28957: Migrator: implement Google Resource migrator.
Apr 21 2020, 11:33 AM · KDE PIM
dvratil committed R44:97c896cae59e: Migrator: implement Google Resource migrator (authored by dvratil).
Migrator: implement Google Resource migrator
Apr 21 2020, 11:33 AM
dvratil committed R44:639a3670f0f0: Build the shared migrator code as a static library (authored by dvratil).
Build the shared migrator code as a static library
Apr 21 2020, 11:33 AM
dvratil requested changes to D29045: [KJots] Revive printing support.
Apr 21 2020, 11:28 AM · KDE PIM
dvratil accepted D29044: [KJots] Port deprecated code.
Apr 21 2020, 11:26 AM · KDE PIM
dvratil accepted D28560: [resources] Add a unified Google Groupware Resource.

Thanks a lot for your work! You can land the patch now.

Apr 21 2020, 10:13 AM · KDE PIM
dvratil committed R165:f51e623afce8: Bump Akonadi version (authored by dvratil).
Bump Akonadi version
Apr 21 2020, 10:12 AM
dvratil committed R165:b0f046481eff: AkonadiControl: expose agent instances of unknown types too (authored by dvratil).
AkonadiControl: expose agent instances of unknown types too
Apr 21 2020, 10:12 AM
dvratil updated the diff for D28957: Migrator: implement Google Resource migrator.
  • Check if the resource instance is actually running before waiting for it to stop
Apr 21 2020, 10:10 AM · KDE PIM
dvratil updated subscribers of D29030: AppArmor DBus rules for AkonadiServer.

@knauss, could you please take a look at this? I have no clue about apparmor... :)

Apr 21 2020, 8:57 AM · KDE PIM

Apr 20 2020

dvratil accepted D28975: Use KDE Jekyll Theme.

I see, thanks for explanation.

Apr 20 2020, 7:24 PM
dvratil planned changes to D28957: Migrator: implement Google Resource migrator.

I just realized a problem: if we remove the old Google resources from git, then the code that waits for the DBus interface to disappear will fail, because the resources won't be running in the first place.

Apr 20 2020, 2:46 PM · KDE PIM
dvratil requested changes to D28975: Use KDE Jekyll Theme.

Thanks! Just one comment regarding a removed icon, otherwise it looks good.

Apr 20 2020, 2:17 PM
dvratil accepted D28993: [KJots] Make compiler happier (use overrides, nullptr, explicit, QT_NO_KEYWORDS).
Apr 20 2020, 2:06 PM · KDE PIM
dvratil requested changes to D28761: T6445 Fix order of the GnuPG options.
Apr 20 2020, 2:04 PM · KDE PIM: Kleopatra, KDE PIM
dvratil committed R177:b0529aff00ba: SearchJob: don't assemble OR term recursively (authored by dvratil).
SearchJob: don't assemble OR term recursively
Apr 20 2020, 10:53 AM
dvratil closed D28946: SearchJob: don't assemble OR term recursively.
Apr 20 2020, 10:53 AM · KDE PIM
dvratil committed R177:68facf36edf9: ImapSet: optimize the set before serialization (authored by dvratil).
ImapSet: optimize the set before serialization
Apr 20 2020, 10:52 AM
dvratil closed D28944: ImapSet: optimize the set before serialization.
Apr 20 2020, 10:52 AM · KDE PIM
dvratil updated the diff for D28957: Migrator: implement Google Resource migrator.
  • Fix patch
Apr 20 2020, 10:42 AM · KDE PIM
dvratil updated the diff for D28957: Migrator: implement Google Resource migrator.
  • Remove unused LibKGAPI dependency
  • Make sure we always backup KWallet data before removing instances
  • Fix race condition between the resource wiping the KWallet data and the migrator restoring them
  • Merge enableIntervalCheck and intervalCheckTime configurations from both resources
  • Fix migration when only Contacts resource is set up for an account
Apr 20 2020, 10:41 AM · KDE PIM
dvratil planned changes to D28957: Migrator: implement Google Resource migrator.
Apr 20 2020, 10:41 AM · KDE PIM

Apr 18 2020

dvratil accepted D28775: [KJots] Fix bookmarks actions.
Apr 18 2020, 7:31 PM · KDE PIM
dvratil added reviewers for D28957: Migrator: implement Google Resource migrator: poboiko, vkrause.
Apr 18 2020, 7:15 PM · KDE PIM
dvratil added 2 commit(s) for D28957: Migrator: implement Google Resource migrator: R44:adf8b333e78b: Migrator: implement Google Resource migrator, R44:a01be27f06ae: Build the shared migrator code as a static library.
Apr 18 2020, 7:10 PM · KDE PIM
dvratil added an edge to R44:a01be27f06ae: Build the shared migrator code as a static library: D28957: Migrator: implement Google Resource migrator.
Apr 18 2020, 7:10 PM
dvratil added an edge to R44:adf8b333e78b: Migrator: implement Google Resource migrator: D28957: Migrator: implement Google Resource migrator.
Apr 18 2020, 7:10 PM
dvratil requested review of D28957: Migrator: implement Google Resource migrator.
Apr 18 2020, 7:09 PM · KDE PIM
dvratil committed R44:adf8b333e78b: Migrator: implement Google Resource migrator (authored by dvratil).
Migrator: implement Google Resource migrator
Apr 18 2020, 7:08 PM
dvratil committed R44:a01be27f06ae: Build the shared migrator code as a static library (authored by dvratil).
Build the shared migrator code as a static library
Apr 18 2020, 7:08 PM
dvratil accepted D28560: [resources] Add a unified Google Groupware Resource.
Apr 18 2020, 7:06 PM · KDE PIM
dvratil reopened D28560: [resources] Add a unified Google Groupware Resource.

I accidentally pushed the commit to my dev branch, it's still open :)

Apr 18 2020, 7:06 PM · KDE PIM
dvratil committed R44:d6e8dde2531c: Migrator: implement Google Resource migrator (authored by dvratil).
Migrator: implement Google Resource migrator
Apr 18 2020, 7:03 PM
dvratil committed R44:7702b2142946: Build the shared migrator code as a static library (authored by dvratil).
Build the shared migrator code as a static library
Apr 18 2020, 7:03 PM
dvratil committed R44:5209f761b268: [resources] Add a unified Google Groupware Resource (WIP) (authored by poboiko).
[resources] Add a unified Google Groupware Resource (WIP)
Apr 18 2020, 7:03 PM
dvratil closed D28560: [resources] Add a unified Google Groupware Resource.
Apr 18 2020, 7:03 PM · KDE PIM
dvratil committed R199:5269e737af57: Deserialize QStringList in agent config model (authored by dvratil).
Deserialize QStringList in agent config model
Apr 18 2020, 6:36 PM
dvratil committed R44:fae81064a978: Merge branch 'release/20.04' (authored by dvratil).
Merge branch 'release/20.04'
Apr 18 2020, 5:31 PM
dvratil committed R44:f33a3538fa17: IMAP: MoveItemTask: search new UIDs in batches (authored by dvratil).
IMAP: MoveItemTask: search new UIDs in batches
Apr 18 2020, 5:31 PM
dvratil committed R44:6d4a9dc158f9: IMAP: MoveItemTask - use items() instead of item() (authored by dvratil).
IMAP: MoveItemTask - use items() instead of item()
Apr 18 2020, 5:31 PM
dvratil committed R44:cde208e6cb15: IMAP: fix use-after free in ChangeItemTask (authored by dvratil).
IMAP: fix use-after free in ChangeItemTask
Apr 18 2020, 5:30 PM
dvratil requested review of D28946: SearchJob: don't assemble OR term recursively.
Apr 18 2020, 2:51 PM · KDE PIM
dvratil added a reviewer for D28944: ImapSet: optimize the set before serialization: KDE PIM.
Apr 18 2020, 2:37 PM · KDE PIM
dvratil requested review of D28944: ImapSet: optimize the set before serialization.
Apr 18 2020, 2:33 PM · KDE PIM
dvratil accepted D28938: DAV resource: propagate color changes to the server.
Apr 18 2020, 12:11 PM · KDE PIM
dvratil accepted D28937: EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in the collection.
Apr 18 2020, 12:07 PM · KDE PIM
dvratil committed R165:8d33894c15b2: Merge branch 'release/20.04' (authored by dvratil).
Merge branch 'release/20.04'
Apr 18 2020, 10:49 AM
dvratil committed R165:5c236107ea81: Simplify ChangeMediator code (authored by dvratil).
Simplify ChangeMediator code
Apr 18 2020, 10:49 AM
dvratil committed R165:d6cea44a61bb: Remove legacy payload handling code from Item (authored by dvratil).
Remove legacy payload handling code from Item
Apr 18 2020, 10:49 AM
dvratil committed R165:f1a31ca9cd0f: Remove the deprecated dynamic exception specifier (authored by dvratil).
Remove the deprecated dynamic exception specifier
Apr 18 2020, 10:49 AM
dvratil committed R165:65f0ff4d8f24: Akonadi server should not expect specific mysql server process name (authored by lukaskaras).
Akonadi server should not expect specific mysql server process name
Apr 18 2020, 10:48 AM
dvratil closed D28903: Akonadi server should not expect specific mysql server process name.
Apr 18 2020, 10:48 AM · KDE PIM
dvratil accepted D28903: Akonadi server should not expect specific mysql server process name.

Thanks for the patch, Lukáši :-)

Apr 18 2020, 10:42 AM · KDE PIM
dvratil requested changes to D28938: DAV resource: propagate color changes to the server.
Apr 18 2020, 10:36 AM · KDE PIM
dvratil requested changes to D28937: EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in the collection.
Apr 18 2020, 10:34 AM · KDE PIM

Apr 15 2020

dvratil accepted D28560: [resources] Add a unified Google Groupware Resource.

Thanks a lot for you work! I think the patch is good to land, but do not commit it yet, please.

Apr 15 2020, 1:04 PM · KDE PIM
dvratil added a comment to T9416: [KAddressbook] Improve the contacts list.

Hi, sorry, I mussed have missed the notification.

Apr 15 2020, 11:57 AM · KDE PIM: Junior Jobs, KDE PIM

Apr 11 2020

dvratil committed R44:c63825275865: Link NewMailNotifierConfig against KF5::AkonadiMime (authored by dvratil).
Link NewMailNotifierConfig against KF5::AkonadiMime
Apr 11 2020, 7:21 AM
dvratil committed R460:83228ddc8f19: Fix CMake and export macro after previous commit (authored by dvratil).
Fix CMake and export macro after previous commit
Apr 11 2020, 7:07 AM
dvratil committed R199:dfae7770eac0: Enable C++17 for AkonadiConsole (authored by dvratil).
Enable C++17 for AkonadiConsole
Apr 11 2020, 6:54 AM
dvratil committed R165:1db4036404ad: Move Pop3ResourceAttribute and NewMailNotifierAttribute to akonadi-mime (authored by dvratil).
Move Pop3ResourceAttribute and NewMailNotifierAttribute to akonadi-mime
Apr 11 2020, 12:25 AM
dvratil committed R165:3a182781b637: Make CollectionPrivate::mParent managed by QScopedPointer (authored by dvratil).
Make CollectionPrivate::mParent managed by QScopedPointer
Apr 11 2020, 12:25 AM
dvratil committed R165:0119e48d509d: Replace custom code by QScopedValueRollback (authored by dvratil).
Replace custom code by QScopedValueRollback
Apr 11 2020, 12:25 AM
dvratil committed R165:72507fe6a663: Remove the dead VarLengthArray code from item_p.h (authored by dvratil).
Remove the dead VarLengthArray code from item_p.h
Apr 11 2020, 12:25 AM