| dvratil |
Drop code that interacts directly with KMime::Message, and use handy NoteUtils::NoteMessageWrapper instead.
It also allows setting of lastModifiedDate (which will become useful useful as sort role).
Also, drop DocumentCursorPositionRole role for model, which is not used anywhere.
Note that there is large code overlap between NoteCreatorAndSelector and LocalResourceCreator.
Will do something with it in the following patches.
Code compiles, new books / pages are still created
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/kjotsmodel.cpp | ||
|---|---|---|
| 185 | Remove the extra spaces inside parentheses. | |
| 237 | Leave QLatin1String here - it is preferred to use the QLatin1String overloads over QString ones when using string literals. Or even better, if there's QStringView overload present, use that one: doc.startsWith(u"<!DOCTYPE") | |
| src/localresourcecreator.cpp | ||
| 149–150 | Can be shortened to item.attribute<Akonadi::EntityDisplayAttribute>(Akonadi::Item::AddIfMissing)->setIconName(QStringLiteral("text-plain")); | |
Address raised points (EDA code also can be changed in the akonadi_next/notecreatorandselector.cpp)