Differential D29252

Port 'Add To Addressbook' action to Akonadi::TagWidget
ClosedPublic
Actions

Authored by dvratil on Apr 28 2020, 12:51 PM.

Tags

Subscribers

Details

Reviewers

Commits

R92:1d5a9ea14449: Port 'Add To Addressbook' action to Akonadi::TagWidget

Summary

They both look and behave the same, but Akonadi::TagWidget is the
"standard" widget used everywhere else.

Diff Detail

Repository

R92 PIM: Common Mail Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.Apr 28 2020, 12:51 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 28 2020, 12:51 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Apr 28 2020, 12:51 PM

Harbormaster completed remote builds in B26024: Diff 81427.Apr 28 2020, 12:51 PM

mlaurent requested changes to this revision.Apr 29 2020, 5:07 AM

mlaurent added inline comments.

src/filter/filteractions/filteractionaddtoaddressbook.cpp
146–147	This signal doesn't exist in akonadi::tagwidget element

This revision now requires changes to proceed.Apr 29 2020, 5:07 AM

Fix signal/slot connection

Harbormaster completed remote builds in B26125: Diff 81572.Apr 30 2020, 10:05 AM

mlaurent requested changes to this revision.Apr 30 2020, 11:22 AM

mlaurent added inline comments.

src/filter/filteractions/filteractionaddtoaddressbook.cpp
35	Duplicate include no ?

This revision now requires changes to proceed.Apr 30 2020, 11:22 AM

Remove duplicate include

Harbormaster completed remote builds in B26251: Diff 81764.May 2 2020, 9:36 PM

mlaurent accepted this revision.May 3 2020, 8:03 AM

This revision is now accepted and ready to land.May 3 2020, 8:03 AM

Closed by commit R92:1d5a9ea14449: Port 'Add To Addressbook' action to Akonadi::TagWidget (authored by dvratil). · Explain WhyMay 5 2020, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/CMakeLists.txt (1 line)
M			src/filter/autotests/filteractionaddtoaddressbooktest.cpp (5 lines)
M			src/filter/filteractions/filteractionaddtoaddressbook.cpp (43 lines)

Diff 81976

src/CMakeLists.txt

Loading...

src/filter/autotests/filteractionaddtoaddressbooktest.cpp

Loading...

src/filter/filteractions/filteractionaddtoaddressbook.cpp

Loading...