- Ported deprecated QPersistentModelIndex::child to QAbstractItemModel::index;
- Ported deprecated KActionCollection::pasteText to paste;
- Ported QStatusBar::addItem/changeItem to QStatusBar::showMessage/clearMessage (for links)
- Removed ancient akonadi_next/note.cpp, which only held mimetype (Akonadi/Notes/NoteUtils has it);
Details
Details
- Reviewers
dvratil - Commits
- R573:70e117f04b31: [KJots] Port deprecated code
- Just select a book or even a resource -> preview is shown for the whole book
- Both Ctrl+V and menu action works fine
- Hovering the text cursor over links shows destination again
- make
Diff Detail
Diff Detail
- Repository
- R573 KJots
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hey @poboiko,
a couple of notes for a followup patch -- no need to change this patch, as the code lacked the i18n handling also before (so this patch is not a regression).
| src/KJotsMain.cpp | ||
|---|---|---|
| 74 | As this is shown as visible string to the user, can you please use i18n() for this UI text? Ideally with a context (see i18nc()) explaining what %1 and %2 are, so translators can understand what the string will show. | |
| src/kjotspart.cpp | ||
| 102 | Ditto. | |