Differential D29241

Replace QRegExp with QRegularExpression
ClosedPublic
Actions

Authored by gjditchfield on Apr 27 2020, 10:18 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R94:528d6d69d9bc: Replace QRegExp with QRegularExpression
Summary

Note: RFC 2369 advises client applications to ignore whitespace inside
the angle brackets, so I added \s* to the mailto regexp in some
places. fromUnicodeString() seems to handle whitespace in the mail
address.

Test Plan

Run replystrategytest and messagefactoryngtest.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gjditchfield created this revision.Apr 27 2020, 10:18 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 27 2020, 10:18 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Apr 27 2020, 10:18 PM
dvratil accepted this revision.May 8 2020, 8:52 PM
dvratil added a subscriber: dvratil.

Seems OK to me.

This revision is now accepted and ready to land.May 8 2020, 8:52 PM
Closed by commit R94:528d6d69d9bc: Replace QRegExp with QRegularExpression (authored by gjditchfield). · Explain WhyMay 9 2020, 8:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82394

View Options

messagecomposer/src/helper/messagefactoryng.cpp

Loading...