Use KDE Jekyll Theme
ClosedPublic

Authored by anujbansal on Apr 19 2020, 9:11 AM.

Details

Reviewers
ognarb
dvratil
Summary

This allows less duplicate code between the kontact websites and other kde websites.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25454
Build 25472: arc lint + arc unit
anujbansal requested review of this revision.Apr 19 2020, 9:11 AM
anujbansal created this revision.
ognarb edited the summary of this revision. (Show Details)Apr 19 2020, 12:23 PM
ognarb added a reviewer: dvratil.
dvratil requested changes to this revision.Apr 20 2020, 2:17 PM

Thanks! Just one comment regarding a removed icon, otherwise it looks good.

download.md
37

Why remove this?

This revision now requires changes to proceed.Apr 20 2020, 2:17 PM
anujbansal added inline comments.Apr 20 2020, 2:24 PM
download.md
37

Microsoft requires us to get permission to use their logos :(
This is why me and carl removed the windows logo from many kde websites. Same with apple.

dvratil accepted this revision.Apr 20 2020, 7:24 PM

I see, thanks for explanation.

This revision is now accepted and ready to land.Apr 20 2020, 7:24 PM
ognarb closed this revision.Apr 21 2020, 3:20 PM