Makes sense that views don't optimize. I was hoping we could avoid scanning the large PimItemTable multiple times and just reuse the list of pim items in the flags/parts/etc. queries. I guess there's no fast way to do that without stored procedures (and creating a temporary table would be too expensive).

that's a good point. I would say that adding a getter to QueryBuilder to get the mTable field and using that in QueryHelpers is a good design decision.

Hi Konrad! This may be a pre-requisite for T645, but it is not directly related to it.

Great work, Konrad! Many thanks for improving KAddressBook!

Thanks for the fix, please land it to the release/20.04 branch.

Ok. I did not notice it's used in the ThemeLoader.

Why not simply ignore the theme if it's already in alreayLoadedThemeName, or at least if themes.contains(dirName)? No need to collect the additional theme paths, if they are not used?

• Remove useless include

Looks good to me know. Thanks for this patch, it's a pretty cool feature, especially for the "Unified mailboxes" agent 👍

Ok, I didn't notice it there, sorry.

Abandon the other one and try updating this one again. You can use arc diff --update D29602 to make sure it updates this one.

• Fix arc going crazy

• Address review comments

Tried it locally and it's pretty cool. Just some nitpicks in the recent changes.

I suppose KJots should now install a new desktopfile to the defaultsetup directory, so that a Notes resource is created by default when user installs KJots?

@mlaurent This change does not have depend on any new messagelib API.

Minor nitpick, otherwise looks good.